Add license_type to linux_virtual_machine

[favoretti]

And add Linux license types to virtual_machine validation.

Fixes #10744

[mbfrahry]

Hey @favoretti, this is looking good but I have a couple questions/suggestions. Also, can we get a couple tests written out to confirm that this works for both linux_virutal_machine and virtual_machine?

[favoretti]

$ TF_ACC=1 go test -v ./azurerm/internal/services/compute -timeout=1000m -run=TestAccLinuxVirtualMachine_otherLicenseType
2021/03/01 21:05:22 [DEBUG] not using binary driver name, it's no longer needed
2021/03/01 21:05:22 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccLinuxVirtualMachine_otherLicenseType
=== PAUSE TestAccLinuxVirtualMachine_otherLicenseType
=== CONT  TestAccLinuxVirtualMachine_otherLicenseType
--- PASS: TestAccLinuxVirtualMachine_otherLicenseType (371.29s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/compute	372.634s

[mbfrahry]

Nearly there! I missed that linux_virtual_machine has separate Create/Update functions so we'll want to add license_type to the update method as well.

[favoretti]

Ack, my bad. Will fix in my morning, sorry about this.

[tombuildsstuff]

hi @favoretti

Thanks for pushing those changes.

Taking a look through here whilst this mostly looks good we'll need to revert the changes to the legacy azurerm_virtual_machine resource since this is feature-frozen.

Thanks!

[tombuildsstuff]

LGTM 👍

dismissing since changes have been pushed

[ghost]

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!