Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new resource "azurerm_kusto_eventgrid_data_connection" #10712

Merged
merged 4 commits into from
Mar 1, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Feb 24, 2021

changes contained in this PR :

  1. generate parse and validate func for eventhub, refactor eventhub resource
  2. new resource "azurerm_kusto_eventgrid_data_connection"

doc: https://docs.microsoft.com/en-us/azure/data-explorer/ingest-data-event-grid-overview
according to https://docs.microsoft.com/en-us/azure/data-explorer/ingest-data-event-grid-manual#prerequisites, Prerequisite resources are kusto cluster, kusto database, storage account, eventhub namespace, eventhub, event grid subscription

image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ - overall looks good, just a couple comments inline to address

@njuCZ
Copy link
Contributor Author

njuCZ commented Feb 26, 2021

@katbyte thanks for your opinion. I have refined this PR and rerun all acctest.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ - LGTM 👍

@katbyte katbyte merged commit f484af6 into hashicorp:master Mar 1, 2021
katbyte added a commit that referenced this pull request Mar 1, 2021
@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.50.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 31, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants