Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: updating github.com/hashicorp/terraform-plugin-sdk to the latest 1.x branch #10692

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

tombuildsstuff
Copy link
Contributor

The upstream commit 32f0219df5b532bbdf5071f7f53e33655e5621eb includes hashicorp/terraform-plugin-sdk#702 which should fix Binary Testing - unblocking #10523

@tombuildsstuff tombuildsstuff added this to the v2.49.0 milestone Feb 23, 2021
@tombuildsstuff tombuildsstuff requested a review from a team February 23, 2021 06:55
@ghost ghost added the size/XXL label Feb 23, 2021
@tombuildsstuff
Copy link
Contributor Author

Running an import test with the non-binary test framework and this seems fine:

 $ TF_ACC=1 go test -v ./azurerm/internal/services/resource/... -run=TestAccResourceGroup_basic -timeout=60m
=== RUN   TestAccResourceGroup_basic
=== PAUSE TestAccResourceGroup_basic
=== CONT  TestAccResourceGroup_basic
--- PASS: TestAccResourceGroup_basic (112.33s)

@tombuildsstuff
Copy link
Contributor Author

Rebasing #10523 on top of this those pass too:

$ TF_ACC=1 go test -v ./azurerm/internal/services/resource/... -run=TestAccResourceGroup_basic -timeout=60m
2021/02/23 08:14:24 [DEBUG] not using binary driver name, it's no longer needed
2021/02/23 08:14:27 [DEBUG] not using binary driver name, it's no longer needed
=== RUN   TestAccResourceGroup_basic
=== PAUSE TestAccResourceGroup_basic
=== CONT  TestAccResourceGroup_basic
--- PASS: TestAccResourceGroup_basic (160.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/resource	164.058s

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - LGTM 👍

@tombuildsstuff tombuildsstuff merged commit ab29b10 into master Feb 23, 2021
@tombuildsstuff tombuildsstuff deleted the deps/plugin-sdk-v1.x branch February 23, 2021 07:27
tombuildsstuff added a commit that referenced this pull request Feb 23, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.49.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants