new resource: azurerm_sentinel_data_connector_azure_active_directory
#10665
Conversation
magodo
force-pushed
the
sentinel_dataconnector_azure_active_directory
branch
from
eae1c9e to
b2a847a
Compare
There was a problem hiding this comment.
hey @magodo
Thanks for rebasing this PR - I've taken a look through and left a couple of comments inline but this otherwise LGTM 👍
Thanks!
| } | ||
| } | ||
|
|
||
| return tf.ImportAsExistsError("azurerm_sentinel_data_connector_azure_active_directory", id.ID()) |
There was a problem hiding this comment.
this'll need to be wrapped:
| return tf.ImportAsExistsError("azurerm_sentinel_data_connector_azure_active_directory", id.ID()) | |
| if !utils.ResponseWasNotFound(resp.Response) { | |
| return tf.ImportAsExistsError("azurerm_sentinel_data_connector_azure_active_directory", id.ID()) | |
| } |
There was a problem hiding this comment.
In case the the status code is 404, the err is always non-nil. In other words, if the err is nil, then this condition (!utils.ResponseWasNotFound(resp.Response)) is always true.
azurerm/internal/services/sentinel/sentinel_data_connector_azure_active_directory.go
Outdated
Show resolved
Hide resolved
…ector_azure_active_directory
|
This has been released in version 2.50.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.50.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
new resource:
azurerm_sentinel_data_connector_azure_active_directory