Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/log_analytics_workspace - Expose capacity_reservation_level and CapacityReservation SKU value #10612

Conversation

jackbatzner
Copy link
Contributor

Fixes #10553

=== RUN TestAccLogAnalyticsWorkspace_withCapacityReservation
=== PAUSE TestAccLogAnalyticsWorkspace_withCapacityReservation
=== CONT TestAccLogAnalyticsWorkspace_withCapacityReservation
--- PASS: TestAccLogAnalyticsWorkspace_withCapacityReservation (152.36s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/loganalytics 154.175s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @Brunhil, looks good but i do have a question about the name again, looking up what level meant i wonder if it would be better to change it as per my comments left inline

@jackbatzner jackbatzner requested a review from katbyte February 17, 2021 23:55
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Brunhil - LGTM now 👍

@jackofallops
Copy link
Member

Tests Passing:
image

@jackofallops jackofallops dismissed katbyte’s stale review February 18, 2021 09:44

Changes addressed

@jackofallops jackofallops merged commit bf55cbd into hashicorp:master Feb 18, 2021
jackofallops added a commit that referenced this pull request Feb 18, 2021
@ghost
Copy link

ghost commented Feb 18, 2021

This has been released in version 2.48.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.48.0"
}
# ... other configuration ...

@jackbatzner jackbatzner deleted the loganalytics_capacity_reservation_level branch March 2, 2021 02:27
@ghost
Copy link

ghost commented Mar 20, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for capacityReservationLevel in azurerm_log_analytics_workspace
4 participants