Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resource.Retry to PurgeNestedItem #10577

Merged
merged 6 commits into from
Feb 23, 2021
Merged

Add resource.Retry to PurgeNestedItem #10577

merged 6 commits into from
Feb 23, 2021

Conversation

pearcec
Copy link
Contributor

@pearcec pearcec commented Feb 12, 2021

No description provided.

@ghost ghost added the size/XS label Feb 12, 2021
@pearcec pearcec marked this pull request as draft February 12, 2021 21:21
@pearcec pearcec mentioned this pull request Feb 12, 2021
Closed
@pearcec
Copy link
Contributor Author

pearcec commented Feb 12, 2021

I need to adjust the error messages to be generic and not specific to the secret.

@ghost ghost added size/M and removed size/XS labels Feb 15, 2021
@pearcec pearcec marked this pull request as ready for review February 15, 2021 17:45
@tombuildsstuff tombuildsstuff self-assigned this Feb 15, 2021
@StefanVo

This comment has been minimized.

Sign in to view
tombuildsstuff
tombuildsstuff approved these changes Feb 23, 2021
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this @pearcec

@tombuildsstuff
Copy link
Contributor

tombuildsstuff commented Feb 23, 2021 •
edited
Loading

Running the tests for this there's some residual test-only failures from #10593 which I'll fix in a subsequent PR, but this is otherwise fine 👍

@tombuildsstuff
Copy link
Contributor

Unintentionally pressed a key combination to close the PR, sorry 🤦

@tombuildsstuff tombuildsstuff merged commit b1deb2a into hashicorp:master Feb 23, 2021
@tombuildsstuff tombuildsstuff added this to the v2.49.0 milestone Feb 23, 2021
tombuildsstuff added a commit that referenced this pull request Feb 23, 2021
@tombuildsstuff
updating to include #10577
4caa88f
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 2.49.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.49.0"
}
# ... other configuration ...

@joselcaguilar joselcaguilar mentioned this pull request Feb 26, 2021
Closed
@giacomo-pati giacomo-pati mentioned this pull request Feb 26, 2021
Closed
@ghost
Copy link

ghost commented Mar 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees

@tombuildsstuff tombuildsstuff

Labels
bug service/key-vault Key Vault size/M
Projects
None yet
Milestone
v2.49.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pearcec @StefanVo @tombuildsstuff