Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: updating to v1.16.0 of github.com/hashicorp/terraform-plugin-sdk #10521

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

tombuildsstuff
Copy link
Contributor

Necessary for Binary Testing

@tombuildsstuff tombuildsstuff added this to the v2.47.0 milestone Feb 10, 2021
@ghost ghost added the size/XXL label Feb 10, 2021
@tombuildsstuff tombuildsstuff requested a review from a team February 10, 2021 14:13
tombuildsstuff added a commit that referenced this pull request Feb 10, 2021
This commit enables the feature toggle for Binary Testing - which switches to using the
real Terraform Binary when running Acceptance Tests and allows for different versions of
Core to be used.

Due to the use of Service Packages, we require that Reattach testing is used - as such
this requires using Terraform Core 0.12.26 or later.

This commit depends on - and must be rebased on top of - #10521 and #10519 due to the
removal of `acceptance.AzureProvider` when Binary Testing is being used.

A future commit will remove support for the legacy testing framework after a suitable
transition period, but for the moment disabling this functionality is sufficient.
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Running some acctests this looks good 👍

@tombuildsstuff tombuildsstuff merged commit b8789b3 into master Feb 10, 2021
@tombuildsstuff tombuildsstuff deleted the deps/plugin-sdk-v1.16 branch February 10, 2021 17:26
tombuildsstuff added a commit that referenced this pull request Feb 10, 2021
tombuildsstuff added a commit that referenced this pull request Feb 10, 2021
This commit enables the feature toggle for Binary Testing - which switches to using the
real Terraform Binary when running Acceptance Tests and allows for different versions of
Core to be used.

Due to the use of Service Packages, we require that Reattach testing is used - as such
this requires using Terraform Core 0.12.26 or later.

This commit depends on - and must be rebased on top of - #10521 and #10519 due to the
removal of `acceptance.AzureProvider` when Binary Testing is being used.

A future commit will remove support for the legacy testing framework after a suitable
transition period, but for the moment disabling this functionality is sufficient.
tombuildsstuff added a commit that referenced this pull request Feb 11, 2021
This commit enables the feature toggle for Binary Testing - which switches to using the
real Terraform Binary when running Acceptance Tests and allows for different versions of
Core to be used.

Due to the use of Service Packages, we require that Reattach testing is used - as such
this requires using Terraform Core 0.12.26 or later.

This commit depends on - and must be rebased on top of - #10521 and #10519 due to the
removal of `acceptance.AzureProvider` when Binary Testing is being used.

A future commit will remove support for the legacy testing framework after a suitable
transition period, but for the moment disabling this functionality is sufficient.
@ghost
Copy link

ghost commented Feb 11, 2021

This has been released in version 2.47.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.47.0"
}
# ... other configuration ...

tombuildsstuff added a commit that referenced this pull request Feb 23, 2021
This commit enables the feature toggle for Binary Testing - which switches to using the
real Terraform Binary when running Acceptance Tests and allows for different versions of
Core to be used.

Due to the use of Service Packages, we require that Reattach testing is used - as such
this requires using Terraform Core 0.12.26 or later.

This commit depends on - and must be rebased on top of - #10521 and #10519 due to the
removal of `acceptance.AzureProvider` when Binary Testing is being used.

A future commit will remove support for the legacy testing framework after a suitable
transition period, but for the moment disabling this functionality is sufficient.
@ghost
Copy link

ghost commented Mar 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants