Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service: ip_restriction.x.ip_address now accepts anything other than an empty string. #10440

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

PeterIttner
Copy link
Contributor

@PeterIttner PeterIttner commented Feb 2, 2021

AppService IP Restrictions may also include Strings like: "AzureFrontDoor.Backend" and not just IP-Addresses (CIDRs).

When importing an AppService into a Terraform-State one can see also this.
The datasource schema also allows a string here.

Further improvement would also be to not just allow any string but to allow only valid strings, but for it would not prevent a valid app service configuration.

Imported state looks like:

               "ip_restriction": [
                  {
                    "action": "Allow",
                    "ip_address": "AzureFrontDoor.Backend",
                    "name": "Allow FD only",
                    "priority": 100,
                    "virtual_network_subnet_id": ""
                  }
                ],

AppService IP Restrictions can also include Strings like: "AzureFrontDoor.Backend" and not just IP-Addresses (CIDRs). When importing an AppService into a Terraform-State one can see also this. The datasource schema also allows a string here.
Further improvement would also be to not just allow any string but to allow only valid strings, but for it would not prevent a valid app service configuration.
Imported state looks like:

```
"ip_restriction": [
                  {
                    "action": "Allow",
                    "ip_address": "AzureFrontDoor.Backend",
                    "name": "Allow FD only",
                    "priority": 100,
                    "virtual_network_subnet_id": ""
                  }
                ],
```
@ghost ghost added the size/XS label Feb 2, 2021
@PeterIttner PeterIttner changed the title Fix Bug with AppService IP Restrictions azurerm_appservice: Fix Bug with AppService IP Restrictions Feb 2, 2021
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbfrahry mbfrahry changed the title azurerm_appservice: Fix Bug with AppService IP Restrictions azurerm_app_service: ip_restriction.x.ip_address now accepts anything other than an empty string. Feb 8, 2021
@mbfrahry mbfrahry added this to the v2.47.0 milestone Feb 8, 2021
@mbfrahry mbfrahry merged commit ec00637 into hashicorp:master Feb 8, 2021
mbfrahry added a commit that referenced this pull request Feb 8, 2021
@ghost
Copy link

ghost commented Feb 11, 2021

This has been released in version 2.47.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.47.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants