Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/(linux|windows)_virtual_machine_scale_set: fixing the parsing of settings and protected_settings when these are empty strings #10351

Merged
merged 5 commits into from
Jan 28, 2021

Conversation

tombuildsstuff
Copy link
Contributor

This PR supersedes the work done by @416e64726579 in #8420 - and adds a test to the azurerm_windows_virtual_machine_scale_set resource to capture using a VM Extension where only Settings are configured.

In addition this splits the VM Extension tests out into their own file, since there's enough of them to make this worthwhile.

@tombuildsstuff tombuildsstuff added bug service/vmss Virtual Machine Scale Sets labels Jan 28, 2021
@tombuildsstuff tombuildsstuff added this to the v2.45.0 milestone Jan 28, 2021
@ghost ghost added the size/XXL label Jan 28, 2021
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - LGTM 👍

@tombuildsstuff
Copy link
Contributor Author

Tests look ok 👍

@tombuildsstuff tombuildsstuff merged commit 9930028 into master Jan 28, 2021
@tombuildsstuff tombuildsstuff deleted the b/8420-extensions branch January 28, 2021 10:29
tombuildsstuff added a commit that referenced this pull request Jan 28, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.45.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 27, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug service/vmss Virtual Machine Scale Sets size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants