Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"azurerm_key_vault" - supports ipv4 and cidr format for property "network_acls.ip_rules" #10266

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

njuCZ
Copy link
Contributor

@njuCZ njuCZ commented Jan 21, 2021

fix #8701

generally two ways to fix this issue:

  1. only cidr format is allowed
  2. accept cidr and ipv4, when calculate hash, convert ipv4 to cidr

this PR choose the second way

@ghost ghost added the size/XS label Jan 21, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @njuCZ - could we add a test for this issue? thanks

@njuCZ
Copy link
Contributor Author

njuCZ commented Jan 25, 2021

@katbyte, this PR contains a test for ipv4 address format and cidr format ips. I think maybe it's enough?

@ghost ghost removed the waiting-response label Jan 25, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @njuCZ - LGTM 👍

@katbyte katbyte added this to the v2.45.0 milestone Jan 27, 2021
@katbyte katbyte merged commit 91a16c0 into hashicorp:master Jan 27, 2021
katbyte added a commit that referenced this pull request Jan 27, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.45.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 27, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_key_vault - network_acls - ip_rules keeps re-applying
2 participants