-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPDATE delete VMs that are in failed state #10189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @HappyTobi
Thanks for this PR - I've taken a look through and left some comments inline but if we can fix those up then we should be able to run the tests and get this merged 👍
Thanks!
azurerm/internal/services/compute/linux_virtual_machine_resource.go
Outdated
Show resolved
Hide resolved
Hi @tombuildsstuff, I changed the comments hope you like that. Bg |
9ab6c1e
to
9f20056
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for pushing those changes @HappyTobi
Tests look good 👍 |
This has been released in version 2.45.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.45.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
Hi @tombuildsstuff,
here is just a fix to delete VM's that are in failed state.
I also deleted the comments about "power off was saving costs, thats wrong see also the azure sdk comment: power off)
The scenario for that was that you import you VM's into your TF state and some of them are at a "Failed" state. Atm the VM's couldn't be delete with TF because the "power off" will fail.
With the small fix it was possible to clean the VM's.
Bg
Tobi