Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/devspace_controller: disabling the tests & highlighting this'll be removed in 3.0 #10049

Merged
merged 4 commits into from
Jan 5, 2021

Conversation

tombuildsstuff
Copy link
Contributor

There's a breaking behavioural change in the API where provisioning new instances returns:

Azure Dev Spaces Controller creation is blocked because Azure Dev Spaces is being retired. Bridge to Kubernetes is an improved alternative to many of the Azure Dev Spaces development scenarios. Learn more here: https://aka.ms/migrate-to-bridge.

As such, there's no point running these tests since they're going to fail - but this resource will continue to be usable for existing users, albeit we can no longer test it.

This PR introduces a deprecation message for this resource - and prepares it to be removed in 3.0.

There's a breaking behavioural change in the API where provisioning new instances returns:

> Azure Dev Spaces Controller creation is blocked because Azure Dev Spaces is being retired. Bridge to Kubernetes is an improved alternative to many of the Azure Dev Spaces development scenarios. Learn more here: https://aka.ms/migrate-to-bridge.

As such, there's no point running these tests since they're going to fail.

This resource will continue to be usable for existing users, but we can no longer test it.
All of the tests in this package can no longer be run, so there's
no point in these being listed, tbqh.
@tombuildsstuff tombuildsstuff added this to the v2.42.0 milestone Jan 5, 2021
@tombuildsstuff tombuildsstuff requested a review from a team January 5, 2021 10:18
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit 502b1d1 into master Jan 5, 2021
@tombuildsstuff tombuildsstuff deleted the b/tests-devspace branch January 5, 2021 11:51
tombuildsstuff added a commit that referenced this pull request Jan 5, 2021
@ghost
Copy link

ghost commented Jan 8, 2021

This has been released in version 2.42.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.42.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Feb 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants