From fcb56295db8de4740cda1605f2b246da179d27e5 Mon Sep 17 00:00:00 2001 From: kt Date: Fri, 25 Oct 2019 09:23:18 -0700 Subject: [PATCH 1/5] first pass --- azurerm/data_source_batch_account_test.go | 70 +-- azurerm/data_source_batch_pool_test.go | 2 +- ...ta_source_dev_test_virtual_network_test.go | 32 +- .../data_source_express_route_circuit_test.go | 8 +- azurerm/data_source_resources_test.go | 16 +- azurerm/data_source_sql_database_test.go | 18 +- ...a_source_storage_management_policy_test.go | 30 +- ...ource_arm_analysis_services_server_test.go | 74 ++-- azurerm/resource_arm_api_management_test.go | 8 +- ..._arm_app_service_certificate_order_test.go | 34 +- ...source_arm_app_service_certificate_test.go | 2 +- azurerm/resource_arm_app_service_slot_test.go | 30 +- azurerm/resource_arm_app_service_test.go | 16 +- .../resource_arm_application_gateway_test.go | 26 +- .../resource_arm_automation_account_test.go | 4 +- azurerm/resource_arm_availability_set_test.go | 2 +- azurerm/resource_arm_bastion_host_test.go | 6 +- azurerm/resource_arm_batch_account_test.go | 24 +- .../resource_arm_batch_application_test.go | 4 +- azurerm/resource_arm_batch_pool_test.go | 8 +- azurerm/resource_arm_bot_connection_test.go | 4 +- azurerm/resource_arm_container_group_test.go | 2 +- .../resource_arm_container_registry_test.go | 4 +- ...rce_arm_container_registry_webhook_test.go | 194 ++++----- ...esource_arm_cosmosdb_sql_container_test.go | 2 +- azurerm/resource_arm_dashboard_test.go | 22 +- ...actory_integration_runtime_managed_test.go | 4 +- ...resource_arm_dev_test_lab_schedule_test.go | 262 ++++++------ ...namespace_disaster_recovery_config_test.go | 26 +- azurerm/resource_arm_firewall_test.go | 2 +- ...rce_arm_front_door_firewall_policy_test.go | 4 +- azurerm/resource_arm_front_door_test.go | 36 +- .../resource_arm_healthcare_service_test.go | 16 +- azurerm/resource_arm_iothub_test.go | 12 +- azurerm/resource_arm_key_vault_test.go | 2 +- .../resource_arm_kubernetes_cluster_test.go | 54 +-- azurerm/resource_arm_kusto_cluster_test.go | 8 +- ...arm_kusto_eventhub_data_connection_test.go | 4 +- ...nux_virtual_machine_scale_set_auth_test.go | 15 +- ...irtual_machine_scale_set_disk_data_test.go | 113 ++--- ..._virtual_machine_scale_set_disk_os_test.go | 75 ++-- ...virtual_machine_scale_set_identity_test.go | 66 +-- ...x_virtual_machine_scale_set_images_test.go | 116 ++--- ..._virtual_machine_scale_set_network_test.go | 398 +++++++++--------- ...ux_virtual_machine_scale_set_other_test.go | 219 +++++----- ..._virtual_machine_scale_set_scaling_test.go | 183 ++++---- azurerm/resource_arm_mariadb_server_test.go | 2 +- .../resource_arm_monitor_action_group_test.go | 12 +- ...rce_arm_monitor_diagnostic_setting_test.go | 6 +- azurerm/resource_arm_mysql_server_test.go | 2 +- ...otification_hub_authorization_rule_test.go | 24 +- ...vate_dns_zone_virtual_network_link_test.go | 22 +- ...ource_arm_recovery_services_fabric_test.go | 8 +- ..._recovery_services_network_mapping_test.go | 46 +- ...arm_recovery_services_protected_vm_test.go | 12 +- ...vices_protection_container_mapping_test.go | 54 +-- ...very_services_protection_container_test.go | 16 +- ...rm_recovery_services_replicated_vm_test.go | 140 +++--- azurerm/resource_arm_redis_cache_test.go | 30 +- azurerm/resource_arm_sql_database_test.go | 2 +- .../resource_arm_sql_failover_group_test.go | 30 +- azurerm/resource_arm_storage_account_test.go | 4 +- azurerm/resource_arm_storage_blob_test.go | 4 +- ...urce_arm_storage_management_policy_test.go | 240 +++++------ .../resource_arm_storage_table_entity_test.go | 10 +- .../resource_arm_stream_analytics_job_test.go | 6 +- ...ource_arm_traffic_manager_endpoint_test.go | 8 +- ...urce_arm_virtual_machine_scale_set_test.go | 14 +- azurerm/resource_arm_virtual_machine_test.go | 2 +- ...irtual_machine_scale_set_disk_data_test.go | 8 +- ...virtual_machine_scale_set_identity_test.go | 6 +- ...s_virtual_machine_scale_set_images_test.go | 44 +- ..._virtual_machine_scale_set_network_test.go | 68 +-- ...ws_virtual_machine_scale_set_other_test.go | 164 ++++---- ..._virtual_machine_scale_set_scaling_test.go | 170 ++++---- 75 files changed, 1741 insertions(+), 1670 deletions(-) diff --git a/azurerm/data_source_batch_account_test.go b/azurerm/data_source_batch_account_test.go index 4419f433970c..10ba4eabf343 100644 --- a/azurerm/data_source_batch_account_test.go +++ b/azurerm/data_source_batch_account_test.go @@ -145,54 +145,54 @@ data "azurerm_batch_account" "test" { func testAccDataSourceAzureBatchAccount_userSubscription(rInt int, rString string, location string, tenantID string, subscriptionID string) string { return fmt.Sprintf(` data "azurerm_azuread_service_principal" "test" { - display_name = "Microsoft Azure Batch" + display_name = "Microsoft Azure Batch" } resource "azurerm_resource_group" "test" { - name = "testaccRG-%d-batchaccount" - location = "%s" + name = "testaccRG-%d-batchaccount" + location = "%s" } resource "azurerm_key_vault" "test" { - name = "batchkv%s" - location = "${azurerm_resource_group.test.location}" - resource_group_name = "${azurerm_resource_group.test.name}" - enabled_for_disk_encryption = true - enabled_for_deployment = true - enabled_for_template_deployment = true - tenant_id = "%s" - - sku { - name = "standard" - } - - access_policy { - tenant_id = "%s" - object_id = "${data.azurerm_azuread_service_principal.test.object_id}" - - secret_permissions = [ - "get", - "list", - "set", - "delete" - ] - - } + name = "batchkv%s" + location = "${azurerm_resource_group.test.location}" + resource_group_name = "${azurerm_resource_group.test.name}" + enabled_for_disk_encryption = true + enabled_for_deployment = true + enabled_for_template_deployment = true + tenant_id = "%s" + + sku { + name = "standard" + } + + access_policy { + tenant_id = "%s" + object_id = "${data.azurerm_azuread_service_principal.test.object_id}" + + secret_permissions = [ + "get", + "list", + "set", + "delete" + ] + + } } resource "azurerm_role_assignment" "contribrole" { - scope = "/subscriptions/%s" - role_definition_name = "Contributor" - principal_id = "${data.azurerm_azuread_service_principal.test.object_id}" + scope = "/subscriptions/%s" + role_definition_name = "Contributor" + principal_id = "${data.azurerm_azuread_service_principal.test.object_id}" } resource "azurerm_batch_account" "test" { - name = "testaccbatch%s" - resource_group_name = "${azurerm_resource_group.test.name}" - location = "${azurerm_resource_group.test.location}" - + name = "testaccbatch%s" + resource_group_name = "${azurerm_resource_group.test.name}" + location = "${azurerm_resource_group.test.location}" + pool_allocation_mode = "UserSubscription" - + key_vault_reference { id = "${azurerm_key_vault.test.id}" url = "${azurerm_key_vault.test.vault_uri}" diff --git a/azurerm/data_source_batch_pool_test.go b/azurerm/data_source_batch_pool_test.go index 5d5d20ff2530..9dc43adad578 100644 --- a/azurerm/data_source_batch_pool_test.go +++ b/azurerm/data_source_batch_pool_test.go @@ -129,7 +129,7 @@ resource "azurerm_batch_pool" "test" { container_configuration { type = "DockerCompatible" - container_registries= [ + container_registries = [ { registry_server = "myContainerRegistry.azurecr.io" user_name = "myUserName" diff --git a/azurerm/data_source_dev_test_virtual_network_test.go b/azurerm/data_source_dev_test_virtual_network_test.go index 8a794b56edc6..c333f6da4a50 100644 --- a/azurerm/data_source_dev_test_virtual_network_test.go +++ b/azurerm/data_source_dev_test_virtual_network_test.go @@ -48,31 +48,31 @@ func TestAccDataSourceArmDevTestVirtualNetwork_basic(t *testing.T) { func testAccDataSourceArmDevTestVirtualNetwork_basic(rInt int, location string) string { return fmt.Sprintf(` resource "azurerm_resource_group" "test" { - name = "acctestRG-%d" - location = "%s" + name = "acctestRG-%d" + location = "%s" } resource "azurerm_dev_test_lab" "test" { - name = "acctestdtl%d" - location = "${azurerm_resource_group.test.location}" - resource_group_name = "${azurerm_resource_group.test.name}" + name = "acctestdtl%d" + location = "${azurerm_resource_group.test.location}" + resource_group_name = "${azurerm_resource_group.test.name}" } resource "azurerm_dev_test_virtual_network" "test" { - name = "acctestdtvn%d" - lab_name = "${azurerm_dev_test_lab.test.name}" - resource_group_name = "${azurerm_resource_group.test.name}" - - subnet { - use_public_ip_address = "Allow" - use_in_virtual_machine_creation = "Allow" - } + name = "acctestdtvn%d" + lab_name = "${azurerm_dev_test_lab.test.name}" + resource_group_name = "${azurerm_resource_group.test.name}" + + subnet { + use_public_ip_address = "Allow" + use_in_virtual_machine_creation = "Allow" + } } data "azurerm_dev_test_virtual_network" "test" { - name = "${azurerm_dev_test_virtual_network.test.name}" - lab_name = "${azurerm_dev_test_lab.test.name}" - resource_group_name = "${azurerm_resource_group.test.name}" + name = "${azurerm_dev_test_virtual_network.test.name}" + lab_name = "${azurerm_dev_test_lab.test.name}" + resource_group_name = "${azurerm_resource_group.test.name}" } diff --git a/azurerm/data_source_express_route_circuit_test.go b/azurerm/data_source_express_route_circuit_test.go index 6f7ff8138f96..7189b8ad99a1 100644 --- a/azurerm/data_source_express_route_circuit_test.go +++ b/azurerm/data_source_express_route_circuit_test.go @@ -39,9 +39,9 @@ func testAccDataSourceAzureRMExpressRoute_basic(rInt int, location string) strin return fmt.Sprintf(` %s - data "azurerm_express_route_circuit" test { - resource_group_name = "${azurerm_resource_group.test.name}" - name = "${azurerm_express_route_circuit.test.name}" - } +data "azurerm_express_route_circuit" test { + resource_group_name = "${azurerm_resource_group.test.name}" + name = "${azurerm_express_route_circuit.test.name}" +} `, config) } diff --git a/azurerm/data_source_resources_test.go b/azurerm/data_source_resources_test.go index 79356cd04651..98532776c155 100644 --- a/azurerm/data_source_resources_test.go +++ b/azurerm/data_source_resources_test.go @@ -107,7 +107,7 @@ func testAccDataSourceAzureRMResources_ByName(rInt int, rString string, location %s data "azurerm_resources" "test" { - name = "${azurerm_storage_account.test.name}" + name = "${azurerm_storage_account.test.name}" } `, r) } @@ -129,8 +129,8 @@ func testAccDataSourceAzureRMResources_ByResourceType(rInt int, rString string, %s data "azurerm_resources" "test" { - resource_group_name = "${azurerm_storage_account.test.resource_group_name}" - type = "Microsoft.Storage/storageAccounts" + resource_group_name = "${azurerm_storage_account.test.resource_group_name}" + type = "Microsoft.Storage/storageAccounts" } `, r) } @@ -142,11 +142,11 @@ func testAccDataSourceAzureRMResources_FilteredByTags(rInt int, rString string, data "azurerm_resources" "test" { name = "${azurerm_storage_account.test.name}" - resource_group_name = "${azurerm_storage_account.test.resource_group_name}" - - required_tags = { - environment = "production" - } + resource_group_name = "${azurerm_storage_account.test.resource_group_name}" + + required_tags = { + environment = "production" + } } `, r) } diff --git a/azurerm/data_source_sql_database_test.go b/azurerm/data_source_sql_database_test.go index f5d9340bdd35..c77ac67b2ebc 100644 --- a/azurerm/data_source_sql_database_test.go +++ b/azurerm/data_source_sql_database_test.go @@ -92,9 +92,9 @@ func testAccDataSourceAzureRMSqlDatabase_basic(rInt int, location string) string %s data "azurerm_sql_database" "test" { - name = "${azurerm_sql_database.test.name}" - server_name = "${azurerm_sql_database.test.server_name}" - resource_group_name = "${azurerm_resource_group.test.name}" + name = "${azurerm_sql_database.test.name}" + server_name = "${azurerm_sql_database.test.server_name}" + resource_group_name = "${azurerm_resource_group.test.name}" } `, template) } @@ -105,9 +105,9 @@ func testAccDataSourceAzureRMSqlDatabase_elasticPool(rInt int, location string) %s data "azurerm_sql_database" "test" { - name = "${azurerm_sql_database.test.name}" - server_name = "${azurerm_sql_database.test.server_name}" - resource_group_name = "${azurerm_resource_group.test.name}" + name = "${azurerm_sql_database.test.name}" + server_name = "${azurerm_sql_database.test.server_name}" + resource_group_name = "${azurerm_resource_group.test.name}" } `, template) } @@ -118,9 +118,9 @@ func testAccDataSourceAzureRMSqlDatabase_readScale(rInt int, location string, re %s data "azurerm_sql_database" "test" { - name = "${azurerm_sql_database.test.name}" - server_name = "${azurerm_sql_database.test.server_name}" - resource_group_name = "${azurerm_resource_group.test.name}" + name = "${azurerm_sql_database.test.name}" + server_name = "${azurerm_sql_database.test.server_name}" + resource_group_name = "${azurerm_resource_group.test.name}" } `, template) } diff --git a/azurerm/data_source_storage_management_policy_test.go b/azurerm/data_source_storage_management_policy_test.go index 4a561619dd47..64c66ae83aaf 100644 --- a/azurerm/data_source_storage_management_policy_test.go +++ b/azurerm/data_source_storage_management_policy_test.go @@ -64,24 +64,24 @@ resource "azurerm_storage_account" "testsa" { resource "azurerm_storage_management_policy" "testpolicy" { storage_account_id = "${azurerm_storage_account.testsa.id}" - + rule { - name = "rule1" - enabled = true - filters { - prefix_match = [ "container1/prefix1" ] - blob_types = [ "blockBlob" ] - } - actions { + name = "rule1" + enabled = true + filters { + prefix_match = ["container1/prefix1"] + blob_types = ["blockBlob"] + } + actions { base_blob { tier_to_cool_after_days_since_modification_greater_than = 10 - tier_to_archive_after_days_since_modification_greater_than = 50 - delete_after_days_since_modification_greater_than = 100 - } - snapshot { - delete_after_days_since_creation_greater_than = 30 - } - } + tier_to_archive_after_days_since_modification_greater_than = 50 + delete_after_days_since_modification_greater_than = 100 + } + snapshot { + delete_after_days_since_creation_greater_than = 30 + } + } } } diff --git a/azurerm/resource_arm_analysis_services_server_test.go b/azurerm/resource_arm_analysis_services_server_test.go index f1817a698b46..6cfdb9e75596 100644 --- a/azurerm/resource_arm_analysis_services_server_test.go +++ b/azurerm/resource_arm_analysis_services_server_test.go @@ -250,7 +250,7 @@ resource "azurerm_analysis_services_server" "test" { name = "acctestass%d" location = "${azurerm_resource_group.test.location}" resource_group_name = "${azurerm_resource_group.test.name}" - sku = "B1" + sku = "B1" } `, rInt, location, rInt) } @@ -266,10 +266,10 @@ resource "azurerm_analysis_services_server" "test" { name = "acctestass%d" location = "${azurerm_resource_group.test.location}" resource_group_name = "${azurerm_resource_group.test.name}" - sku = "B1" + sku = "B1" tags = { - label = "test" + label = "test" } } `, rInt, location, rInt) @@ -286,11 +286,11 @@ resource "azurerm_analysis_services_server" "test" { name = "acctestass%d" location = "${azurerm_resource_group.test.location}" resource_group_name = "${azurerm_resource_group.test.name}" - sku = "B1" + sku = "B1" tags = { - label = "test1" - ENV = "prod" + label = "test1" + ENV = "prod" } } `, rInt, location, rInt) @@ -304,10 +304,10 @@ resource "azurerm_resource_group" "test" { } resource "azurerm_analysis_services_server" "test" { - name = "acctestass%d" - location = "${azurerm_resource_group.test.location}" - resource_group_name = "${azurerm_resource_group.test.name}" - sku = "B1" + name = "acctestass%d" + location = "${azurerm_resource_group.test.location}" + resource_group_name = "${azurerm_resource_group.test.name}" + sku = "B1" querypool_connection_mode = "%s" } `, rInt, location, rInt, connectionMode) @@ -321,11 +321,11 @@ resource "azurerm_resource_group" "test" { } resource "azurerm_analysis_services_server" "test" { - name = "acctestass%d" - location = "${azurerm_resource_group.test.location}" - resource_group_name = "${azurerm_resource_group.test.name}" - sku = "B1" - enable_power_bi_service = %t + name = "acctestass%d" + location = "${azurerm_resource_group.test.location}" + resource_group_name = "${azurerm_resource_group.test.name}" + sku = "B1" + enable_power_bi_service = %t } `, rInt, location, rInt, enablePowerBIService) } @@ -338,12 +338,12 @@ resource "azurerm_resource_group" "test" { } resource "azurerm_analysis_services_server" "test" { - name = "acctestass%d" - location = "${azurerm_resource_group.test.location}" - resource_group_name = "${azurerm_resource_group.test.name}" - sku = "B1" - enable_power_bi_service = %t - + name = "acctestass%d" + location = "${azurerm_resource_group.test.location}" + resource_group_name = "${azurerm_resource_group.test.name}" + sku = "B1" + enable_power_bi_service = %t + ipv4_firewall_rule { name = "test1" range_start = "92.123.234.11" @@ -361,12 +361,12 @@ resource "azurerm_resource_group" "test" { } resource "azurerm_analysis_services_server" "test" { - name = "acctestass%d" - location = "${azurerm_resource_group.test.location}" - resource_group_name = "${azurerm_resource_group.test.name}" - sku = "B1" - enable_power_bi_service = %t - + name = "acctestass%d" + location = "${azurerm_resource_group.test.location}" + resource_group_name = "${azurerm_resource_group.test.name}" + sku = "B1" + enable_power_bi_service = %t + ipv4_firewall_rule { name = "test1" range_start = "92.123.234.11" @@ -385,16 +385,16 @@ resource "azurerm_analysis_services_server" "test" { func testAccAzureRMAnalysisServicesServer_adminUsers(rInt int, location string, adminUsers []string) string { return fmt.Sprintf(` resource "azurerm_resource_group" "test" { - name = "acctestRG-%d" - location = "%s" + name = "acctestRG-%d" + location = "%s" } resource "azurerm_analysis_services_server" "test" { - name = "acctestass%d" - location = "${azurerm_resource_group.test.location}" - resource_group_name = "${azurerm_resource_group.test.name}" - sku = "B1" - admin_users = ["%s"] + name = "acctestass%d" + location = "${azurerm_resource_group.test.location}" + resource_group_name = "${azurerm_resource_group.test.name}" + sku = "B1" + admin_users = ["%s"] } `, rInt, location, rInt, strings.Join(adminUsers, "\", \"")) } @@ -410,7 +410,7 @@ resource "azurerm_analysis_services_server" "test" { name = "acctestass%d" location = "${azurerm_resource_group.test.location}" resource_group_name = "${azurerm_resource_group.test.name}" - sku = "B1" + sku = "B1" } `, rInt, location, rInt) } @@ -426,7 +426,7 @@ resource "azurerm_storage_account" "test" { name = "acctestass%s" resource_group_name = "${azurerm_resource_group.test.name}" location = "${azurerm_resource_group.test.location}" - account_kind = "BlobStorage" + account_kind = "BlobStorage" account_tier = "Standard" account_replication_type = "LRS" } @@ -459,7 +459,7 @@ resource "azurerm_analysis_services_server" "test" { name = "acctestass%d" location = "${azurerm_resource_group.test.location}" resource_group_name = "${azurerm_resource_group.test.name}" - sku = "B1" + sku = "B1" backup_blob_container_uri = "${azurerm_storage_account.test.primary_blob_endpoint}${azurerm_storage_container.test.name}${data.azurerm_storage_account_blob_container_sas.test.sas}" } diff --git a/azurerm/resource_arm_api_management_test.go b/azurerm/resource_arm_api_management_test.go index 748e4e0b6f62..ae2dd9148b39 100644 --- a/azurerm/resource_arm_api_management_test.go +++ b/azurerm/resource_arm_api_management_test.go @@ -337,9 +337,9 @@ resource "azurerm_api_management" "test" { publisher_email = "pub1@email.com" sku { - name = "Developer" + name = "Developer" capacity = 1 - } + } } `, rInt, location, rInt) } @@ -522,8 +522,8 @@ resource "azurerm_resource_group" "test2" { } resource "azurerm_resource_group" "test3" { - name = "acctestRG3-%d" - location = "%s" + name = "acctestRG3-%d" + location = "%s" } resource "azurerm_api_management" "test" { diff --git a/azurerm/resource_arm_app_service_certificate_order_test.go b/azurerm/resource_arm_app_service_certificate_order_test.go index b23ae93535aa..478976a11156 100644 --- a/azurerm/resource_arm_app_service_certificate_order_test.go +++ b/azurerm/resource_arm_app_service_certificate_order_test.go @@ -267,11 +267,11 @@ resource "azurerm_resource_group" "test" { } resource "azurerm_app_service_certificate_order" "test" { - name = "acctestASCO-%d" - location = "global" + name = "acctestASCO-%d" + location = "global" resource_group_name = "${azurerm_resource_group.test.name}" - distinguished_name = "CN=example.com" - product_type = "Standard" + distinguished_name = "CN=example.com" + product_type = "Standard" } `, rInt, location, rInt) } @@ -284,11 +284,11 @@ resource "azurerm_resource_group" "test" { } resource "azurerm_app_service_certificate_order" "test" { - name = "acctestASCO-%d" - location = "global" + name = "acctestASCO-%d" + location = "global" resource_group_name = "${azurerm_resource_group.test.name}" - distinguished_name = "CN=*.example.com" - product_type = "WildCard" + distinguished_name = "CN=*.example.com" + product_type = "WildCard" } `, rInt, location, rInt) } @@ -302,8 +302,8 @@ resource "azurerm_app_service_certificate_order" "import" { name = "${azurerm_app_service_certificate_order.test.name}" location = "${azurerm_app_service_certificate_order.test.location}" resource_group_name = "${azurerm_app_service_certificate_order.test.resource_group_name}" - distinguished_name = "${azurerm_app_service_certificate_order.test.distinguished_name}" - product_type = "${azurerm_app_service_certificate_order.test.product_type}" + distinguished_name = "${azurerm_app_service_certificate_order.test.distinguished_name}" + product_type = "${azurerm_app_service_certificate_order.test.product_type}" } `, template) } @@ -316,14 +316,14 @@ resource "azurerm_resource_group" "test" { } resource "azurerm_app_service_certificate_order" "test" { - name = "acctestASCO-%d" - location = "global" + name = "acctestASCO-%d" + location = "global" resource_group_name = "${azurerm_resource_group.test.name}" - distinguished_name = "CN=example.com" - product_type = "Standard" - auto_renew = false - validity_in_years = 1 - key_size = %d + distinguished_name = "CN=example.com" + product_type = "Standard" + auto_renew = false + validity_in_years = 1 + key_size = %d } `, rInt, location, rInt, keySize) } diff --git a/azurerm/resource_arm_app_service_certificate_test.go b/azurerm/resource_arm_app_service_certificate_test.go index 314e58161996..c0d6b6c29dee 100644 --- a/azurerm/resource_arm_app_service_certificate_test.go +++ b/azurerm/resource_arm_app_service_certificate_test.go @@ -152,7 +152,7 @@ resource "azurerm_key_vault" "test" { access_policy { tenant_id = data.azurerm_client_config.test.tenant_id - object_id = data.azurerm_client_config.test.service_principal_object_id + object_id = data.azurerm_client_config.test.service_principal_object_id secret_permissions = ["delete", "get", "set"] certificate_permissions = ["create", "delete", "get", "import"] } diff --git a/azurerm/resource_arm_app_service_slot_test.go b/azurerm/resource_arm_app_service_slot_test.go index d5923f9cd171..b901280f216f 100644 --- a/azurerm/resource_arm_app_service_slot_test.go +++ b/azurerm/resource_arm_app_service_slot_test.go @@ -2005,8 +2005,8 @@ resource "azurerm_app_service" "test" { location = "${azurerm_resource_group.test.location}" resource_group_name = "${azurerm_resource_group.test.name}" app_service_plan_id = "${azurerm_app_service_plan.test.id}" - - site_config { + + site_config { always_on = true } } @@ -2080,7 +2080,7 @@ resource "azurerm_app_service_slot" "test" { auth_settings { enabled = true issuer = "https://sts.windows.net/%s" - + allowed_external_redirect_urls = [ "https://terra.form" ] @@ -2137,8 +2137,8 @@ resource "azurerm_app_service_slot" "test" { } auth_settings { - enabled = true - issuer = "https://sts.windows.net/%s" + enabled = true + issuer = "https://sts.windows.net/%s" runtime_version = "1.0" active_directory { @@ -2193,8 +2193,8 @@ resource "azurerm_app_service_slot" "test" { } auth_settings { - enabled = true - issuer = "https://sts.windows.net/%s" + enabled = true + issuer = "https://sts.windows.net/%s" token_refresh_extension_hours = 75 active_directory { @@ -2243,14 +2243,14 @@ resource "azurerm_app_service_slot" "test" { resource_group_name = "${azurerm_resource_group.test.name}" app_service_plan_id = "${azurerm_app_service_plan.test.id}" app_service_name = "${azurerm_app_service.test.name}" - + site_config { always_on = true } auth_settings { - enabled = true - issuer = "https://sts.windows.net/%s" + enabled = true + issuer = "https://sts.windows.net/%s" token_store_enabled = true active_directory { @@ -2305,8 +2305,8 @@ resource "azurerm_app_service_slot" "test" { } auth_settings { - enabled = true - issuer = "https://sts.windows.net/%s" + enabled = true + issuer = "https://sts.windows.net/%s" unauthenticated_client_action = "RedirectToLoginPage" active_directory { @@ -2576,8 +2576,8 @@ resource "azurerm_app_service_slot" "test" { auth_settings { enabled = true twitter { - consumer_key = "twitterconsumerkey" - consumer_secret = "twitterconsumersecret" + consumer_key = "twitterconsumerkey" + consumer_secret = "twitterconsumersecret" } } } @@ -2635,7 +2635,7 @@ resource "azurerm_app_service_slot" "test" { "activedirectorytokenaudiences", ] } - + microsoft { client_id = "microsoftclientid" client_secret = "microsoftclientsecret" diff --git a/azurerm/resource_arm_app_service_test.go b/azurerm/resource_arm_app_service_test.go index 16874bd2e642..b1e9f671ae4e 100644 --- a/azurerm/resource_arm_app_service_test.go +++ b/azurerm/resource_arm_app_service_test.go @@ -2542,7 +2542,7 @@ data "azurerm_storage_account_sas" "test" { start = "2019-03-21" expiry = "2022-03-21" - permissions { + permissions { read = false write = true delete = false @@ -2964,9 +2964,9 @@ resource "azurerm_storage_account" "test" { } resource "azurerm_storage_container" "test" { - name = "acctestcontainer" - resource_group_name = "${azurerm_resource_group.test.name}" - storage_account_name = "${azurerm_storage_account.test.name}" + name = "acctestcontainer" + resource_group_name = "${azurerm_resource_group.test.name}" + storage_account_name = "${azurerm_storage_account.test.name}" } resource "azurerm_app_service_plan" "test" { @@ -3025,9 +3025,9 @@ resource "azurerm_storage_account" "test" { } resource "azurerm_storage_container" "test" { - name = "acctestcontainer" - resource_group_name = "${azurerm_resource_group.test.name}" - storage_account_name = "${azurerm_storage_account.test.name}" + name = "acctestcontainer" + resource_group_name = "${azurerm_resource_group.test.name}" + storage_account_name = "${azurerm_storage_account.test.name}" } resource "azurerm_storage_share" "test" { @@ -3376,7 +3376,7 @@ resource "azurerm_app_service" "test" { resource_group_name = "${azurerm_resource_group.test.name}" app_service_plan_id = "${azurerm_app_service_plan.test.id}" app_settings = { - foo = "bar" + foo = "bar" } logs { application_logs { diff --git a/azurerm/resource_arm_application_gateway_test.go b/azurerm/resource_arm_application_gateway_test.go index 737fe17e0390..377e4dec1bba 100644 --- a/azurerm/resource_arm_application_gateway_test.go +++ b/azurerm/resource_arm_application_gateway_test.go @@ -1376,13 +1376,13 @@ resource "azurerm_application_gateway" "test" { location = "${azurerm_resource_group.test.location}" sku { - name = "Standard_v2" - tier = "Standard_v2" + name = "Standard_v2" + tier = "Standard_v2" } autoscale_configuration { min_capacity = %d - max_capacity = %d + max_capacity = %d } gateway_ip_configuration { @@ -1832,7 +1832,7 @@ resource "azurerm_public_ip" "testStd" { location = "${azurerm_resource_group.test.location}" resource_group_name = "${azurerm_resource_group.test.name}" allocation_method = "Static" - sku = "Standard" + sku = "Standard" } resource "azurerm_key_vault" "test" { @@ -1844,7 +1844,7 @@ resource "azurerm_key_vault" "test" { access_policy { tenant_id = "${data.azurerm_client_config.test.tenant_id}" - object_id = "${data.azurerm_client_config.test.service_principal_object_id }" + object_id = "${data.azurerm_client_config.test.service_principal_object_id}" secret_permissions = ["delete", "get", "set"] certificate_permissions = ["create", "delete", "get", "import"] } @@ -1970,7 +1970,7 @@ resource "azurerm_public_ip" "teststd" { location = "${azurerm_resource_group.test.location}" resource_group_name = "${azurerm_resource_group.test.name}" allocation_method = "Static" - sku = "Standard" + sku = "Standard" } resource "azurerm_application_gateway" "test" { @@ -2136,7 +2136,7 @@ resource "azurerm_public_ip" "teststd" { location = "${azurerm_resource_group.test.location}" resource_group_name = "${azurerm_resource_group.test.name}" allocation_method = "Static" - sku = "Standard" + sku = "Standard" } @@ -2842,12 +2842,12 @@ resource "azurerm_application_gateway" "test" { } backend_http_settings { - name = "${local.http_setting_name}" - cookie_based_affinity = "Disabled" - host_name = "%s" - port = 80 - protocol = "Http" - request_timeout = 1 + name = "${local.http_setting_name}" + cookie_based_affinity = "Disabled" + host_name = "%s" + port = 80 + protocol = "Http" + request_timeout = 1 pick_host_name_from_backend_address = %t } diff --git a/azurerm/resource_arm_automation_account_test.go b/azurerm/resource_arm_automation_account_test.go index 27401c590c64..4c0727a89cdc 100644 --- a/azurerm/resource_arm_automation_account_test.go +++ b/azurerm/resource_arm_automation_account_test.go @@ -232,7 +232,7 @@ resource "azurerm_automation_account" "test" { sku { name = "Basic" - } + } } `, rInt, location, rInt) } @@ -281,7 +281,7 @@ resource "azurerm_automation_account" "test" { resource_group_name = "${azurerm_resource_group.test.name}" sku_name = "Basic" - + tags = { "hello" = "world" } diff --git a/azurerm/resource_arm_availability_set_test.go b/azurerm/resource_arm_availability_set_test.go index 7ab894bbf22e..da4f36c8725d 100644 --- a/azurerm/resource_arm_availability_set_test.go +++ b/azurerm/resource_arm_availability_set_test.go @@ -382,7 +382,7 @@ resource "azurerm_availability_set" "test" { location = "${azurerm_resource_group.test.location}" resource_group_name = "${azurerm_resource_group.test.name}" - proximity_placement_group_id = "${azurerm_proximity_placement_group.test.id}" + proximity_placement_group_id = "${azurerm_proximity_placement_group.test.id}" } `, rInt, location, rInt, rInt) } diff --git a/azurerm/resource_arm_bastion_host_test.go b/azurerm/resource_arm_bastion_host_test.go index 59c3dc28135d..22a989dd8e8d 100644 --- a/azurerm/resource_arm_bastion_host_test.go +++ b/azurerm/resource_arm_bastion_host_test.go @@ -187,9 +187,9 @@ func testAccAzureRMBastionHost_requiresImport(rInt int, rString string, location return fmt.Sprintf(` %s resource "azurerm_bastion_host" "import" { - name = "${azurerm_bastion_host.test.name}" - resource_group_name = "${azurerm_bastion_host.test.resource_group_name}" - location = "${azurerm_bastion_host.test.location}" + name = "${azurerm_bastion_host.test.name}" + resource_group_name = "${azurerm_bastion_host.test.resource_group_name}" + location = "${azurerm_bastion_host.test.location}" ip_configuration { name = "configuration" diff --git a/azurerm/resource_arm_batch_account_test.go b/azurerm/resource_arm_batch_account_test.go index f9aef4e14735..91dd5a41e4bc 100644 --- a/azurerm/resource_arm_batch_account_test.go +++ b/azurerm/resource_arm_batch_account_test.go @@ -302,7 +302,7 @@ resource "azurerm_batch_account" "test" { func testAccAzureRMBatchAccount_userSubscription(rInt int, batchAccountSuffix string, location string, tenantID string) string { return fmt.Sprintf(` data "azuread_service_principal" "test" { - display_name = "Microsoft Azure Batch" + display_name = "Microsoft Azure Batch" } resource "azurerm_resource_group" "test" { @@ -326,24 +326,24 @@ resource "azurerm_key_vault" "test" { access_policy { tenant_id = "%s" object_id = "${data.azuread_service_principal.test.object_id}" - + secret_permissions = [ - "get", - "list", - "set", - "delete" + "get", + "list", + "set", + "delete" ] - + } } resource "azurerm_batch_account" "test" { - name = "testaccbatch%s" - resource_group_name = "${azurerm_resource_group.test.name}" - location = "${azurerm_resource_group.test.location}" - + name = "testaccbatch%s" + resource_group_name = "${azurerm_resource_group.test.name}" + location = "${azurerm_resource_group.test.location}" + pool_allocation_mode = "UserSubscription" - + key_vault_reference { id = "${azurerm_key_vault.test.id}" url = "${azurerm_key_vault.test.vault_uri}" diff --git a/azurerm/resource_arm_batch_application_test.go b/azurerm/resource_arm_batch_application_test.go index 98a8717c2b49..8b44da19ef52 100644 --- a/azurerm/resource_arm_batch_application_test.go +++ b/azurerm/resource_arm_batch_application_test.go @@ -143,8 +143,8 @@ resource "azurerm_batch_account" "test" { resource "azurerm_batch_application" "test" { name = "acctestbatchapp-%d" resource_group_name = "${azurerm_resource_group.test.name}" - account_name = "${azurerm_batch_account.test.name}" - %s + account_name = "${azurerm_batch_account.test.name}" + %s } `, rInt, location, rString, rString, rInt, displayName) } diff --git a/azurerm/resource_arm_batch_pool_test.go b/azurerm/resource_arm_batch_pool_test.go index 887f4e1ac160..e8f80ba978ce 100644 --- a/azurerm/resource_arm_batch_pool_test.go +++ b/azurerm/resource_arm_batch_pool_test.go @@ -930,7 +930,7 @@ resource "azurerm_batch_certificate" "testcer" { account_name = "${azurerm_batch_account.test.name}" certificate = "${filebase64("testdata/batch_certificate.cer")}" format = "Cer" - thumbprint = "312d31a79fa0cef49c00f769afc2b73e9f4edf34" # deliberately using lowercase here as verification + thumbprint = "312d31a79fa0cef49c00f769afc2b73e9f4edf34" # deliberately using lowercase here as verification thumbprint_algorithm = "SHA1" } @@ -1017,7 +1017,7 @@ resource "azurerm_batch_pool" "test" { container_configuration { type = "DockerCompatible" - container_registries= [ + container_registries = [ { registry_server = "myContainerRegistry.azurecr.io" user_name = "myUserName" @@ -1166,11 +1166,11 @@ resource "azurerm_batch_pool" "test" { vm_size = "Standard_A1" max_tasks_per_node = 2 node_agent_sku_id = "batch.node.ubuntu 16.04" - + fixed_scale { target_dedicated_nodes = 2 } - + storage_image_reference { id = "${azurerm_image.test.id}" } diff --git a/azurerm/resource_arm_bot_connection_test.go b/azurerm/resource_arm_bot_connection_test.go index 683cdf64c479..99e172a4a052 100644 --- a/azurerm/resource_arm_bot_connection_test.go +++ b/azurerm/resource_arm_bot_connection_test.go @@ -174,7 +174,7 @@ resource "azurerm_bot_connection" "test" { client_id = "test" client_secret = "secret" scopes = "testscope" - + parameters = { loginUri = "www.example.com" } @@ -196,7 +196,7 @@ resource "azurerm_bot_connection" "test" { client_id = "test2" client_secret = "secret2" scopes = "testscope2" - + parameters = { loginUri = "www.example2.com" } diff --git a/azurerm/resource_arm_container_group_test.go b/azurerm/resource_arm_container_group_test.go index b163f1a74cf6..d271f2ab3a82 100644 --- a/azurerm/resource_arm_container_group_test.go +++ b/azurerm/resource_arm_container_group_test.go @@ -917,7 +917,7 @@ resource "azurerm_container_group" "test" { location = "${azurerm_resource_group.test.location}" resource_group_name = "${azurerm_resource_group.test.name}" ip_address_type = "Private" - network_profile_id = "${azurerm_network_profile.test.id}" + network_profile_id = "${azurerm_network_profile.test.id}" os_type = "Linux" container { diff --git a/azurerm/resource_arm_container_registry_test.go b/azurerm/resource_arm_container_registry_test.go index ed60442cbc76..e6b23dfd42c5 100644 --- a/azurerm/resource_arm_container_registry_test.go +++ b/azurerm/resource_arm_container_registry_test.go @@ -672,7 +672,7 @@ resource "azurerm_container_registry" "test" { network_rule_set { default_action = "Allow" - ip_rule { + ip_rule { action = "Allow" ip_range = "8.8.8.8/32" } @@ -714,7 +714,7 @@ resource "azurerm_container_registry" "test" { network_rule_set { default_action = "Deny" - virtual_network { + virtual_network { action = "Allow" subnet_id = "${azurerm_subnet.test.id}" } diff --git a/azurerm/resource_arm_container_registry_webhook_test.go b/azurerm/resource_arm_container_registry_webhook_test.go index 2c902a487ce0..0cb22467abb6 100644 --- a/azurerm/resource_arm_container_registry_webhook_test.go +++ b/azurerm/resource_arm_container_registry_webhook_test.go @@ -224,10 +224,10 @@ resource "azurerm_resource_group" "rg" { } resource "azurerm_container_registry" "acr" { - name = "acrwebhooktest%d" - resource_group_name = azurerm_resource_group.rg.name - location = "%s" - sku = "Standard" + name = "acrwebhooktest%d" + resource_group_name = azurerm_resource_group.rg.name + location = "%s" + sku = "Standard" } resource "azurerm_container_registry_webhook" "test" { @@ -235,11 +235,11 @@ resource "azurerm_container_registry_webhook" "test" { resource_group_name = azurerm_resource_group.rg.name registry_name = azurerm_container_registry.acr.name location = "%s" - - service_uri = "https://mywebhookreceiver.example/mytag" + + service_uri = "https://mywebhookreceiver.example/mytag" actions = [ - "push" + "push" ] } `, rInt, location, rInt, location, rInt, location) @@ -253,10 +253,10 @@ resource "azurerm_resource_group" "rg" { } resource "azurerm_container_registry" "acr" { - name = "acrwebhooktest%d" - resource_group_name = azurerm_resource_group.rg.name - location = "%s" - sku = "Standard" + name = "acrwebhooktest%d" + resource_group_name = azurerm_resource_group.rg.name + location = "%s" + sku = "Standard" } resource "azurerm_container_registry_webhook" "test" { @@ -264,15 +264,15 @@ resource "azurerm_container_registry_webhook" "test" { resource_group_name = azurerm_resource_group.rg.name registry_name = azurerm_container_registry.acr.name location = "%s" - - service_uri = "https://mywebhookreceiver.example/mytag" + + service_uri = "https://mywebhookreceiver.example/mytag" actions = [ - "push" + "push" ] tags = { - label = "test" + label = "test" } } `, rInt, location, rInt, location, rInt, location) @@ -286,10 +286,10 @@ resource "azurerm_resource_group" "rg" { } resource "azurerm_container_registry" "acr" { - name = "acrwebhooktest%d" - resource_group_name = azurerm_resource_group.rg.name - location = "%s" - sku = "Standard" + name = "acrwebhooktest%d" + resource_group_name = azurerm_resource_group.rg.name + location = "%s" + sku = "Standard" } resource "azurerm_container_registry_webhook" "test" { @@ -297,16 +297,16 @@ resource "azurerm_container_registry_webhook" "test" { resource_group_name = azurerm_resource_group.rg.name registry_name = azurerm_container_registry.acr.name location = "%s" - - service_uri = "https://mywebhookreceiver.example/mytag" + + service_uri = "https://mywebhookreceiver.example/mytag" actions = [ - "push" + "push" ] tags = { - label = "test1" - ENV = "prod" + label = "test1" + ENV = "prod" } } `, rInt, location, rInt, location, rInt, location) @@ -320,10 +320,10 @@ resource "azurerm_resource_group" "rg" { } resource "azurerm_container_registry" "acr" { - name = "acrwebhooktest%d" - resource_group_name = azurerm_resource_group.rg.name - location = "%s" - sku = "Standard" + name = "acrwebhooktest%d" + resource_group_name = azurerm_resource_group.rg.name + location = "%s" + sku = "Standard" } resource "azurerm_container_registry_webhook" "test" { @@ -331,11 +331,11 @@ resource "azurerm_container_registry_webhook" "test" { resource_group_name = azurerm_resource_group.rg.name registry_name = azurerm_container_registry.acr.name location = "%s" - - service_uri = "https://mywebhookreceiver.example/mytag" + + service_uri = "https://mywebhookreceiver.example/mytag" actions = [ - "push" + "push" ] } `, rInt, location, rInt, location, rInt, location) @@ -349,10 +349,10 @@ resource "azurerm_resource_group" "rg" { } resource "azurerm_container_registry" "acr" { - name = "acrwebhooktest%d" - resource_group_name = azurerm_resource_group.rg.name - location = "%s" - sku = "Standard" + name = "acrwebhooktest%d" + resource_group_name = azurerm_resource_group.rg.name + location = "%s" + sku = "Standard" } resource "azurerm_container_registry_webhook" "test" { @@ -360,12 +360,12 @@ resource "azurerm_container_registry_webhook" "test" { resource_group_name = azurerm_resource_group.rg.name registry_name = azurerm_container_registry.acr.name location = "%s" - - service_uri = "https://mywebhookreceiver.example/mytag" + + service_uri = "https://mywebhookreceiver.example/mytag" actions = [ - "push", - "delete" + "push", + "delete" ] } `, rInt, location, rInt, location, rInt, location) @@ -379,10 +379,10 @@ resource "azurerm_resource_group" "rg" { } resource "azurerm_container_registry" "acr" { - name = "acrwebhooktest%d" - resource_group_name = azurerm_resource_group.rg.name - location = "%s" - sku = "Standard" + name = "acrwebhooktest%d" + resource_group_name = azurerm_resource_group.rg.name + location = "%s" + sku = "Standard" } resource "azurerm_container_registry_webhook" "test" { @@ -390,13 +390,13 @@ resource "azurerm_container_registry_webhook" "test" { resource_group_name = azurerm_resource_group.rg.name registry_name = azurerm_container_registry.acr.name location = "%s" - - service_uri = "https://mywebhookreceiver.example/mytag" + + service_uri = "https://mywebhookreceiver.example/mytag" status = "enabled" actions = [ - "push" + "push" ] } `, rInt, location, rInt, location, rInt, location) @@ -410,10 +410,10 @@ resource "azurerm_resource_group" "rg" { } resource "azurerm_container_registry" "acr" { - name = "acrwebhooktest%d" - resource_group_name = azurerm_resource_group.rg.name - location = "%s" - sku = "Standard" + name = "acrwebhooktest%d" + resource_group_name = azurerm_resource_group.rg.name + location = "%s" + sku = "Standard" } resource "azurerm_container_registry_webhook" "test" { @@ -421,13 +421,13 @@ resource "azurerm_container_registry_webhook" "test" { resource_group_name = azurerm_resource_group.rg.name registry_name = azurerm_container_registry.acr.name location = "%s" - - service_uri = "https://mywebhookreceiver.example/mytag" + + service_uri = "https://mywebhookreceiver.example/mytag" status = "disabled" actions = [ - "push" + "push" ] } `, rInt, location, rInt, location, rInt, location) @@ -441,10 +441,10 @@ resource "azurerm_resource_group" "rg" { } resource "azurerm_container_registry" "acr" { - name = "acrwebhooktest%d" - resource_group_name = azurerm_resource_group.rg.name - location = "%s" - sku = "Standard" + name = "acrwebhooktest%d" + resource_group_name = azurerm_resource_group.rg.name + location = "%s" + sku = "Standard" } resource "azurerm_container_registry_webhook" "test" { @@ -452,11 +452,11 @@ resource "azurerm_container_registry_webhook" "test" { resource_group_name = azurerm_resource_group.rg.name registry_name = azurerm_container_registry.acr.name location = "%s" - - service_uri = "https://mywebhookreceiver.example/mytag" + + service_uri = "https://mywebhookreceiver.example/mytag" actions = [ - "push" + "push" ] } `, rInt, location, rInt, location, rInt, location) @@ -470,10 +470,10 @@ resource "azurerm_resource_group" "rg" { } resource "azurerm_container_registry" "acr" { - name = "acrwebhooktest%d" - resource_group_name = azurerm_resource_group.rg.name - location = "%s" - sku = "Standard" + name = "acrwebhooktest%d" + resource_group_name = azurerm_resource_group.rg.name + location = "%s" + sku = "Standard" } resource "azurerm_container_registry_webhook" "test" { @@ -481,13 +481,13 @@ resource "azurerm_container_registry_webhook" "test" { resource_group_name = azurerm_resource_group.rg.name registry_name = azurerm_container_registry.acr.name location = "%s" - - service_uri = "https://my.webhookreceiver.example/mytag/2" + + service_uri = "https://my.webhookreceiver.example/mytag/2" status = "disabled" actions = [ - "push" + "push" ] } `, rInt, location, rInt, location, rInt, location) @@ -501,10 +501,10 @@ resource "azurerm_resource_group" "rg" { } resource "azurerm_container_registry" "acr" { - name = "acrwebhooktest%d" - resource_group_name = azurerm_resource_group.rg.name - location = "%s" - sku = "Standard" + name = "acrwebhooktest%d" + resource_group_name = azurerm_resource_group.rg.name + location = "%s" + sku = "Standard" } resource "azurerm_container_registry_webhook" "test" { @@ -512,13 +512,13 @@ resource "azurerm_container_registry_webhook" "test" { resource_group_name = azurerm_resource_group.rg.name registry_name = azurerm_container_registry.acr.name location = "%s" - - service_uri = "https://mywebhookreceiver.example/mytag" + + service_uri = "https://mywebhookreceiver.example/mytag" scope = "mytag:*" actions = [ - "push" + "push" ] } `, rInt, location, rInt, location, rInt, location) @@ -532,10 +532,10 @@ resource "azurerm_resource_group" "rg" { } resource "azurerm_container_registry" "acr" { - name = "acrwebhooktest%d" - resource_group_name = azurerm_resource_group.rg.name - location = "%s" - sku = "Standard" + name = "acrwebhooktest%d" + resource_group_name = azurerm_resource_group.rg.name + location = "%s" + sku = "Standard" } resource "azurerm_container_registry_webhook" "test" { @@ -543,13 +543,13 @@ resource "azurerm_container_registry_webhook" "test" { resource_group_name = azurerm_resource_group.rg.name registry_name = azurerm_container_registry.acr.name location = "%s" - - service_uri = "https://mywebhookreceiver.example/mytag" + + service_uri = "https://mywebhookreceiver.example/mytag" scope = "mytag:4" actions = [ - "push" + "push" ] } `, rInt, location, rInt, location, rInt, location) @@ -563,10 +563,10 @@ resource "azurerm_resource_group" "rg" { } resource "azurerm_container_registry" "acr" { - name = "acrwebhooktest%d" - resource_group_name = azurerm_resource_group.rg.name - location = "%s" - sku = "Standard" + name = "acrwebhooktest%d" + resource_group_name = azurerm_resource_group.rg.name + location = "%s" + sku = "Standard" } resource "azurerm_container_registry_webhook" "test" { @@ -574,15 +574,15 @@ resource "azurerm_container_registry_webhook" "test" { resource_group_name = azurerm_resource_group.rg.name registry_name = azurerm_container_registry.acr.name location = "%s" - - service_uri = "https://mywebhookreceiver.example/mytag" + + service_uri = "https://mywebhookreceiver.example/mytag" custom_headers = { "Content-Type" = "application/json" } actions = [ - "push" + "push" ] } `, rInt, location, rInt, location, rInt, location) @@ -596,10 +596,10 @@ resource "azurerm_resource_group" "rg" { } resource "azurerm_container_registry" "acr" { - name = "acrwebhooktest%d" - resource_group_name = azurerm_resource_group.rg.name - location = "%s" - sku = "Standard" + name = "acrwebhooktest%d" + resource_group_name = azurerm_resource_group.rg.name + location = "%s" + sku = "Standard" } resource "azurerm_container_registry_webhook" "test" { @@ -607,16 +607,16 @@ resource "azurerm_container_registry_webhook" "test" { resource_group_name = azurerm_resource_group.rg.name registry_name = azurerm_container_registry.acr.name location = "%s" - - service_uri = "https://mywebhookreceiver.example/mytag" + + service_uri = "https://mywebhookreceiver.example/mytag" custom_headers = { - "Content-Type" = "application/xml" - "Accept-Charset" = "utf-8" + "Content-Type" = "application/xml" + "Accept-Charset" = "utf-8" } actions = [ - "push" + "push" ] } `, rInt, location, rInt, location, rInt, location) diff --git a/azurerm/resource_arm_cosmosdb_sql_container_test.go b/azurerm/resource_arm_cosmosdb_sql_container_test.go index 2e7fef29307a..4dfb278f64c7 100644 --- a/azurerm/resource_arm_cosmosdb_sql_container_test.go +++ b/azurerm/resource_arm_cosmosdb_sql_container_test.go @@ -177,7 +177,7 @@ resource "azurerm_cosmosdb_sql_container" "test" { database_name = "${azurerm_cosmosdb_sql_database.test.name}" partition_key_path = "/definition/id" unique_key { - paths = ["/definition/id1", "/definition/id2"] + paths = ["/definition/id1", "/definition/id2"] } } diff --git a/azurerm/resource_arm_dashboard_test.go b/azurerm/resource_arm_dashboard_test.go index 3496aec22b85..7a3add38e730 100644 --- a/azurerm/resource_arm_dashboard_test.go +++ b/azurerm/resource_arm_dashboard_test.go @@ -93,16 +93,16 @@ func testCheckAzureRMDashboardDestroy(s *terraform.State) error { func testResourceArmDashboard_basic(rInt int, location string) string { return fmt.Sprintf(` - resource "azurerm_resource_group" "test-group"{ - name = "acctestRG-%d" - location = "%s" - } - - resource "azurerm_dashboard" "test" { - name = "my-test-dashboard" - resource_group_name = azurerm_resource_group.test-group.name - location = azurerm_resource_group.test-group.location - dashboard_properties = < Date: Fri, 25 Oct 2019 09:34:39 -0700 Subject: [PATCH 2/5] pass 2 --- ...nux_virtual_machine_scale_set_auth_test.go | 16 +- ...irtual_machine_scale_set_disk_data_test.go | 112 +++--- ..._virtual_machine_scale_set_disk_os_test.go | 80 ++-- ...virtual_machine_scale_set_identity_test.go | 64 ++-- ...x_virtual_machine_scale_set_images_test.go | 88 ++--- ..._virtual_machine_scale_set_network_test.go | 352 +++++++++--------- ...ux_virtual_machine_scale_set_other_test.go | 220 +++++------ ..._virtual_machine_scale_set_scaling_test.go | 180 ++++----- 8 files changed, 556 insertions(+), 556 deletions(-) diff --git a/azurerm/resource_arm_linux_virtual_machine_scale_set_auth_test.go b/azurerm/resource_arm_linux_virtual_machine_scale_set_auth_test.go index 04e7696d2fd8..b7216f40797c 100644 --- a/azurerm/resource_arm_linux_virtual_machine_scale_set_auth_test.go +++ b/azurerm/resource_arm_linux_virtual_machine_scale_set_auth_test.go @@ -234,14 +234,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_authPassword(rInt int, location s %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { diff --git a/azurerm/resource_arm_linux_virtual_machine_scale_set_disk_data_test.go b/azurerm/resource_arm_linux_virtual_machine_scale_set_disk_data_test.go index 6022fc809b71..397d73053f8c 100644 --- a/azurerm/resource_arm_linux_virtual_machine_scale_set_disk_data_test.go +++ b/azurerm/resource_arm_linux_virtual_machine_scale_set_disk_data_test.go @@ -462,14 +462,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_disksDataDiskBasic(rInt int, loca %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -511,14 +511,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_disksDataDiskCaching(rInt int, lo %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -560,14 +560,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_disksDataDiskResize(rInt int, loc %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -609,14 +609,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_disksDataDiskMultiple(rInt int, l %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -665,14 +665,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_disksDataDiskStorageAccountType(r %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2s_v2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2s_v2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -714,14 +714,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_disksDataDiskStorageAccountTypeUl %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_D2s_v3" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_D2s_v3" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -767,14 +767,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_disksDataDiskWriteAcceleratorEnab %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_M8ms" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_M8ms" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { diff --git a/azurerm/resource_arm_linux_virtual_machine_scale_set_disk_os_test.go b/azurerm/resource_arm_linux_virtual_machine_scale_set_disk_os_test.go index 841041331a34..456682dd28dc 100644 --- a/azurerm/resource_arm_linux_virtual_machine_scale_set_disk_os_test.go +++ b/azurerm/resource_arm_linux_virtual_machine_scale_set_disk_os_test.go @@ -288,14 +288,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_disksOSDiskCaching(rInt int, loca %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -330,14 +330,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_disksOSDiskCustomSize(rInt int, l %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -373,14 +373,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_disksOSDiskEphemeral(rInt int, lo %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2s_v2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2s_v2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -419,14 +419,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_disksOSDiskStorageAccountType(rIn %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2s_v2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2s_v2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -461,14 +461,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_disksOSDiskWriteAcceleratorEnable %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_M8ms" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_M8ms" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { diff --git a/azurerm/resource_arm_linux_virtual_machine_scale_set_identity_test.go b/azurerm/resource_arm_linux_virtual_machine_scale_set_identity_test.go index 35fdc0423ad2..24480a3d1c9f 100644 --- a/azurerm/resource_arm_linux_virtual_machine_scale_set_identity_test.go +++ b/azurerm/resource_arm_linux_virtual_machine_scale_set_identity_test.go @@ -258,14 +258,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_identitySystemAssigned(rInt int, %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -310,14 +310,14 @@ resource "azurerm_user_assigned_identity" "test" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -371,14 +371,14 @@ resource "azurerm_user_assigned_identity" "other" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -427,14 +427,14 @@ resource "azurerm_user_assigned_identity" "test" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { diff --git a/azurerm/resource_arm_linux_virtual_machine_scale_set_images_test.go b/azurerm/resource_arm_linux_virtual_machine_scale_set_images_test.go index c81adf8f22fa..2cec0f95ac55 100644 --- a/azurerm/resource_arm_linux_virtual_machine_scale_set_images_test.go +++ b/azurerm/resource_arm_linux_virtual_machine_scale_set_images_test.go @@ -346,16 +346,16 @@ resource "azurerm_lb_rule" "test" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - health_probe_id = azurerm_lb_probe.test.id - upgrade_mode = "Automatic" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + health_probe_id = azurerm_lb_probe.test.id + upgrade_mode = "Automatic" + disable_password_authentication = false source_image_reference { @@ -560,14 +560,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_imagesManualUpdate(rInt int, loca %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -602,14 +602,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_imagesManualUpdateExternalRoll(rI %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false terraform_should_roll_instances_when_required = false @@ -701,16 +701,16 @@ resource "azurerm_lb_rule" "test" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - health_probe_id = azurerm_lb_probe.test.id - upgrade_mode = "Rolling" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + health_probe_id = azurerm_lb_probe.test.id + upgrade_mode = "Rolling" + disable_password_authentication = false source_image_reference { @@ -762,14 +762,14 @@ resource "azurerm_marketplace_agreement" "test" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { diff --git a/azurerm/resource_arm_linux_virtual_machine_scale_set_network_test.go b/azurerm/resource_arm_linux_virtual_machine_scale_set_network_test.go index 54271fd3f4a1..ee3ed1f819ae 100644 --- a/azurerm/resource_arm_linux_virtual_machine_scale_set_network_test.go +++ b/azurerm/resource_arm_linux_virtual_machine_scale_set_network_test.go @@ -853,14 +853,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkAcceleratedNetworking(rInt %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F4" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F4" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -903,14 +903,14 @@ resource "azurerm_subnet" "other" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -952,14 +952,14 @@ resource "azurerm_application_security_group" "test" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1007,14 +1007,14 @@ resource "azurerm_application_security_group" "other" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1053,14 +1053,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkDNSServers(rInt int, locat %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1096,14 +1096,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkDNSServersUpdated(rInt int %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1139,14 +1139,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkIPForwarding(rInt int, loc %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1182,14 +1182,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkIPv6(rInt int, location st %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1260,14 +1260,14 @@ resource "azurerm_lb_nat_pool" "test" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1304,14 +1304,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkMultipleIPConfigurations(r %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1351,14 +1351,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkMultipleIPConfigurationsIP %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_D2s_v3" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_D2s_v3" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1399,14 +1399,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkMultipleNICs(rInt int, loc %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1451,14 +1451,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkMultipleNICsMultipleIPConf %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1513,14 +1513,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkMultipleNICsWithDifferentD %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1567,14 +1567,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkMultipleNICsMultiplePublic %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1637,14 +1637,14 @@ resource "azurerm_network_security_group" "test" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1692,14 +1692,14 @@ resource "azurerm_network_security_group" "other" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1735,14 +1735,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkPrivate(rInt int, location %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1777,14 +1777,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkPublicIP(rInt int, locatio %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1824,14 +1824,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkPublicIPDomainNameLabel(rI %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1878,14 +1878,14 @@ resource "azurerm_public_ip_prefix" "test" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1925,14 +1925,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_networkPublicIPTags(rInt int, loc %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { diff --git a/azurerm/resource_arm_linux_virtual_machine_scale_set_other_test.go b/azurerm/resource_arm_linux_virtual_machine_scale_set_other_test.go index 9495870487a4..3e6f489c2ecc 100644 --- a/azurerm/resource_arm_linux_virtual_machine_scale_set_other_test.go +++ b/azurerm/resource_arm_linux_virtual_machine_scale_set_other_test.go @@ -574,14 +574,14 @@ resource "azurerm_storage_account" "test" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -628,14 +628,14 @@ resource "azurerm_storage_account" "test" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -670,15 +670,15 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_otherComputerNamePrefix(rInt int, %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - computer_name_prefix = "morty" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + computer_name_prefix = "morty" + disable_password_authentication = false source_image_reference { @@ -756,14 +756,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_otherDoNotRunExtensionsOnOverProv %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - overprovision = true + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + overprovision = true disable_password_authentication = false do_not_run_extensions_on_overprovisioned_machines = true @@ -800,16 +800,16 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_otherPriorityLow(rInt int, locati %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - eviction_policy = %q - priority = "Low" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + eviction_policy = %q + priority = "Low" + disable_password_authentication = false source_image_reference { @@ -844,16 +844,16 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_otherPriorityLowMaxBidPrice(rInt %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - eviction_policy = "Delete" - priority = "Low" - max_bid_price = %q + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + eviction_policy = "Delete" + priority = "Low" + max_bid_price = %q disable_password_authentication = false @@ -889,15 +889,15 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_otherPriorityRegular(rInt int, lo %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - priority = "Regular" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + priority = "Regular" + disable_password_authentication = false source_image_reference { @@ -974,14 +974,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_otherSecret(rInt int, location st %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1024,14 +1024,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_otherSecretRemoved(rInt int, loca %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1066,14 +1066,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_otherSecretUpdated(rInt int, loca %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1256,14 +1256,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_otherTags(rInt int, location stri %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1302,14 +1302,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_otherTagsUpdated(rInt int, locati %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -1349,14 +1349,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_otherVMAgent(rInt int, location s %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false provision_vm_agent = %t diff --git a/azurerm/resource_arm_linux_virtual_machine_scale_set_scaling_test.go b/azurerm/resource_arm_linux_virtual_machine_scale_set_scaling_test.go index ad089c588e79..3b3967680010 100644 --- a/azurerm/resource_arm_linux_virtual_machine_scale_set_scaling_test.go +++ b/azurerm/resource_arm_linux_virtual_machine_scale_set_scaling_test.go @@ -427,16 +427,16 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_scalingAutoScale(rInt int, locati %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 2 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - overprovision = true + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 2 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + overprovision = true -disable_password_authentication = false + disable_password_authentication = false source_image_reference { publisher = "Canonical" @@ -527,14 +527,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_scalingInstanceCount(rInt int, lo %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = %d - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = %d + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -569,14 +569,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_scalingInstanceCountIgnoreUpdated %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F4" - instances = %d - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F4" + instances = %d + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -615,14 +615,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_scalingOverProvisionDisabled(rInt %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 3 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - overprovision = false + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 3 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + overprovision = false disable_password_authentication = false @@ -664,14 +664,14 @@ resource "azurerm_proximity_placement_group" "test" { } resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false proximity_placement_group_id = azurerm_proximity_placement_group.test.id @@ -707,14 +707,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_scalingSinglePlacementGroupDisabl %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false single_placement_group = false @@ -750,14 +750,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_scalingUpdateSku(rInt int, locati %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = %q - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = %q + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -792,14 +792,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_scalingUpdateSkuIgnoredUpdatedCou %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = %q - instances = 5 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = %q + instances = 5 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + disable_password_authentication = false source_image_reference { @@ -838,14 +838,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_scalingZonesSingle(rInt int, loca %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - zones = ["1"] + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + zones = ["1"] disable_password_authentication = false @@ -881,14 +881,14 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_scalingZonesMultiple(rInt int, lo %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 2 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - zones = ["1", "2"] + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 2 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + zones = ["1", "2"] disable_password_authentication = false @@ -924,15 +924,15 @@ func testAccAzureRMLinuxVirtualMachineScaleSet_scalingZonesBalance(rInt int, loc %s resource "azurerm_linux_virtual_machine_scale_set" "test" { - name = "acctestvmss-%d" - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 4 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - zones = ["1", "2"] - zone_balance = true + name = "acctestvmss-%d" + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 4 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + zones = ["1", "2"] + zone_balance = true disable_password_authentication = false From d1cbfaaf0a4b0963471d7d9479f0fedc9723f0ea Mon Sep 17 00:00:00 2001 From: kt Date: Fri, 25 Oct 2019 09:53:51 -0700 Subject: [PATCH 3/5] pass 3 --- azurerm/data_source_mssql_elasticpool_test.go | 82 +++++++++---------- .../resource_arm_batch_application_test.go | 2 +- azurerm/resource_arm_cosmosdb_account_test.go | 20 ++--- ...rce_arm_front_door_firewall_policy_test.go | 52 ++++++------ ...resource_arm_key_vault_certificate_test.go | 3 +- azurerm/resource_arm_key_vault_test.go | 2 +- ...ux_virtual_machine_scale_set_other_test.go | 2 +- ...ource_arm_scheduler_job_collection_test.go | 2 +- ...ws_virtual_machine_scale_set_other_test.go | 3 +- 9 files changed, 85 insertions(+), 83 deletions(-) diff --git a/azurerm/data_source_mssql_elasticpool_test.go b/azurerm/data_source_mssql_elasticpool_test.go index ca5cf05631e2..67e840ae4576 100644 --- a/azurerm/data_source_mssql_elasticpool_test.go +++ b/azurerm/data_source_mssql_elasticpool_test.go @@ -39,45 +39,45 @@ func TestAccDataSourceAzureRMMsSqlElasticPool_basic(t *testing.T) { func testAccDataSourceAzureRMMsSqlElasticPool_basic(rInt int, location string) string { return fmt.Sprintf(` - resource "azurerm_resource_group" "test" { - name = "acctestRG-%[1]d" - location = "%s" - } - - resource "azurerm_sql_server" "test" { - name = "acctest%[1]d" - resource_group_name = "${azurerm_resource_group.test.name}" - location = "${azurerm_resource_group.test.location}" - version = "12.0" - administrator_login = "4dm1n157r470r" - administrator_login_password = "4-v3ry-53cr37-p455w0rd" - } - - resource "azurerm_mssql_elasticpool" "test" { - name = "acctest-pool-dtu-%[1]d" - resource_group_name = "${azurerm_resource_group.test.name}" - location = "${azurerm_resource_group.test.location}" - server_name = "${azurerm_sql_server.test.name}" - max_size_gb = 50 - zone_redundant = false - - sku { - name = "GP_Gen5" - tier = "GeneralPurpose" - capacity = 4 - family = "Gen5" - } - - per_database_settings { - min_capacity = 0 - max_capacity = 4 - } - } - - data "azurerm_mssql_elasticpool" "test" { - name = "${azurerm_mssql_elasticpool.test.name}" - resource_group_name = "${azurerm_resource_group.test.name}" - server_name = "${azurerm_sql_server.test.name}" - } - `, rInt, location) +resource "azurerm_resource_group" "test" { + name = "acctestRG-%[1]d" + location = "%s" +} + +resource "azurerm_sql_server" "test" { + name = "acctest%[1]d" + resource_group_name = "${azurerm_resource_group.test.name}" + location = "${azurerm_resource_group.test.location}" + version = "12.0" + administrator_login = "4dm1n157r470r" + administrator_login_password = "4-v3ry-53cr37-p455w0rd" +} + +resource "azurerm_mssql_elasticpool" "test" { + name = "acctest-pool-dtu-%[1]d" + resource_group_name = "${azurerm_resource_group.test.name}" + location = "${azurerm_resource_group.test.location}" + server_name = "${azurerm_sql_server.test.name}" + max_size_gb = 50 + zone_redundant = false + + sku { + name = "GP_Gen5" + tier = "GeneralPurpose" + capacity = 4 + family = "Gen5" + } + + per_database_settings { + min_capacity = 0 + max_capacity = 4 + } +} + +data "azurerm_mssql_elasticpool" "test" { + name = "${azurerm_mssql_elasticpool.test.name}" + resource_group_name = "${azurerm_resource_group.test.name}" + server_name = "${azurerm_sql_server.test.name}" +} +`, rInt, location) } diff --git a/azurerm/resource_arm_batch_application_test.go b/azurerm/resource_arm_batch_application_test.go index 8b44da19ef52..03b9bd23d2a2 100644 --- a/azurerm/resource_arm_batch_application_test.go +++ b/azurerm/resource_arm_batch_application_test.go @@ -144,7 +144,7 @@ resource "azurerm_batch_application" "test" { name = "acctestbatchapp-%d" resource_group_name = "${azurerm_resource_group.test.name}" account_name = "${azurerm_batch_account.test.name}" - %s + %s } `, rInt, location, rString, rString, rInt, displayName) } diff --git a/azurerm/resource_arm_cosmosdb_account_test.go b/azurerm/resource_arm_cosmosdb_account_test.go index bcb2fb1a7f50..9301dd66b38e 100644 --- a/azurerm/resource_arm_cosmosdb_account_test.go +++ b/azurerm/resource_arm_cosmosdb_account_test.go @@ -736,7 +736,7 @@ resource "azurerm_cosmosdb_account" "test" { consistency_policy { consistency_level = "%s" - %s + %s } geo_location { @@ -744,7 +744,7 @@ resource "azurerm_cosmosdb_account" "test" { failover_priority = 0 } - %s + %s } `, rInt, location, rInt, consistency, consistencyOptions, additional) } @@ -763,7 +763,7 @@ resource "azurerm_cosmosdb_account" "import" { consistency_policy { consistency_level = "%s" - %s + %s } geo_location { @@ -771,7 +771,7 @@ resource "azurerm_cosmosdb_account" "import" { failover_priority = 0 } - %s + %s } `, template, consistency, consistencyOptions, additional) } @@ -861,7 +861,7 @@ func testAccAzureRMCosmosDBAccount_geoReplicated(rInt int, location string, altL failover_priority = 1 } - `, altLocation)) + `, altLocation)) } func testAccAzureRMCosmosDBAccount_multiMaster(rInt int, location string, altLocation string) string { @@ -878,7 +878,7 @@ func testAccAzureRMCosmosDBAccount_multiMaster(rInt int, location string, altLoc failover_priority = 1 } - `, altLocation)) + `, altLocation)) } func testAccAzureRMCosmosDBAccount_geoReplicated_customId(rInt int, location string, altLocation string) string { @@ -894,7 +894,7 @@ func testAccAzureRMCosmosDBAccount_geoReplicated_customId(rInt int, location str failover_priority = 1 } - `, rInt, altLocation)) + `, rInt, altLocation)) } func testAccAzureRMCosmosDBAccount_geoReplicated_customConsistencyLevel(rInt int, location string, altLocation string, cLevel documentdb.DefaultConsistencyLevel) string { @@ -905,7 +905,7 @@ func testAccAzureRMCosmosDBAccount_geoReplicated_customConsistencyLevel(rInt int failover_priority = 1 } - `, rInt, altLocation)) + `, rInt, altLocation)) } func testAccAzureRMCosmosDBAccount_complete(rInt int, location string, altLocation string) string { @@ -922,7 +922,7 @@ func testAccAzureRMCosmosDBAccount_complete(rInt int, location string, altLocati location = "%s" failover_priority = 1 } - `, rInt, altLocation)) + `, rInt, altLocation)) } func testAccAzureRMCosmosDBAccount_emptyIpFilter(rInt int, location string, altLocation string) string { @@ -940,7 +940,7 @@ func testAccAzureRMCosmosDBAccount_emptyIpFilter(rInt int, location string, altL location = "%s" failover_priority = 1 } - `, rInt, altLocation)) + `, rInt, altLocation)) } func testAccAzureRMCosmosDBAccount_virtualNetworkFilter(rInt int, location string) string { diff --git a/azurerm/resource_arm_front_door_firewall_policy_test.go b/azurerm/resource_arm_front_door_firewall_policy_test.go index 3b91974268e4..ea1005ac9a6b 100644 --- a/azurerm/resource_arm_front_door_firewall_policy_test.go +++ b/azurerm/resource_arm_front_door_firewall_policy_test.go @@ -237,31 +237,31 @@ resource "azurerm_frontdoor_firewall_policy" "import" { func testAccAzureRMFrontDoorFirewallPolicy_updateTemplate() string { return fmt.Sprintf(` - custom_rule { - name = "Rule2" - enabled = true - priority = 2 - rate_limit_duration_in_minutes = 1 - rate_limit_threshold = 10 - type = "MatchRule" - action = "Block" - - match_condition { - match_variable = "RemoteAddr" - operator = "IPMatch" - negation_condition = false - match_values = ["192.168.1.0/24"] - } +custom_rule { + name = "Rule2" + enabled = true + priority = 2 + rate_limit_duration_in_minutes = 1 + rate_limit_threshold = 10 + type = "MatchRule" + action = "Block" + + match_condition { + match_variable = "RemoteAddr" + operator = "IPMatch" + negation_condition = false + match_values = ["192.168.1.0/24"] + } - match_condition { - match_variable = "RequestHeader" - selector = "UserAgent" - operator = "Contains" - negation_condition = false - match_values = ["windows"] - transforms = ["Lowercase", "Trim"] - } + match_condition { + match_variable = "RequestHeader" + selector = "UserAgent" + operator = "Contains" + negation_condition = false + match_values = ["windows"] + transforms = ["Lowercase", "Trim"] } +} `) } @@ -298,7 +298,7 @@ resource "azurerm_frontdoor_firewall_policy" "test" { } } - %[2]s + %[2]s managed_rule { type = "DefaultRuleSet" @@ -316,8 +316,8 @@ resource "azurerm_frontdoor_firewall_policy" "test" { } managed_rule { - type = "BotProtection" - version = "preview-0.1" + type = "BotProtection" + version = "preview-0.1" } } `, rInt, sTemplate, location) diff --git a/azurerm/resource_arm_key_vault_certificate_test.go b/azurerm/resource_arm_key_vault_certificate_test.go index 309b3fbc4f11..d09d6a1ffb8e 100644 --- a/azurerm/resource_arm_key_vault_certificate_test.go +++ b/azurerm/resource_arm_key_vault_certificate_test.go @@ -543,7 +543,8 @@ resource "azurerm_key_vault_certificate" "import" { content_type = "application/x-pkcs12" } } -}`, template) +} +`, template) } func testAccAzureRMKeyVaultCertificate_basicGenerate(rString string, location string) string { diff --git a/azurerm/resource_arm_key_vault_test.go b/azurerm/resource_arm_key_vault_test.go index 716b3e4e4ae0..7061d85e2968 100644 --- a/azurerm/resource_arm_key_vault_test.go +++ b/azurerm/resource_arm_key_vault_test.go @@ -878,7 +878,7 @@ resource "azurerm_key_vault" "test" { tenant_id = "${data.azurerm_client_config.current.tenant_id}" sku_name = "premium" - %s + %s } %s diff --git a/azurerm/resource_arm_linux_virtual_machine_scale_set_other_test.go b/azurerm/resource_arm_linux_virtual_machine_scale_set_other_test.go index 3e6f489c2ecc..e3c7d8f9ee29 100644 --- a/azurerm/resource_arm_linux_virtual_machine_scale_set_other_test.go +++ b/azurerm/resource_arm_linux_virtual_machine_scale_set_other_test.go @@ -938,7 +938,7 @@ resource "azurerm_linux_virtual_machine_scale_set" "import" { sku = azurerm_linux_virtual_machine_scale_set.test.sku instances = azurerm_linux_virtual_machine_scale_set.test.instances admin_username = azurerm_linux_virtual_machine_scale_set.test.admin_username - admin_password = "azurerm_linux_virtual_machine_scale_set.test.admin_password + admin_password = azurerm_linux_virtual_machine_scale_set.test.admin_password disable_password_authentication = false diff --git a/azurerm/resource_arm_scheduler_job_collection_test.go b/azurerm/resource_arm_scheduler_job_collection_test.go index 769c88056086..6ac3e784a226 100644 --- a/azurerm/resource_arm_scheduler_job_collection_test.go +++ b/azurerm/resource_arm_scheduler_job_collection_test.go @@ -174,7 +174,7 @@ resource "azurerm_scheduler_job_collection" "import" { resource_group_name = "${azurerm_scheduler_job_collection.test.resource_group_name}" sku = "${azurerm_scheduler_job_collection.test.sku}" - %s + %s } `, testAccAzureRMSchedulerJobCollection_basic(rInt, location, additional), additional) } diff --git a/azurerm/resource_arm_windows_virtual_machine_scale_set_other_test.go b/azurerm/resource_arm_windows_virtual_machine_scale_set_other_test.go index e77dbafd5a44..42625ddd85c7 100644 --- a/azurerm/resource_arm_windows_virtual_machine_scale_set_other_test.go +++ b/azurerm/resource_arm_windows_virtual_machine_scale_set_other_test.go @@ -985,6 +985,7 @@ resource "azurerm_windows_virtual_machine_scale_set" "test" { admin_username = "adminuser" admin_password = "P@ssword1234!" overprovision = true + do_not_run_extensions_on_overprovisioned_machines = true source_image_reference { @@ -1192,7 +1193,7 @@ resource "azurerm_windows_virtual_machine_scale_set" "import" { sku = azurerm_windows_virtual_machine_scale_set.test.sku instances = azurerm_windows_virtual_machine_scale_set.test.instances admin_username = azurerm_windows_virtual_machine_scale_set.test.admin_username - admin_password = "azurerm_windows_virtual_machine_scale_set.test.admin_password + admin_password = azurerm_windows_virtual_machine_scale_set.test.admin_password source_image_reference { publisher = "MicrosoftWindowsServer" From 3ff83d4e14a1473811b3d90678710f0f0f23c136 Mon Sep 17 00:00:00 2001 From: kt Date: Fri, 25 Oct 2019 10:10:42 -0700 Subject: [PATCH 4/5] pass 4 --- azurerm/data_source_arm_data_factory_test.go | 2 +- .../data_source_express_route_circuit_test.go | 2 +- ...a_source_network_ddos_protection_plan_test.go | 2 +- azurerm/resource_arm_batch_application_test.go | 2 +- azurerm/resource_arm_cosmosdb_account_test.go | 8 ++++---- ...source_arm_front_door_firewall_policy_test.go | 2 +- .../resource_arm_key_vault_certificate_test.go | 2 +- azurerm/resource_arm_key_vault_test.go | 2 +- azurerm/resource_arm_mssql_elasticpool_test.go | 2 +- ...resource_arm_scheduler_job_collection_test.go | 2 +- ...ndows_virtual_machine_scale_set_other_test.go | 16 ++++++++-------- 11 files changed, 21 insertions(+), 21 deletions(-) diff --git a/azurerm/data_source_arm_data_factory_test.go b/azurerm/data_source_arm_data_factory_test.go index 1d6109df4fcb..90945cf372cf 100644 --- a/azurerm/data_source_arm_data_factory_test.go +++ b/azurerm/data_source_arm_data_factory_test.go @@ -31,7 +31,7 @@ func TestAccAzureRMDataFactoryDataSource_basic(t *testing.T) { func testAccAzureRMDataFactoryDataSource_basic(rInt int, location string) string { config := testAccAzureRMDataFactory_basic(rInt, location) return fmt.Sprintf(` - %s +%s data "azurerm_data_factory" "test" { name = "${azurerm_data_factory.test.name}" diff --git a/azurerm/data_source_express_route_circuit_test.go b/azurerm/data_source_express_route_circuit_test.go index 7189b8ad99a1..c7ded4d6c03a 100644 --- a/azurerm/data_source_express_route_circuit_test.go +++ b/azurerm/data_source_express_route_circuit_test.go @@ -37,7 +37,7 @@ func testAccDataSourceAzureRMExpressRoute_basic(rInt int, location string) strin config := testAccAzureRMExpressRouteCircuit_basicMeteredConfig(rInt, location) return fmt.Sprintf(` - %s +%s data "azurerm_express_route_circuit" test { resource_group_name = "${azurerm_resource_group.test.name}" diff --git a/azurerm/data_source_network_ddos_protection_plan_test.go b/azurerm/data_source_network_ddos_protection_plan_test.go index 207056a1ac74..d84277d2815b 100644 --- a/azurerm/data_source_network_ddos_protection_plan_test.go +++ b/azurerm/data_source_network_ddos_protection_plan_test.go @@ -31,7 +31,7 @@ func testAccAzureRMNetworkDDoSProtectionPlanDataSource_basic(t *testing.T) { func testAccAzureRMNetworkDDoSProtectionPlanDataSource_basicConfig(rInt int, location string) string { return fmt.Sprintf(` - %s +%s data "azurerm_network_ddos_protection_plan" "test" { name = "${azurerm_network_ddos_protection_plan.test.name}" diff --git a/azurerm/resource_arm_batch_application_test.go b/azurerm/resource_arm_batch_application_test.go index 03b9bd23d2a2..155df2685e10 100644 --- a/azurerm/resource_arm_batch_application_test.go +++ b/azurerm/resource_arm_batch_application_test.go @@ -144,7 +144,7 @@ resource "azurerm_batch_application" "test" { name = "acctestbatchapp-%d" resource_group_name = "${azurerm_resource_group.test.name}" account_name = "${azurerm_batch_account.test.name}" - %s + %s } `, rInt, location, rString, rString, rInt, displayName) } diff --git a/azurerm/resource_arm_cosmosdb_account_test.go b/azurerm/resource_arm_cosmosdb_account_test.go index 9301dd66b38e..697f4ce8fee9 100644 --- a/azurerm/resource_arm_cosmosdb_account_test.go +++ b/azurerm/resource_arm_cosmosdb_account_test.go @@ -736,7 +736,7 @@ resource "azurerm_cosmosdb_account" "test" { consistency_policy { consistency_level = "%s" - %s + %s } geo_location { @@ -744,7 +744,7 @@ resource "azurerm_cosmosdb_account" "test" { failover_priority = 0 } - %s + %s } `, rInt, location, rInt, consistency, consistencyOptions, additional) } @@ -763,7 +763,7 @@ resource "azurerm_cosmosdb_account" "import" { consistency_policy { consistency_level = "%s" - %s + %s } geo_location { @@ -771,7 +771,7 @@ resource "azurerm_cosmosdb_account" "import" { failover_priority = 0 } - %s + %s } `, template, consistency, consistencyOptions, additional) } diff --git a/azurerm/resource_arm_front_door_firewall_policy_test.go b/azurerm/resource_arm_front_door_firewall_policy_test.go index ea1005ac9a6b..0510cf657cc4 100644 --- a/azurerm/resource_arm_front_door_firewall_policy_test.go +++ b/azurerm/resource_arm_front_door_firewall_policy_test.go @@ -298,7 +298,7 @@ resource "azurerm_frontdoor_firewall_policy" "test" { } } - %[2]s + %[2]s managed_rule { type = "DefaultRuleSet" diff --git a/azurerm/resource_arm_key_vault_certificate_test.go b/azurerm/resource_arm_key_vault_certificate_test.go index d09d6a1ffb8e..f99689860bc2 100644 --- a/azurerm/resource_arm_key_vault_certificate_test.go +++ b/azurerm/resource_arm_key_vault_certificate_test.go @@ -519,7 +519,7 @@ func testAccAzureRMKeyVaultCertificate_requiresImport(rString string, location s %s resource "azurerm_key_vault_certificate" "import" { - name = "${azurerm_key_vault_certificate.test.name}" + name = "${azurerm_key_vault_certificate.test.name}" key_vault_id = "${azurerm_key_vault.test.id}" certificate { diff --git a/azurerm/resource_arm_key_vault_test.go b/azurerm/resource_arm_key_vault_test.go index 7061d85e2968..716b3e4e4ae0 100644 --- a/azurerm/resource_arm_key_vault_test.go +++ b/azurerm/resource_arm_key_vault_test.go @@ -878,7 +878,7 @@ resource "azurerm_key_vault" "test" { tenant_id = "${data.azurerm_client_config.current.tenant_id}" sku_name = "premium" - %s + %s } %s diff --git a/azurerm/resource_arm_mssql_elasticpool_test.go b/azurerm/resource_arm_mssql_elasticpool_test.go index cb5635827bd0..246e4d9bd911 100644 --- a/azurerm/resource_arm_mssql_elasticpool_test.go +++ b/azurerm/resource_arm_mssql_elasticpool_test.go @@ -509,7 +509,7 @@ resource "azurerm_mssql_elasticpool" "test" { server_name = "${azurerm_sql_server.test.name}" max_size_gb = %.7[6]f zone_redundant = %[9]t - + sku { name = "%[3]s" tier = "%[4]s" diff --git a/azurerm/resource_arm_scheduler_job_collection_test.go b/azurerm/resource_arm_scheduler_job_collection_test.go index 6ac3e784a226..9a6d9947b161 100644 --- a/azurerm/resource_arm_scheduler_job_collection_test.go +++ b/azurerm/resource_arm_scheduler_job_collection_test.go @@ -174,7 +174,7 @@ resource "azurerm_scheduler_job_collection" "import" { resource_group_name = "${azurerm_scheduler_job_collection.test.resource_group_name}" sku = "${azurerm_scheduler_job_collection.test.sku}" - %s + %s } `, testAccAzureRMSchedulerJobCollection_basic(rInt, location, additional), additional) } diff --git a/azurerm/resource_arm_windows_virtual_machine_scale_set_other_test.go b/azurerm/resource_arm_windows_virtual_machine_scale_set_other_test.go index 42625ddd85c7..f8419ab96e28 100644 --- a/azurerm/resource_arm_windows_virtual_machine_scale_set_other_test.go +++ b/azurerm/resource_arm_windows_virtual_machine_scale_set_other_test.go @@ -977,14 +977,14 @@ func testAccAzureRMWindowsVirtualMachineScaleSet_otherDoNotRunExtensionsOnOverPr %s resource "azurerm_windows_virtual_machine_scale_set" "test" { - name = local.vm_name - resource_group_name = azurerm_resource_group.test.name - location = azurerm_resource_group.test.location - sku = "Standard_F2" - instances = 1 - admin_username = "adminuser" - admin_password = "P@ssword1234!" - overprovision = true + name = local.vm_name + resource_group_name = azurerm_resource_group.test.name + location = azurerm_resource_group.test.location + sku = "Standard_F2" + instances = 1 + admin_username = "adminuser" + admin_password = "P@ssword1234!" + overprovision = true do_not_run_extensions_on_overprovisioned_machines = true From 9131d352f57ea7e2dfd7544d773ac1de82b837fb Mon Sep 17 00:00:00 2001 From: kt Date: Fri, 25 Oct 2019 10:34:09 -0700 Subject: [PATCH 5/5] pass 5 --- .../resource_arm_policy_set_definition_test.go | 1 + ..._private_dns_zone_virtual_network_link_test.go | 6 +++--- .../resource_arm_servicebus_subscription_test.go | 1 + azurerm/resource_arm_stream_analytics_job_test.go | 15 ++++++++------- 4 files changed, 13 insertions(+), 10 deletions(-) diff --git a/azurerm/resource_arm_policy_set_definition_test.go b/azurerm/resource_arm_policy_set_definition_test.go index 6695b5711660..9e0a31938c38 100644 --- a/azurerm/resource_arm_policy_set_definition_test.go +++ b/azurerm/resource_arm_policy_set_definition_test.go @@ -156,6 +156,7 @@ POLICY_DEFINITIONS func testAzureRMPolicySetDefinition_requiresImport(ri int) string { return fmt.Sprintf(` + %s resource "azurerm_policy_set_definition" "import" { diff --git a/azurerm/resource_arm_private_dns_zone_virtual_network_link_test.go b/azurerm/resource_arm_private_dns_zone_virtual_network_link_test.go index f828b69902aa..628cd01789cc 100644 --- a/azurerm/resource_arm_private_dns_zone_virtual_network_link_test.go +++ b/azurerm/resource_arm_private_dns_zone_virtual_network_link_test.go @@ -201,10 +201,10 @@ func testAccAzureRMPrivateDnsZoneVirtualNetworkLink_requiresImport(rInt int, loc %s resource "azurerm_private_dns_zone_virtual_network_link" "import" { - name = "${azurerm_private_dns_zone_virtual_network_link.test.name} + name = "${azurerm_private_dns_zone_virtual_network_link.test.name}" private_dns_zone_name = "${azurerm_private_dns_zone_virtual_network_link.test.private_dns_zone_name}" - virtual_network_id = "${azurerm_private_dns_zone_virtual_network_link.test.virtual_network_id}" - resource_group_name = "${azurerm_private_dns_zone_virtual_network_link.test.resource_group_name}" + virtual_network_id = "${azurerm_private_dns_zone_virtual_network_link.test.virtual_network_id}" + resource_group_name = "${azurerm_private_dns_zone_virtual_network_link.test.resource_group_name}" } `, template) } diff --git a/azurerm/resource_arm_servicebus_subscription_test.go b/azurerm/resource_arm_servicebus_subscription_test.go index bf86f4067053..a96e1d334f3a 100644 --- a/azurerm/resource_arm_servicebus_subscription_test.go +++ b/azurerm/resource_arm_servicebus_subscription_test.go @@ -287,6 +287,7 @@ func testAccAzureRMServiceBusSubscription_basic(rInt int, location string) strin func testAccAzureRMServiceBusSubscription_requiresImport(rInt int, location string) string { return fmt.Sprintf(` + %s resource "azurerm_servicebus_subscription" "import" { diff --git a/azurerm/resource_arm_stream_analytics_job_test.go b/azurerm/resource_arm_stream_analytics_job_test.go index effe169dfc7c..a18a80d4e1f3 100644 --- a/azurerm/resource_arm_stream_analytics_job_test.go +++ b/azurerm/resource_arm_stream_analytics_job_test.go @@ -183,21 +183,22 @@ resource "azurerm_resource_group" "test" { } resource "azurerm_stream_analytics_job" "test" { - name = "acctestjob-%d" - resource_group_name = "${azurerm_resource_group.test.name}" - location = "${azurerm_resource_group.test.location}" - streaming_units = 3 + name = "acctestjob-%d" + resource_group_name = "${azurerm_resource_group.test.name}" + location = "${azurerm_resource_group.test.location}" + streaming_units = 3 tags = { environment = "Test" - } - + } + transformation_query = <