Fix nil pointer dereference in data.azuread_users and improve test coverage

[manicminer]

• Better test coverage in data.azuread_user and data.azuread_users.
• Prettier errors when users not found.
• Fix nil pointer dereference due to mishandling of search results (reported: Allow for graceful handling of errored users within users data source #256 (comment))

[katbyte]

LGTM :rock

[patrickmarabeas]

Can confirm it's functioning as expected now 👍

[manicminer]

Test results:

[patrickmarabeas]

@manicminer I take it back. It seems as though when one user errors, it exits the loop at that point. Given:

[ 
  "realuser1",
  "realuser2",
  "realuser3",  
  "zzzzzz",
]

The result is expected. However, given:

[
  "aaaaaa",
  "realuser1",
  "realuser2",
  "realuser3",  
]

No users are returned.

Can you confirm you are seeing the same result?

[patrickmarabeas]

Oh, *face-palm. It should be continue not break.

I'll raise a fix.

[manicminer]

@patrickmarabeas thanks for testing and for the fix - as soon as I read your comment I realised that loop should have continued :)

[ghost]

This has been released in version 0.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.11.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!