Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: oauth2Permissions and appRoles allow dupes #971

Merged
merged 3 commits into from
Jan 12, 2023
Merged

fix: oauth2Permissions and appRoles allow dupes #971

merged 3 commits into from
Jan 12, 2023

Conversation

tsanton
Copy link
Contributor

@tsanton tsanton commented Jan 11, 2023 •
edited by manicminer
Loading

closes #963

Maintainer note: see issue for discussion (manicminer)

@manicminer manicminer added this to the v2.32.0 milestone Jan 11, 2023
manicminer
manicminer approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tsanton Thanks for the discussion and your work on this. This LGTM and tests are passing 🚀

Screen Shot 2023-01-12 at 14 08 20

@manicminer manicminer merged commit 60986aa into hashicorp:main Jan 12, 2023
manicminer added a commit that referenced this pull request Jan 12, 2023
@manicminer
Changelog for #971
7b25c39
@github-actions
Copy link

This functionality has been released in v2.32.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
bug feature/applications size/L
Projects
None yet
Milestone
v2.32.0
Development

Successfully merging this pull request may close these issues.

azuread_application bug: oauth2_permission_scope & app_role duplicate id
2 participants
@tsanton @manicminer