Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for cloud_displayname #967

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Add support for cloud_displayname #967

merged 2 commits into from
Jan 11, 2023

Conversation

cvs79
Copy link
Contributor

@cvs79 cvs79 commented Jan 10, 2023

Fixes #965

manicminer
manicminer suggested changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cvs79, thanks for this contribution! I've added some comments inline below, if you can take a look at these then this should be good to merge. Thanks!

internal/services/applications/migrations/application_resource.go Outdated Show resolved Hide resolved
internal/services/applications/migrations/application_resource.go Outdated Show resolved Hide resolved
internal/services/applications/schema.go Outdated Show resolved Hide resolved
@manicminer manicminer added this to the v2.32.0 milestone Jan 10, 2023
@cvs79
Copy link
Contributor Author

cvs79 commented Jan 10, 2023

@manicminer fixed the comments but it seems the workflow is failing on something out side of my control now.

manicminer
manicminer approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cvs79 That's great, thanks for updating! The workflow failure is unrelated, we'll fix that separately.

@manicminer manicminer merged commit 49f8b94 into hashicorp:main Jan 11, 2023
manicminer added a commit that referenced this pull request Jan 11, 2023
@manicminer
Changelog for #967
aea2610
@cvs79 cvs79 deleted the cloud_displayname_support branch January 11, 2023 15:45
@github-actions
Copy link

This functionality has been released in v2.32.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

Assignees
No one assigned
Labels
enhancement feature/applications size/XS
Projects
None yet
Milestone
v2.32.0
Development

Successfully merging this pull request may close these issues.

Support cloud_displayname for saml_token
2 participants
@cvs79 @manicminer