Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azuread_directory_roles data source #945

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

alexwilcox9
Copy link
Contributor

This PR adds a data source that enables the lookup of all activated directory roles in the tenant.

My use case for this is as a dynamic way to populate roles in a conditional access policy but I'm sure there are other use cases that would benefit from it.
Down the line we could look to add the ability to filter specific roles based on ID or name much like the azuread_users data source

Let me know your feedback and any changes that are needed, thanks!

@alexwilcox9 alexwilcox9 changed the title Add basic roles data source Add azuread_directory_roles data source Dec 8, 2022
@github-actions github-actions bot added the size/L label Dec 8, 2022
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @alexwilcox9! Sorry for the delay in reviewing, just a few minor changes which I'll roll in below and this LGTM 👍

Screen Shot 2023-01-11 at 14 49 47

internal/services/directoryroles/registration.go Outdated Show resolved Hide resolved
docs/data-sources/directory_roles.md Outdated Show resolved Hide resolved
@manicminer manicminer added this to the v2.32.0 milestone Jan 12, 2023
@manicminer manicminer merged commit c53cf05 into hashicorp:main Jan 12, 2023
manicminer added a commit that referenced this pull request Jan 12, 2023
@github-actions
Copy link

This functionality has been released in v2.32.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants