-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add azuread_directory_roles
data source
#945
Conversation
azuread_directory_roles
data source
5f1a0cc
to
5900a63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @alexwilcox9! Sorry for the delay in reviewing, just a few minor changes which I'll roll in below and this LGTM 👍
internal/services/directoryroles/directory_roles_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/directoryroles/directory_roles_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/directoryroles/directory_roles_data_source.go
Outdated
Show resolved
Hide resolved
internal/services/directoryroles/directory_roles_data_source_test.go
Outdated
Show resolved
Hide resolved
This functionality has been released in v2.32.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds a data source that enables the lookup of all activated directory roles in the tenant.
My use case for this is as a dynamic way to populate roles in a conditional access policy but I'm sure there are other use cases that would benefit from it.
Down the line we could look to add the ability to filter specific roles based on ID or name much like the
azuread_users
data sourceLet me know your feedback and any changes that are needed, thanks!