Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Principals: Use v1.0 API #896

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Sep 29, 2022

Depends on: manicminer/hamilton#183

Resolves an issue with government clouds having a broken beta serviceprincipals API.

Also update to latest Terraform Plugin SDK

@manicminer
Copy link
Contributor Author

Test results (one unrelated failure)

SCR-20220929-p2w

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎡

@manicminer manicminer force-pushed the feature/serviceprincipals-v1.0-api branch from 56865b9 to a9efb47 Compare September 29, 2022 21:15
manicminer added a commit that referenced this pull request Sep 29, 2022
@manicminer manicminer merged commit 716e4c9 into main Sep 29, 2022
@manicminer manicminer deleted the feature/serviceprincipals-v1.0-api branch September 29, 2022 22:32
@github-actions
Copy link

This functionality has been released in v2.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants