Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for optional additional property #864

Merged
merged 8 commits into from
Aug 25, 2022
Merged

Add Support for optional additional property #864

merged 8 commits into from
Aug 25, 2022

Conversation

MarkDordoy
Copy link
Contributor

Adding max_size_limit as an optional property. When this is used, it allows the groups added to the token or SAML response to go from 150 to a max of 1000.

@manicminer manicminer added this to the v2.28.0 milestone Aug 25, 2022
manicminer
manicminer approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @MarkDordoy, just one comment but otherwise this LGTM! I'm working on fixing the tests and once that's done we'll be able to merge this 👍

internal/services/applications/migrations/application_resource.go Outdated Show resolved Hide resolved
katbyte
katbyte approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌳

@manicminer manicminer merged commit 82d6a3a into hashicorp:main Aug 25, 2022
manicminer added a commit that referenced this pull request Aug 25, 2022
@manicminer
Changelog for #864
1a04a24
@github-actions
Copy link

This functionality has been released in v2.28.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manicminer manicminer manicminer approved these changes

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
enhancement feature/applications size/XS
Projects
None yet
Milestone
v2.28.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkDordoy @manicminer @katbyte