Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuread_directory_role_assignment: fix a bug where directory_scope_id was not effectively optional #840

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

manicminer
Copy link
Contributor

Resolves: #839

@manicminer manicminer requested a review from a team July 11, 2022 09:59
@manicminer manicminer added this to the v2.26.1 milestone Jul 11, 2022
@manicminer manicminer changed the title azuread_directory_role_assignment: fix a bug where direvctory_scope_id was not effectively optional azuread_directory_role_assignment: fix a bug where directory_scope_id was not effectively optional Jul 11, 2022
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit 948da48 into main Jul 11, 2022
@manicminer manicminer deleted the bugfix/role-assignment-defaults branch July 11, 2022 10:07
manicminer added a commit that referenced this pull request Jul 11, 2022
@github-actions
Copy link

This functionality has been released in v2.26.1 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azuread_directory_role_assignment fails in v2.26.0 when directory_scope_id is not set
2 participants