Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: fix a bug with scoped role assignments and fix incorrect schema validation #837

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Bugfix: fix a bug with scoped role assignments and fix incorrect schema validation #837

merged 1 commit into from
Jul 8, 2022

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Jul 8, 2022 •
edited
Loading

Also rename these properties, with deprecation path:

  • app_scope_object_id to app_scope_id
  • directory_scope_object_id to directory_scope_id

@manicminer manicminer added this to the v2.26.0 milestone Jul 8, 2022
@manicminer manicminer requested a review from a team July 8, 2022 00:24
manicminer
manicminer commented Jul 8, 2022
View reviewed changes
internal/services/directoryroles/directory_role_assignment_resource.go
@@ -43,35 +42,58 @@ func directoryRoleAssignmentResource() *schema.Resource {
"role_id": {
Description: "The object ID of the directory role for this assignment",
Type: schema.TypeString,
Optional: true,
Required: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is documented as required, it being optional is a bug.

manicminer
manicminer commented Jul 8, 2022
View reviewed changes
internal/services/directoryroles/directory_role_assignment_resource.go
ForceNew: true,
ValidateDiagFunc: validate.UUID,
},

"principal_object_id": {
Description: "The object ID of the member principal",
Type: schema.TypeString,
Optional: true,
Required: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is documented as required, it being optional is a bug.

katbyte
katbyte approved these changes Jul 8, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦀

@manicminer manicminer merged commit 5dc7ae3 into main Jul 8, 2022
@manicminer manicminer deleted the bugfix/scoped-role-assignments branch July 8, 2022 11:10
manicminer added a commit that referenced this pull request Jul 8, 2022
@manicminer
Changelog for #837
5b29b4f
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v2.26.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
bug feature/directory-roles size/L
Projects
None yet
Milestone
v2.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@manicminer @katbyte