Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: <show_all_groups = true> groups_datasource.go #516

Closed
Threpio opened this issue Aug 13, 2021 · 2 comments · Fixed by #520
Closed

Feature Request: <show_all_groups = true> groups_datasource.go #516

Threpio opened this issue Aug 13, 2021 · 2 comments · Fixed by #520

Comments

@Threpio
Copy link
Contributor

Threpio commented Aug 13, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritise this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritise the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Similar to #512

For work I am treating the AAD setup as the single source of truth for user base/permissions and group permissions.

I would like to be able to fetch a list of all groups as well as fetch all groups on a wildcard filter (if possible).

The functionality of fetching all groups is similar to the all_users source where we are currently passing through a query set of params and so passing an empty set would return all groups.

New or Affected Resource(s)

AFFECTED - Changed to include a flag for 'all groups':

internal/services/groups/groups_datasource.go
internal/services/groups/groups_datasource_test.go

Potential Terraform Configuration

data "azuread_groups" "groups" {
  show_all_groups = true
}

References

Sibling Issue:
#512

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This functionality has been released in v2.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Oct 3, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants