Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest go-azure-helpers with TenantOnly support for CLI authentication #358

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Nov 19, 2020

This aims to remove remaining references to subscriptions and fully support Azure CLI authentication oriented around targeting a tenant.

Also bumping SDK versions, although there's nothing new for graphrbac.

Fixes: #294
Fixes: #314
Fixes: #343

@manicminer manicminer added this to the v1.1.0 milestone Nov 19, 2020
@manicminer manicminer requested a review from a team November 19, 2020 14:04
@ghost ghost added the size/XXL label Nov 19, 2020
@manicminer manicminer force-pushed the f/cli-auth-tenant-only branch 2 times, most recently from 223788f to 350fb9a Compare November 19, 2020 16:43
@manicminer
Copy link
Contributor Author

manicminer commented Nov 19, 2020

GitHub actions not running, but checks are passing locally for me.

EDIT: Also see https://github.com/manicminer/terraform-provider-azuread/pull/1

@manicminer manicminer force-pushed the f/cli-auth-tenant-only branch 3 times, most recently from ed81e9b to e9e1f61 Compare November 19, 2020 17:25
@manicminer manicminer force-pushed the f/cli-auth-tenant-only branch from e9e1f61 to 710ea07 Compare November 19, 2020 20:28
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

manicminer added a commit that referenced this pull request Nov 25, 2020
@manicminer manicminer merged commit e8bee9f into master Nov 25, 2020
@manicminer manicminer deleted the f/cli-auth-tenant-only branch November 25, 2020 14:19
@ghost
Copy link

ghost commented Nov 25, 2020

This has been released in version 1.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 1.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 25, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants