Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various documentation fixes and enable custom partner ID #350

Merged
merged 5 commits into from
Nov 19, 2020
Merged

Various documentation fixes and enable custom partner ID #350

merged 5 commits into from
Nov 19, 2020

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented Nov 6, 2020 •
edited
Loading

  • Enable a custom partner ID
  • Fix some typos
  • Bring example configs up to date
  • Present example AAD roles as a table
  • Document the metadata_host provider attribute
  • Add provider attributes for configuring partner ID
  • Clarify that MSI authentication only works for the current tenant

Closes #349

@manicminer manicminer added this to the v1.1.0 milestone Nov 6, 2020
@ghost ghost added size/M size/L and removed size/M labels Nov 6, 2020
katbyte
katbyte approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

internal/services/configure_client.go Outdated Show resolved Hide resolved
@manicminer manicminer merged commit d90812e into master Nov 19, 2020
manicminer added a commit that referenced this pull request Nov 19, 2020
@manicminer
Update changelog for #350
63f8ab3
@manicminer manicminer deleted the docs-fixes branch November 19, 2020 12:02
@manicminer manicminer linked an issue Nov 19, 2020 that may be closed by this pull request
Failure to retreive obecjts (users and groups) with MSI authentication #347
Closed
@ghost
Copy link

ghost commented Nov 25, 2020

This has been released in version 1.1.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 1.1.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Dec 19, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement provider size/L
Projects
None yet
Milestone
v1.1.0
2 participants
@manicminer @katbyte