add validation to all the things

[katbyte]

No description provided.

[katbyte]

[19:36:47] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azuread▸master$ make fmt; make testacc TEST=./azuread TESTARGS=-test.run=TestAc
==> Fixing source code with gofmt...
gofmt -s -w ./azuread
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./azuread -v -test.run=TestAc -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azuread/version.ProviderVersion=acc"
=== RUN   TestAccAzureADApplicationDataSource_byObjectId
=== PAUSE TestAccAzureADApplicationDataSource_byObjectId
=== RUN   TestAccAzureADApplicationDataSource_byObjectIdComplete
=== PAUSE TestAccAzureADApplicationDataSource_byObjectIdComplete
=== RUN   TestAccAzureADApplicationDataSource_byName
=== PAUSE TestAccAzureADApplicationDataSource_byName
=== RUN   TestAccAzureADServicePrincipalDataSource_byApplicationId
=== PAUSE TestAccAzureADServicePrincipalDataSource_byApplicationId
=== RUN   TestAccAzureADServicePrincipalDataSource_byDisplayName
=== PAUSE TestAccAzureADServicePrincipalDataSource_byDisplayName
=== RUN   TestAccAzureADServicePrincipalDataSource_byObjectId
=== PAUSE TestAccAzureADServicePrincipalDataSource_byObjectId
=== RUN   TestAccAzureADApplication_basic
=== PAUSE TestAccAzureADApplication_basic
=== RUN   TestAccAzureADApplication_availableToOtherTenants
=== PAUSE TestAccAzureADApplication_availableToOtherTenants
=== RUN   TestAccAzureADApplication_complete
=== PAUSE TestAccAzureADApplication_complete
=== RUN   TestAccAzureADApplication_update
=== PAUSE TestAccAzureADApplication_update
=== RUN   TestAccAzureADServicePrincipalPassword_basic
=== PAUSE TestAccAzureADServicePrincipalPassword_basic
=== RUN   TestAccAzureADServicePrincipalPassword_requiresImport
--- SKIP: TestAccAzureADServicePrincipalPassword_requiresImport (0.00s)
    resource_service_principal_password_test.go:47: Skipping since resources aren't required to be imported
=== RUN   TestAccAzureADServicePrincipalPassword_customKeyId
=== PAUSE TestAccAzureADServicePrincipalPassword_customKeyId
=== RUN   TestAccAzureADServicePrincipal_basic
=== PAUSE TestAccAzureADServicePrincipal_basic
=== CONT  TestAccAzureADApplicationDataSource_byObjectId
=== CONT  TestAccAzureADApplication_availableToOtherTenants
=== CONT  TestAccAzureADServicePrincipalDataSource_byDisplayName
=== CONT  TestAccAzureADApplication_basic
=== CONT  TestAccAzureADServicePrincipalDataSource_byObjectId
=== CONT  TestAccAzureADApplicationDataSource_byName
=== CONT  TestAccAzureADServicePrincipalDataSource_byApplicationId
=== CONT  TestAccAzureADServicePrincipalPassword_customKeyId
=== CONT  TestAccAzureADApplication_update
--- PASS: TestAccAzureADApplication_basic (3.43s)
--- PASS: TestAccAzureADApplication_availableToOtherTenants (3.43s)
=== CONT  TestAccAzureADServicePrincipalPassword_basic
--- PASS: TestAccAzureADApplicationDataSource_byObjectId (4.50s)
=== CONT  TestAccAzureADApplication_complete
--- PASS: TestAccAzureADApplicationDataSource_byName (4.69s)
=== CONT  TestAccAzureADServicePrincipal_basic
--- PASS: TestAccAzureADServicePrincipalDataSource_byDisplayName (6.19s)
=== CONT  TestAccAzureADApplicationDataSource_byObjectIdComplete
--- PASS: TestAccAzureADServicePrincipalDataSource_byApplicationId (6.37s)
--- PASS: TestAccAzureADServicePrincipalDataSource_byObjectId (6.66s)
--- PASS: TestAccAzureADApplication_complete (3.43s)
--- PASS: TestAccAzureADServicePrincipalPassword_customKeyId (8.54s)
--- PASS: TestAccAzureADApplication_update (5.13s)
--- PASS: TestAccAzureADServicePrincipal_basic (4.46s)
--- PASS: TestAccAzureADApplicationDataSource_byObjectIdComplete (4.09s)
--- PASS: TestAccAzureADServicePrincipalPassword_basic (7.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azuread/azuread	11.169s
[19:37:07] kt@snowbook:~/hashi/..3../terraform-providers/terraform-provider-azuread▸refactor/validate-all-things$

[tombuildsstuff]

LGTM 👍

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!