azuread_application: validate values for app_role and oauth2_permissions to screen for duplicates

[manicminer]

Roles (appRoles) and scopes (oauth2Permissions) exposed by an application share a common namespace where the values cannot overlap. This change adds some local validation to screen for these before PATCHing an application.

Changes the resulting error message from this:

Error: patching Azure AD Application with ID "aaaaaaaa-bbbb-cccc-dddd-eeeeeeeeeeee": graphrbac.ApplicationsClient#Patch: Failure responding to request: StatusCode=400 -- Original Error: autorest/azure: Service returned an error. Status=400 Code="Unknown" Message="Unknown service error" Details=[{"odata.error":{"code":"Request_BadRequest","date":"2020-06-09T10:06:21","message":{"lang":"en","value":"Request contains a property with duplicate values."},"requestId":"dab8185c-239f-44dd-8ca3-8bd13e3e67b3","values":[{"item":"PropertyName","value":"oauth2Permissions"},{"item":"PropertyErrorCode","value":"DuplicateValue"}]}}]

to this:

Error: validation failed: duplicate app_role / oauth2_permissions value found: "administer"

Closes: #269

[katbyte]

Thanks for the pr @manicminer, overall looks good, in addition to the one comment i've left inline i think it might also warrant a note in the docs? other then that LGTM 👍

[manicminer]

@katbyte Thanks! Note added to resource documentation.

[manicminer]

Test results:

[ghost]

This has been released in version 0.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.11.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!