Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azuread_application & azuread_group: Duplicate name detection #279

Merged
merged 2 commits into from
Jun 23, 2020
Merged

azuread_application & azuread_group: Duplicate name detection #279

merged 2 commits into from
Jun 23, 2020

Conversation

manicminer
Copy link
Contributor

  • New property prevent_duplicate_names, defaults to false
  • When true, searches for an existing application / group and errs if one found having the same name
  • For applications, also performs the check on update

Closes: #182, #200

@manicminer manicminer added this to the v0.11.0 milestone Jun 16, 2020
@manicminer manicminer requested a review from a team June 16, 2020 03:50
@manicminer manicminer force-pushed the duplicate-name-detection branch from be7f9ea to 6b5ef77 Compare June 16, 2020 03:52
@manicminer manicminer linked an issue Jun 16, 2020 that may be closed by this pull request
duplicate azuread_application resources are created when redeploying #200
Closed
katbyte
katbyte approved these changes Jun 16, 2020
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the location of the helper functions LGTM 👍

azuread/resource_application.go Outdated Show resolved Hide resolved
azuread/resource_application.go Outdated Show resolved Hide resolved
azuread/resource_group.go Outdated Show resolved Hide resolved
@manicminer manicminer force-pushed the duplicate-name-detection branch from 6b5ef77 to 00dfc4d Compare June 23, 2020 01:13
@manicminer manicminer force-pushed the duplicate-name-detection branch from 00dfc4d to a02ba8e Compare June 23, 2020 01:29
@manicminer
Copy link
Contributor Author

Tests pass:

Screenshot 2020-06-23 03 08 17
Screenshot 2020-06-23 03 08 02

@manicminer manicminer merged commit d2dfb01 into master Jun 23, 2020
@manicminer manicminer deleted the duplicate-name-detection branch June 23, 2020 02:19
manicminer added a commit that referenced this pull request Jun 23, 2020
@manicminer
update changelog for #279
cc525c6
@ghost
Copy link

ghost commented Jul 9, 2020

This has been released in version 0.11.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.11.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation enhancement feature/applications feature/groups size/L
Projects
None yet
Milestone
v0.11.0
2 participants
@manicminer @katbyte