Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ID format for azuread_application_certificate, azuread_application_password, azuread_service_principal_certificate, azuread_service_principal_password #264

Merged
merged 3 commits into from
Jun 5, 2020

Conversation

manicminer
Copy link
Contributor

  • New ID format inserts a string corresponding to resource type
  • Should minimise risk of UUID collision
  • FIx a bug in azuread_application where possibly nil optionalClaims was not handled

@manicminer manicminer added this to the v0.10.0 milestone Jun 4, 2020
@manicminer manicminer requested a review from a team June 4, 2020 23:13
…word, service_principal_certificate, service_principal_password, to minimise risk of uuid collision
@manicminer manicminer force-pushed the app-sp-secrets/new-id-format branch from 7761f6b to 4e9744b Compare June 4, 2020 23:14
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtm ! 👍

@manicminer
Copy link
Contributor Author

manicminer commented Jun 5, 2020

Tests pass

Screenshot 2020-06-05 17 12 16
Screenshot 2020-06-05 17 12 03

@manicminer manicminer merged commit 7e62e3e into master Jun 5, 2020
@manicminer manicminer deleted the app-sp-secrets/new-id-format branch June 5, 2020 16:20
manicminer added a commit that referenced this pull request Jun 5, 2020
@ghost
Copy link

ghost commented Jun 5, 2020

This has been released in version 0.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants