Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End date validation for azuread_application_password / azuread_service_principal_password #261

Merged
merged 3 commits into from
Jun 2, 2020

Conversation

manicminer
Copy link
Contributor

@manicminer manicminer commented May 30, 2020

As per API, perform validation at plan time. Also fix up usage example for azuread_application_password.

azuread_application_password.test: Creating...
azuread_service_principal_password.test: Creating...

Error: Error generating Service Principal Credentials for Object ID "11b9ba63-8800-4644-aa21-a427ebf176a8": one of `end_date` or `end_date_relative` must be specified

  on sp.tf line 5, in resource "azuread_service_principal_password" "test":
   5: resource "azuread_service_principal_password" "test" {

Error: Error generating Application Credentials for Object ID "cf34834b-b0ca-490a-9037-fe1002906768": one of `end_date` or `end_date_relative` must be specified

  on sp.tf line 11, in resource "azuread_application_password" "test":
  11: resource "azuread_application_password" "test" {

Fixes: #223

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer
Copy link
Contributor Author

Tests pass
Screenshot 2020-06-02 23 20 48
Screenshot 2020-06-02 23 20 59

@manicminer manicminer merged commit 911d7a5 into master Jun 2, 2020
@manicminer manicminer deleted the sp-password/end-date-validation branch June 2, 2020 22:21
manicminer added a commit that referenced this pull request Jun 2, 2020
@ghost
Copy link

ghost commented Jun 5, 2020

This has been released in version 0.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.10.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 3, 2020
tiwood pushed a commit to tiwood/terraform-provider-azuread that referenced this pull request Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azuread_service_principal_password does not check for required field end_date_relative until apply time
2 participants