data.azuread_group: name should be case insensitive

[Tbohunek]

Hi,

Why did you opt to make Azure AD group lookup case sensitive in b82e58f ?

Azure AD is in essence case-insensitive so there's no reason for such restriction.
Instead this makes it difficult to use common variables such as environment=dev if someone named the AD group group_Dev. Same for Service Principals.

Thanks for explanation,
Tomas

[katbyte]

Hey @Tbohunek, we default to case sensitivity for many reasons and have no plans to change this. One reason is if someone wanted to change the casing we wouldn't be able to. You can see the comment that prompted that to be case sensitive here: #14 (comment)

[Tbohunek]

@katbyte Thanks, but... can you at least add an optional parameter that would allow case-insensitive data lookup? I understand one would want case-sensitive with resource {} but why to need it with data {} is beyond me.

[Tbohunek]

Btw thanks for closing the issue instantly without any chance for a discussion. Maybe I misunderstood the linked comment but it tells me the only reason you do case sensitive is because you always have, not because it made sense technically nor because customers asked for it.

[tombuildsstuff]

hey @Tbohunek

Thanks for opening this issue.

Whilst certain Azure API's are case insensitive - a much larger proportion are not, meaning that since everything isn't case insensitive - by definition everything has to be treated as case sensitive.

In this instance, I'd agree this makes sense to make the Data Source case-insensitive here (but as you've mentioned leave the Resource case-sensitive) - as such I'm going to re-open this issue to track this feature request.

Thanks!

[Tbohunek]

Thanks @tombuildsstuff
Would that be possible and logical also for data {} on Service principals? Or should I open a separate Issue for that? It may generally make sense for more resource types but I can't think of any right now.
Thank you

[manicminer]

@Tbohunek I've updated the issue title to reflect the change requested. Please go ahead and open another issue if the service principal data source needs looking at too. Thanks!

[manicminer]

@Tbohunek I've implemented this in #291, however since this is a potentially breaking change this will only make it into the next major release of the provider.

[DanielFrei64]

Glad to see there is current work happening here. This is a blocker for me. Obviously it looks like we are working this for 1.0, do we have any general timeline for this? 1 month, year end, H2 2021? Just curious.

Thank you

[manicminer]

@DanielFrei64 AzureAD v1.0 should be out in a few days

[ghost]

This has been released in version 1.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 1.0.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!