Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: azuread_application - don't populate the password block unless specified in config #1422

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

manicminer
Copy link
Contributor

Avoids marking all attributes as sensitive if the entire resource is used for an output variable

Fixes: #1421

@manicminer manicminer requested a review from a team June 28, 2024 14:55
@manicminer manicminer added this to the v2.53.1 milestone Jun 28, 2024
…ck unless specified in config, to avoid marking attributes as sensitive if the entire resource is used for an output variable
@manicminer manicminer force-pushed the bugfix/application-marked-sensitive branch from 306d4b1 to 0177c80 Compare June 28, 2024 15:05
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer
Copy link
Contributor Author

Before and after:

SCR-20240628-mkk

@manicminer
Copy link
Contributor Author

Test results

Screenshot 2024-06-28 at 17 34 46

@manicminer manicminer merged commit 747c29b into main Jun 28, 2024
25 checks passed
@manicminer manicminer deleted the bugfix/application-marked-sensitive branch June 28, 2024 16:35
manicminer added a commit that referenced this pull request Jun 28, 2024
dduportal referenced this pull request in jenkins-infra/azure Jul 1, 2024
<Actions>
<action
id="6d17e7acdb2f3311576150379e22805f2f9b4aa72ff00ec136aceee45cae4b98">
        <h3>Bump Terraform `azuread` provider version</h3>
<details
id="1d9343c012f5434ac9fe8a98135bae3667b399259be16d9b14302ea3bd424a24">
            <summary>Update Terraform lock file</summary>
<p>changes detected:&#xA;&#x9;&#34;hashicorp/azuread&#34; updated from
&#34;2.53.0&#34; to &#34;2.53.1&#34; in file
&#34;.terraform.lock.hcl&#34;</p>
            <details>
                <summary>2.53.1</summary>
<pre>Changelog retrieved
from:&#xA;&#x9;https://github.com/hashicorp/terraform-provider-azuread/releases/tag/v2.53.1&#xA;BUG
FIXES:&#xA;&#xA;* `azuread_application` - export the `password`
attribute only when it is set in configuration, to prevent marking
existing resources as sensitive
([#1422](https://github.com/hashicorp/terraform-provider-azuread/issues/1422))&#xA;&#xA;&#xA;</pre>
            </details>
        </details>
<a
href="https://infra.ci.jenkins.io/job/updatecli/job/azure/job/main/289/">Jenkins
pipeline link</a>
    </action>
</Actions>

---

<table>
  <tr>
    <td width="77">
<img src="https://www.updatecli.io/images/updatecli.png" alt="Updatecli
logo" width="50" height="50">
    </td>
    <td>
      <p>
Created automatically by <a
href="https://www.updatecli.io/">Updatecli</a>
      </p>
      <details><summary>Options:</summary>
        <br />
<p>Most of Updatecli configuration is done via <a
href="https://www.updatecli.io/docs/prologue/quick-start/">its
manifest(s)</a>.</p>
        <ul>
<li>If you close this pull request, Updatecli will automatically reopen
it, the next time it runs.</li>
<li>If you close this pull request and delete the base branch, Updatecli
will automatically recreate it, erasing all previous commits made.</li>
        </ul>
        <p>
Feel free to report any issues at <a
href="https://github.com/updatecli/updatecli/issues">github.com/updatecli/updatecli</a>.<br
/>
If you find this tool useful, do not hesitate to star <a
href="https://github.com/updatecli/updatecli/stargazers">our GitHub
repository</a> as a sign of appreciation, and/or to tell us directly on
our <a
href="https://matrix.to/#/#Updatecli_community:gitter.im">chat</a>!
        </p>
      </details>
    </td>
  </tr>
</table>

Co-authored-by: Jenkins Infra Bot (updatecli) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants