New resource: aws_apigatewayv2_deployment #9245

ewbankkit · 2019-07-05T13:24:58Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Another resource for #7004.

Release note for CHANGELOG:

FEATURES:

* New Resource: aws_api_gateway_v2_deployment (#7004)

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Deployment_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Deployment_basic -timeout 120m
=== RUN   TestAccAWSAPIGateway2Deployment_basic
=== PAUSE TestAccAWSAPIGateway2Deployment_basic
=== CONT  TestAccAWSAPIGateway2Deployment_basic
--- PASS: TestAccAWSAPIGateway2Deployment_basic (40.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.558s

Currently based on #8842, will need to rebase once that PR is merged.

ewbankkit · 2019-07-13T22:09:41Z

Includes

New resource: aws_apigatewayv2_route #8881 for aws_api_gateway_v2_route tests

ewbankkit · 2019-07-14T21:48:56Z

Be aware of #162.
Does the same thing happen for WebSocket APIs?

ewbankkit · 2019-07-26T21:05:21Z

Rebased to fix merge conflict.
Acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Deployment_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Deployment_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Deployment_basic
=== PAUSE TestAccAWSAPIGateway2Deployment_basic
=== CONT  TestAccAWSAPIGateway2Deployment_basic
--- PASS: TestAccAWSAPIGateway2Deployment_basic (41.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	41.540s

ewbankkit · 2019-08-16T18:04:56Z

Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGateway2Deployment_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -parallel 20 -run=TestAccAWSAPIGateway2Deployment_ -timeout 120m
=== RUN   TestAccAWSAPIGateway2Deployment_basic
=== PAUSE TestAccAWSAPIGateway2Deployment_basic
=== CONT  TestAccAWSAPIGateway2Deployment_basic
--- PASS: TestAccAWSAPIGateway2Deployment_basic (45.79s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	45.810s

rpstreef · 2019-10-22T06:04:02Z

So this is now lying dormant for months, I know I'm busting your balls on this but we really need to get this going.

What is holding this back? I'm seeing release notes for issues that are getting a release with a far lower priority.

ewbankkit · 2020-04-15T12:28:56Z

After merge of #8881, incorporate all the feedback:

Migrate to Terraform provider SDK
Change resource name to aws_apigatewayv2_blah; Rename source files
Remove sidebar_current from documentation
Add subcategory: "API Gateway v2 (WebSocket and HTTP APIs)" to documentation
Change function names to ApiGatewayV2
Add _disappears acceptance test
Use multierror in any test sweeper

ewbankkit · 2020-04-15T17:34:55Z

Renamed resource to aws_apigatewayv2_deployment.
Waiter added following pattern established in #12765.
Re-ran acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSAPIGatewayV2Deployment_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws/ -v -count 1 -parallel 20 -run=TestAccAWSAPIGatewayV2Deployment_ -timeout 120m
=== RUN   TestAccAWSAPIGatewayV2Deployment_basic
=== PAUSE TestAccAWSAPIGatewayV2Deployment_basic
=== RUN   TestAccAWSAPIGatewayV2Deployment_disappears
=== PAUSE TestAccAWSAPIGatewayV2Deployment_disappears
=== CONT  TestAccAWSAPIGatewayV2Deployment_basic
=== CONT  TestAccAWSAPIGatewayV2Deployment_disappears
--- PASS: TestAccAWSAPIGatewayV2Deployment_disappears (28.85s)
--- PASS: TestAccAWSAPIGatewayV2Deployment_basic (52.03s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	52.080s

ewbankkit · 2020-04-15T17:55:22Z

Ready for review.

gdavison

One comment, otherwise LGTM 🚀

--- PASS: TestAccAWSAPIGatewayV2Deployment_disappears (10.72s)
--- PASS: TestAccAWSAPIGatewayV2Deployment_basic (17.94s)

gdavison · 2020-04-15T18:53:36Z

aws/internal/service/apigatewayv2/waiter/waiter.go

+
+	outputRaw, err := stateConf.WaitForState()
+
+	switch output := outputRaw.(type) {


Since there are only two possibilities, would if v, ok := outputRaw.(*apigatewayv2.GetDeploymentOutput); ok { ... } work better here?

I based the code on the original PR - https://github.com/terraform-providers/terraform-provider-aws/pull/12765/files#diff-51328917bb577dc7dd98f1ece91ed566R26-R31 but have no strong opinion.

On implementation, your suggestions seems more maintainable.
I made the change.

gdavison · 2020-04-15T18:56:47Z

aws/resource_aws_apigatewayv2_deployment_test.go

+	}
+}
+
+func testAccCheckAWSAPIGatewayV2DeploymentExists(n string, vApiId *string, v *apigatewayv2.GetDeploymentOutput) resource.TestCheckFunc {


I like how in this and your other PRs you've added returning the ID to our existing pattern of returning the object.

The returned objects don't include all the necessary information to be able to identify the resource which is different from other AWS APIs.

Ah, I see. It's a minor convenience/cosmetic thing, but I've seen a number of use cases where it would be handy, or at least meaning fewer dereferences :)

ghost · 2020-04-17T00:44:52Z

This has been released in version 2.58.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

ghost · 2020-05-16T17:10:25Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

ewbankkit requested a review from a team July 5, 2019 13:24

ewbankkit mentioned this pull request Jul 5, 2019

API Gateway- Websocket #7004

Closed

ghost added size/XXL Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 13, 2019

ewbankkit changed the title ~~[WIP] New resource: aws_api_gateway_v2_deployment~~ New resource: aws_api_gateway_v2_deployment Jul 13, 2019

ewbankkit mentioned this pull request Jul 13, 2019

New resource: aws_apigatewayv2_stage #9232

Merged

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_deployment branch 2 times, most recently from 421835c to 48a5eae Compare July 26, 2019 21:16

aeschright added the new-resource Introduces a new resource. label Aug 19, 2019

ewbankkit mentioned this pull request Mar 14, 2020

Amazon API Gateway HTTP APIs #11148

Closed

bflad removed the service/apigateway Issues and PRs that pertain to the apigateway service. label Apr 15, 2020

ewbankkit changed the title ~~New resource: aws_api_gateway_v2_deployment~~ New resource: aws_apigatewayv2_deployment Apr 15, 2020

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_deployment branch from 6cb96f1 to 36c00bd Compare April 15, 2020 16:16

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_deployment branch from 0878c7b to 166b6ac Compare April 15, 2020 17:38

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/XXL Managed by automation to categorize the size of a PR. labels Apr 15, 2020

Add 'aws_api_gateway2_deployment' resource.

3b47041

ewbankkit added 2 commits April 15, 2020 13:45

Rename resource to 'aws_apigatewayv2_deployment'.

14a2008

Add deployment status waiter.

bb318d6

ewbankkit force-pushed the issue-7004.aws_api_gateway_v2_deployment branch from 166b6ac to bb318d6 Compare April 15, 2020 17:45

gdavison approved these changes Apr 15, 2020

View reviewed changes

gdavison added this to the v2.58.0 milestone Apr 15, 2020

Change after review.

c0fe074

gdavison merged commit a3eb0a6 into hashicorp:master Apr 15, 2020

gdavison added a commit that referenced this pull request Apr 15, 2020

Update CHANGELOG for #9245

ed4346d

ewbankkit deleted the issue-7004.aws_api_gateway_v2_deployment branch April 16, 2020 10:33

ghost locked and limited conversation to collaborators May 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: aws_apigatewayv2_deployment #9245

New resource: aws_apigatewayv2_deployment #9245

ewbankkit commented Jul 5, 2019 •

edited

Loading

ewbankkit commented Jul 13, 2019

ewbankkit commented Jul 14, 2019

ewbankkit commented Jul 26, 2019

ewbankkit commented Aug 16, 2019

rpstreef commented Oct 22, 2019

ewbankkit commented Apr 15, 2020

ewbankkit commented Apr 15, 2020

ewbankkit commented Apr 15, 2020

gdavison left a comment

gdavison Apr 15, 2020

ewbankkit Apr 15, 2020

ewbankkit Apr 15, 2020

gdavison Apr 15, 2020

ewbankkit Apr 15, 2020

gdavison Apr 15, 2020

ghost commented Apr 17, 2020

ghost commented May 16, 2020


		outputRaw, err := stateConf.WaitForState()

		switch output := outputRaw.(type) {

New resource: aws_apigatewayv2_deployment #9245

New resource: aws_apigatewayv2_deployment #9245

Conversation

ewbankkit commented Jul 5, 2019 • edited Loading

Community Note

ewbankkit commented Jul 13, 2019

ewbankkit commented Jul 14, 2019

ewbankkit commented Jul 26, 2019

ewbankkit commented Aug 16, 2019

rpstreef commented Oct 22, 2019

ewbankkit commented Apr 15, 2020

ewbankkit commented Apr 15, 2020

ewbankkit commented Apr 15, 2020

gdavison left a comment

Choose a reason for hiding this comment

gdavison Apr 15, 2020

Choose a reason for hiding this comment

ewbankkit Apr 15, 2020

Choose a reason for hiding this comment

ewbankkit Apr 15, 2020

Choose a reason for hiding this comment

gdavison Apr 15, 2020

Choose a reason for hiding this comment

ewbankkit Apr 15, 2020

Choose a reason for hiding this comment

gdavison Apr 15, 2020

Choose a reason for hiding this comment

ghost commented Apr 17, 2020

ghost commented May 16, 2020

ewbankkit commented Jul 5, 2019 •

edited

Loading