Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/resource/aws_ecr_lifecycle_policy: Add note that only one resource can be used with the same ECR repository #6216

Merged
merged 1 commit into from
Oct 30, 2018
Merged

docs/resource/aws_ecr_lifecycle_policy: Add note that only one resource can be used with the same ECR repository #6216

merged 1 commit into from
Oct 30, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Oct 19, 2018

Reference: #6212

At some point in the future we can introduce a data source, similar to aws_iam_policy_document, that can support better handling of the policy JSON (e.g. combining rules, validation, etc.).

Changes proposed in this pull request:

  • Add note about multiple aws_ecr_lifecycle_policy against the same repository
  • Move note about rulePriority to the top as well.

Output from acceptance testing: N/A

@bflad bflad added documentation Introduces or discusses updates to documentation. service/ecr Issues and PRs that pertain to the ecr service. labels Oct 19, 2018
@bflad bflad requested a review from a team October 19, 2018 15:00
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label Oct 19, 2018
tombuildsstuff
tombuildsstuff approved these changes Oct 30, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bflad bflad added this to the v1.42.0 milestone Oct 30, 2018
@bflad bflad merged commit dda5541 into master Oct 30, 2018
@bflad bflad deleted the d-aws_ecr_lifecycle_policy-conflict branch October 30, 2018 14:52
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ecr Issues and PRs that pertain to the ecr service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v1.42.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bflad @tombuildsstuff