Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Redshift resources to AWS SDK v2 #38892

Merged
merged 267 commits into from
Aug 16, 2024

Conversation

DanielRieske
Copy link
Contributor

Description

This PR migrates the remaining Redshift resources to AWS SDKv2.

Relations

Closes #36201
Relates #32976

References

Output from Acceptance Testing

Currently running tests overnight - will update results soon

% make testacc TESTS=TestAccXXX PKG=ec2

...

@DanielRieske DanielRieske requested a review from a team as a code owner August 15, 2024 21:45
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/redshift Issues and PRs that pertain to the redshift service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Aug 15, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Aug 16, 2024
@ewbankkit ewbankkit self-assigned this Aug 16, 2024
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccRedshift' PKG=redshift ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/redshift/... -v -count 1 -parallel 4  -run=TestAccRedshift -timeout 720m
=== RUN   TestAccRedshiftAuthenticationProfile_basic
=== PAUSE TestAccRedshiftAuthenticationProfile_basic
=== RUN   TestAccRedshiftAuthenticationProfile_disappears
=== PAUSE TestAccRedshiftAuthenticationProfile_disappears
=== RUN   TestAccRedshiftClusterCredentialsDataSource_basic
=== PAUSE TestAccRedshiftClusterCredentialsDataSource_basic
=== RUN   TestAccRedshiftClusterDataSource_basic
=== PAUSE TestAccRedshiftClusterDataSource_basic
=== RUN   TestAccRedshiftClusterDataSource_vpc
=== PAUSE TestAccRedshiftClusterDataSource_vpc
=== RUN   TestAccRedshiftClusterDataSource_logging
=== PAUSE TestAccRedshiftClusterDataSource_logging
=== RUN   TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== PAUSE TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== RUN   TestAccRedshiftClusterDataSource_multiAZEnabled
=== PAUSE TestAccRedshiftClusterDataSource_multiAZEnabled
=== RUN   TestAccRedshiftClusterIAMRoles_basic
=== PAUSE TestAccRedshiftClusterIAMRoles_basic
=== RUN   TestAccRedshiftClusterIAMRoles_disappears
=== PAUSE TestAccRedshiftClusterIAMRoles_disappears
=== RUN   TestAccRedshiftClusterSnapshot_basic
=== PAUSE TestAccRedshiftClusterSnapshot_basic
=== RUN   TestAccRedshiftClusterSnapshot_tags
=== PAUSE TestAccRedshiftClusterSnapshot_tags
=== RUN   TestAccRedshiftClusterSnapshot_disappears
=== PAUSE TestAccRedshiftClusterSnapshot_disappears
=== RUN   TestAccRedshiftCluster_basic
=== PAUSE TestAccRedshiftCluster_basic
=== RUN   TestAccRedshiftCluster_aqua
=== PAUSE TestAccRedshiftCluster_aqua
=== RUN   TestAccRedshiftCluster_disappears
=== PAUSE TestAccRedshiftCluster_disappears
=== RUN   TestAccRedshiftCluster_withFinalSnapshot
=== PAUSE TestAccRedshiftCluster_withFinalSnapshot
=== RUN   TestAccRedshiftCluster_kmsKey
=== PAUSE TestAccRedshiftCluster_kmsKey
=== RUN   TestAccRedshiftCluster_enhancedVPCRoutingEnabled
=== PAUSE TestAccRedshiftCluster_enhancedVPCRoutingEnabled
=== RUN   TestAccRedshiftCluster_loggingEnabled
=== PAUSE TestAccRedshiftCluster_loggingEnabled
=== RUN   TestAccRedshiftCluster_snapshotCopy
=== PAUSE TestAccRedshiftCluster_snapshotCopy
=== RUN   TestAccRedshiftCluster_iamRoles
=== PAUSE TestAccRedshiftCluster_iamRoles
=== RUN   TestAccRedshiftCluster_publiclyAccessible
=== PAUSE TestAccRedshiftCluster_publiclyAccessible
=== RUN   TestAccRedshiftCluster_updateNodeCount
=== PAUSE TestAccRedshiftCluster_updateNodeCount
=== RUN   TestAccRedshiftCluster_updateNodeType
=== PAUSE TestAccRedshiftCluster_updateNodeType
=== RUN   TestAccRedshiftCluster_tags
=== PAUSE TestAccRedshiftCluster_tags
=== RUN   TestAccRedshiftCluster_forceNewUsername
=== PAUSE TestAccRedshiftCluster_forceNewUsername
=== RUN   TestAccRedshiftCluster_changeAvailabilityZone
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZone
=== RUN   TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
=== RUN   TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
=== PAUSE TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
=== RUN   TestAccRedshiftCluster_changeEncryption1
=== PAUSE TestAccRedshiftCluster_changeEncryption1
=== RUN   TestAccRedshiftCluster_changeEncryption2
=== PAUSE TestAccRedshiftCluster_changeEncryption2
=== RUN   TestAccRedshiftCluster_availabilityZoneRelocation
=== PAUSE TestAccRedshiftCluster_availabilityZoneRelocation
=== RUN   TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
=== PAUSE TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
=== RUN   TestAccRedshiftCluster_restoreFromSnapshot
=== PAUSE TestAccRedshiftCluster_restoreFromSnapshot
=== RUN   TestAccRedshiftCluster_restoreFromSnapshotARN
=== PAUSE TestAccRedshiftCluster_restoreFromSnapshotARN
=== RUN   TestAccRedshiftCluster_manageMasterPassword
=== PAUSE TestAccRedshiftCluster_manageMasterPassword
=== RUN   TestAccRedshiftCluster_multiAZ
=== PAUSE TestAccRedshiftCluster_multiAZ
=== RUN   TestAccRedshiftDataShareAuthorization_basic
=== PAUSE TestAccRedshiftDataShareAuthorization_basic
=== RUN   TestAccRedshiftDataShareAuthorization_disappears
=== PAUSE TestAccRedshiftDataShareAuthorization_disappears
=== RUN   TestAccRedshiftDataShareConsumerAssociation_basic
=== PAUSE TestAccRedshiftDataShareConsumerAssociation_basic
=== RUN   TestAccRedshiftDataShareConsumerAssociation_disappears
=== PAUSE TestAccRedshiftDataShareConsumerAssociation_disappears
=== RUN   TestAccRedshiftDataShareConsumerAssociation_associateEntireAccount
=== PAUSE TestAccRedshiftDataShareConsumerAssociation_associateEntireAccount
=== RUN   TestAccRedshiftDataSharesDataSource_basic
=== PAUSE TestAccRedshiftDataSharesDataSource_basic
=== RUN   TestAccRedshiftEndpointAccess_basic
=== PAUSE TestAccRedshiftEndpointAccess_basic
=== RUN   TestAccRedshiftEndpointAccess_sgs
=== PAUSE TestAccRedshiftEndpointAccess_sgs
=== RUN   TestAccRedshiftEndpointAccess_disappears
=== PAUSE TestAccRedshiftEndpointAccess_disappears
=== RUN   TestAccRedshiftEndpointAccess_disappears_cluster
=== PAUSE TestAccRedshiftEndpointAccess_disappears_cluster
=== RUN   TestAccRedshiftEndpointAuthorization_basic
=== PAUSE TestAccRedshiftEndpointAuthorization_basic
=== RUN   TestAccRedshiftEndpointAuthorization_vpcs
=== PAUSE TestAccRedshiftEndpointAuthorization_vpcs
=== RUN   TestAccRedshiftEndpointAuthorization_disappears
=== PAUSE TestAccRedshiftEndpointAuthorization_disappears
=== RUN   TestAccRedshiftEndpointAuthorization_disappears_cluster
=== PAUSE TestAccRedshiftEndpointAuthorization_disappears_cluster
=== RUN   TestAccRedshiftEventSubscription_basic
=== PAUSE TestAccRedshiftEventSubscription_basic
=== RUN   TestAccRedshiftEventSubscription_withSourceIDs
=== PAUSE TestAccRedshiftEventSubscription_withSourceIDs
=== RUN   TestAccRedshiftEventSubscription_categoryUpdate
=== PAUSE TestAccRedshiftEventSubscription_categoryUpdate
=== RUN   TestAccRedshiftEventSubscription_tags
=== PAUSE TestAccRedshiftEventSubscription_tags
=== RUN   TestAccRedshiftEventSubscription_disappears
=== PAUSE TestAccRedshiftEventSubscription_disappears
=== RUN   TestAccRedshiftHSMClientCertificate_basic
=== PAUSE TestAccRedshiftHSMClientCertificate_basic
=== RUN   TestAccRedshiftHSMClientCertificate_tags
=== PAUSE TestAccRedshiftHSMClientCertificate_tags
=== RUN   TestAccRedshiftHSMClientCertificate_disappears
=== PAUSE TestAccRedshiftHSMClientCertificate_disappears
=== RUN   TestAccRedshiftHSMConfiguration_basic
=== PAUSE TestAccRedshiftHSMConfiguration_basic
=== RUN   TestAccRedshiftHSMConfiguration_tags
=== PAUSE TestAccRedshiftHSMConfiguration_tags
=== RUN   TestAccRedshiftHSMConfiguration_disappears
=== PAUSE TestAccRedshiftHSMConfiguration_disappears
=== RUN   TestAccRedshiftLogging_basic
=== PAUSE TestAccRedshiftLogging_basic
=== RUN   TestAccRedshiftLogging_disappears
=== PAUSE TestAccRedshiftLogging_disappears
=== RUN   TestAccRedshiftLogging_disappears_Cluster
=== PAUSE TestAccRedshiftLogging_disappears_Cluster
=== RUN   TestAccRedshiftLogging_s3
=== PAUSE TestAccRedshiftLogging_s3
=== RUN   TestAccRedshiftOrderableClusterDataSource_clusterType
=== PAUSE TestAccRedshiftOrderableClusterDataSource_clusterType
=== RUN   TestAccRedshiftOrderableClusterDataSource_clusterVersion
=== PAUSE TestAccRedshiftOrderableClusterDataSource_clusterVersion
=== RUN   TestAccRedshiftOrderableClusterDataSource_nodeType
=== PAUSE TestAccRedshiftOrderableClusterDataSource_nodeType
=== RUN   TestAccRedshiftOrderableClusterDataSource_preferredNodeTypes
=== PAUSE TestAccRedshiftOrderableClusterDataSource_preferredNodeTypes
=== RUN   TestAccRedshiftParameterGroup_basic
=== PAUSE TestAccRedshiftParameterGroup_basic
=== RUN   TestAccRedshiftParameterGroup_disappears
=== PAUSE TestAccRedshiftParameterGroup_disappears
=== RUN   TestAccRedshiftParameterGroup_update
=== PAUSE TestAccRedshiftParameterGroup_update
=== RUN   TestAccRedshiftParameterGroup_tags
=== PAUSE TestAccRedshiftParameterGroup_tags
=== RUN   TestAccRedshiftPartner_basic
=== PAUSE TestAccRedshiftPartner_basic
=== RUN   TestAccRedshiftPartner_disappears
=== PAUSE TestAccRedshiftPartner_disappears
=== RUN   TestAccRedshiftPartner_disappears_cluster
=== PAUSE TestAccRedshiftPartner_disappears_cluster
=== RUN   TestAccRedshiftProducerDataSharesDataSource_basic
=== PAUSE TestAccRedshiftProducerDataSharesDataSource_basic
=== RUN   TestAccRedshiftResourcePolicy_basic
=== PAUSE TestAccRedshiftResourcePolicy_basic
=== RUN   TestAccRedshiftResourcePolicy_disappears
=== PAUSE TestAccRedshiftResourcePolicy_disappears
=== RUN   TestAccRedshiftScheduledAction_basicPauseCluster
=== PAUSE TestAccRedshiftScheduledAction_basicPauseCluster
=== RUN   TestAccRedshiftScheduledAction_pauseClusterWithOptions
=== PAUSE TestAccRedshiftScheduledAction_pauseClusterWithOptions
=== RUN   TestAccRedshiftScheduledAction_basicResumeCluster
=== PAUSE TestAccRedshiftScheduledAction_basicResumeCluster
=== RUN   TestAccRedshiftScheduledAction_basicResizeCluster
=== PAUSE TestAccRedshiftScheduledAction_basicResizeCluster
=== RUN   TestAccRedshiftScheduledAction_resizeClusterWithOptions
=== PAUSE TestAccRedshiftScheduledAction_resizeClusterWithOptions
=== RUN   TestAccRedshiftScheduledAction_disappears
=== PAUSE TestAccRedshiftScheduledAction_disappears
=== RUN   TestAccRedshiftScheduledAction_validScheduleName
=== PAUSE TestAccRedshiftScheduledAction_validScheduleName
=== RUN   TestAccRedshiftSnapshotCopyGrant_basic
=== PAUSE TestAccRedshiftSnapshotCopyGrant_basic
=== RUN   TestAccRedshiftSnapshotCopyGrant_disappears
=== PAUSE TestAccRedshiftSnapshotCopyGrant_disappears
=== RUN   TestAccRedshiftSnapshotCopyGrant_tags
=== PAUSE TestAccRedshiftSnapshotCopyGrant_tags
=== RUN   TestAccRedshiftSnapshotCopy_basic
=== PAUSE TestAccRedshiftSnapshotCopy_basic
=== RUN   TestAccRedshiftSnapshotCopy_disappears
=== PAUSE TestAccRedshiftSnapshotCopy_disappears
=== RUN   TestAccRedshiftSnapshotCopy_disappears_Cluster
=== PAUSE TestAccRedshiftSnapshotCopy_disappears_Cluster
=== RUN   TestAccRedshiftSnapshotCopy_retentionPeriod
=== PAUSE TestAccRedshiftSnapshotCopy_retentionPeriod
=== RUN   TestAccRedshiftSnapshotScheduleAssociation_basic
=== PAUSE TestAccRedshiftSnapshotScheduleAssociation_basic
=== RUN   TestAccRedshiftSnapshotScheduleAssociation_disappears
=== PAUSE TestAccRedshiftSnapshotScheduleAssociation_disappears
=== RUN   TestAccRedshiftSnapshotScheduleAssociation_disappears_cluster
=== PAUSE TestAccRedshiftSnapshotScheduleAssociation_disappears_cluster
=== RUN   TestAccRedshiftSnapshotSchedule_basic
=== PAUSE TestAccRedshiftSnapshotSchedule_basic
=== RUN   TestAccRedshiftSnapshotSchedule_disappears
=== PAUSE TestAccRedshiftSnapshotSchedule_disappears
=== RUN   TestAccRedshiftSnapshotSchedule_tags
=== PAUSE TestAccRedshiftSnapshotSchedule_tags
=== RUN   TestAccRedshiftSnapshotSchedule_identifierGenerated
=== PAUSE TestAccRedshiftSnapshotSchedule_identifierGenerated
=== RUN   TestAccRedshiftSnapshotSchedule_identifierPrefix
=== PAUSE TestAccRedshiftSnapshotSchedule_identifierPrefix
=== RUN   TestAccRedshiftSnapshotSchedule_update
=== PAUSE TestAccRedshiftSnapshotSchedule_update
=== RUN   TestAccRedshiftSnapshotSchedule_withDescription
=== PAUSE TestAccRedshiftSnapshotSchedule_withDescription
=== RUN   TestAccRedshiftSnapshotSchedule_withForceDestroy
=== PAUSE TestAccRedshiftSnapshotSchedule_withForceDestroy
=== RUN   TestAccRedshiftSubnetGroupDataSource_basic
=== PAUSE TestAccRedshiftSubnetGroupDataSource_basic
=== RUN   TestAccRedshiftSubnetGroup_basic
=== PAUSE TestAccRedshiftSubnetGroup_basic
=== RUN   TestAccRedshiftSubnetGroup_disappears
=== PAUSE TestAccRedshiftSubnetGroup_disappears
=== RUN   TestAccRedshiftSubnetGroup_updateDescription
=== PAUSE TestAccRedshiftSubnetGroup_updateDescription
=== RUN   TestAccRedshiftSubnetGroup_updateSubnetIDs
=== PAUSE TestAccRedshiftSubnetGroup_updateSubnetIDs
=== RUN   TestAccRedshiftSubnetGroup_tags
=== PAUSE TestAccRedshiftSubnetGroup_tags
=== RUN   TestAccRedshiftUsageLimit_basic
=== PAUSE TestAccRedshiftUsageLimit_basic
=== RUN   TestAccRedshiftUsageLimit_tags
=== PAUSE TestAccRedshiftUsageLimit_tags
=== RUN   TestAccRedshiftUsageLimit_disappears
=== PAUSE TestAccRedshiftUsageLimit_disappears
=== CONT  TestAccRedshiftAuthenticationProfile_basic
=== CONT  TestAccRedshiftSnapshotCopy_disappears_Cluster
=== CONT  TestAccRedshiftEndpointAccess_disappears_cluster
=== CONT  TestAccRedshiftSnapshotSchedule_withDescription
--- PASS: TestAccRedshiftSnapshotSchedule_withDescription (12.54s)
=== CONT  TestAccRedshiftSubnetGroup_updateSubnetIDs
--- PASS: TestAccRedshiftAuthenticationProfile_basic (19.08s)
=== CONT  TestAccRedshiftUsageLimit_disappears
--- PASS: TestAccRedshiftSubnetGroup_updateSubnetIDs (31.79s)
=== CONT  TestAccRedshiftUsageLimit_tags
--- PASS: TestAccRedshiftSnapshotCopy_disappears_Cluster (167.84s)
=== CONT  TestAccRedshiftUsageLimit_basic
--- PASS: TestAccRedshiftUsageLimit_disappears (155.11s)
=== CONT  TestAccRedshiftSubnetGroup_tags
--- PASS: TestAccRedshiftSubnetGroup_tags (39.19s)
=== CONT  TestAccRedshiftSnapshotSchedule_disappears
--- PASS: TestAccRedshiftSnapshotSchedule_disappears (9.34s)
=== CONT  TestAccRedshiftSnapshotSchedule_update
--- PASS: TestAccRedshiftUsageLimit_tags (185.47s)
=== CONT  TestAccRedshiftSnapshotSchedule_identifierPrefix
--- PASS: TestAccRedshiftSnapshotSchedule_identifierPrefix (10.62s)
=== CONT  TestAccRedshiftSnapshotSchedule_identifierGenerated
--- PASS: TestAccRedshiftSnapshotSchedule_update (23.56s)
=== CONT  TestAccRedshiftSnapshotSchedule_tags
--- PASS: TestAccRedshiftSnapshotSchedule_identifierGenerated (10.80s)
=== CONT  TestAccRedshiftSubnetGroup_basic
--- PASS: TestAccRedshiftSubnetGroup_basic (19.18s)
=== CONT  TestAccRedshiftSubnetGroup_updateDescription
--- PASS: TestAccRedshiftSnapshotSchedule_tags (24.42s)
=== CONT  TestAccRedshiftSubnetGroup_disappears
--- PASS: TestAccRedshiftSubnetGroup_disappears (16.62s)
=== CONT  TestAccRedshiftSnapshotScheduleAssociation_basic
--- PASS: TestAccRedshiftEndpointAccess_disappears_cluster (300.64s)
=== CONT  TestAccRedshiftSnapshotSchedule_basic
--- PASS: TestAccRedshiftSubnetGroup_updateDescription (30.29s)
=== CONT  TestAccRedshiftSnapshotScheduleAssociation_disappears
--- PASS: TestAccRedshiftSnapshotSchedule_basic (11.70s)
=== CONT  TestAccRedshiftSnapshotCopy_retentionPeriod
--- PASS: TestAccRedshiftUsageLimit_basic (177.04s)
=== CONT  TestAccRedshiftSnapshotScheduleAssociation_disappears_cluster
--- PASS: TestAccRedshiftSnapshotCopy_retentionPeriod (169.75s)
=== CONT  TestAccRedshiftCluster_updateNodeType
--- PASS: TestAccRedshiftSnapshotScheduleAssociation_disappears (185.70s)
=== CONT  TestAccRedshiftSubnetGroupDataSource_basic
--- PASS: TestAccRedshiftSubnetGroupDataSource_basic (16.49s)
=== CONT  TestAccRedshiftEndpointAccess_disappears
--- PASS: TestAccRedshiftSnapshotScheduleAssociation_basic (218.49s)
=== CONT  TestAccRedshiftCluster_restoreFromSnapshotARN
--- PASS: TestAccRedshiftSnapshotScheduleAssociation_disappears_cluster (259.59s)
=== CONT  TestAccRedshiftCluster_restoreFromSnapshot
--- PASS: TestAccRedshiftEndpointAccess_disappears (342.97s)
=== CONT  TestAccRedshiftEndpointAccess_sgs
--- PASS: TestAccRedshiftCluster_restoreFromSnapshot (479.69s)
=== CONT  TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation_publiclyAccessible (174.24s)
=== CONT  TestAccRedshiftEndpointAccess_basic
--- PASS: TestAccRedshiftCluster_restoreFromSnapshotARN (795.89s)
=== CONT  TestAccRedshiftCluster_availabilityZoneRelocation
--- PASS: TestAccRedshiftEndpointAccess_sgs (462.39s)
=== CONT  TestAccRedshiftDataSharesDataSource_basic
--- PASS: TestAccRedshiftEndpointAccess_basic (313.12s)
=== CONT  TestAccRedshiftCluster_changeEncryption2
--- PASS: TestAccRedshiftCluster_availabilityZoneRelocation (334.48s)
=== CONT  TestAccRedshiftDataShareConsumerAssociation_associateEntireAccount
--- PASS: TestAccRedshiftDataSharesDataSource_basic (389.59s)
=== CONT  TestAccRedshiftCluster_changeEncryption1
--- PASS: TestAccRedshiftDataShareConsumerAssociation_associateEntireAccount (303.05s)
=== CONT  TestAccRedshiftDataShareConsumerAssociation_disappears
--- PASS: TestAccRedshiftCluster_updateNodeType (1496.70s)
=== CONT  TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone_availabilityZoneRelocationNotSet (208.78s)
=== CONT  TestAccRedshiftDataShareConsumerAssociation_basic
--- PASS: TestAccRedshiftDataShareConsumerAssociation_disappears (331.75s)
=== CONT  TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation
--- PASS: TestAccRedshiftDataShareConsumerAssociation_basic (344.05s)
=== CONT  TestAccRedshiftDataShareAuthorization_disappears
--- PASS: TestAccRedshiftCluster_changeAvailabilityZoneAndSetAvailabilityZoneRelocation (285.65s)
=== CONT  TestAccRedshiftCluster_changeAvailabilityZone
--- PASS: TestAccRedshiftCluster_changeEncryption1 (871.22s)
=== CONT  TestAccRedshiftDataShareAuthorization_basic
--- PASS: TestAccRedshiftCluster_changeEncryption2 (1009.41s)
=== CONT  TestAccRedshiftCluster_forceNewUsername
--- PASS: TestAccRedshiftCluster_changeAvailabilityZone (380.39s)
=== CONT  TestAccRedshiftCluster_multiAZ
--- PASS: TestAccRedshiftDataShareAuthorization_basic (375.26s)
=== CONT  TestAccRedshiftClusterSnapshot_disappears
--- PASS: TestAccRedshiftCluster_forceNewUsername (392.23s)
=== CONT  TestAccRedshiftCluster_tags
--- PASS: TestAccRedshiftDataShareAuthorization_disappears (453.38s)
=== CONT  TestAccRedshiftCluster_manageMasterPassword
--- PASS: TestAccRedshiftCluster_manageMasterPassword (157.46s)
=== CONT  TestAccRedshiftCluster_updateNodeCount
--- PASS: TestAccRedshiftCluster_tags (196.79s)
=== CONT  TestAccRedshiftSnapshotSchedule_withForceDestroy
--- PASS: TestAccRedshiftClusterSnapshot_disappears (286.10s)
=== CONT  TestAccRedshiftCluster_publiclyAccessible
--- PASS: TestAccRedshiftCluster_multiAZ (549.03s)
=== CONT  TestAccRedshiftOrderableClusterDataSource_preferredNodeTypes
--- PASS: TestAccRedshiftOrderableClusterDataSource_preferredNodeTypes (7.79s)
=== CONT  TestAccRedshiftSnapshotCopy_disappears
--- PASS: TestAccRedshiftSnapshotCopy_disappears (178.36s)
=== CONT  TestAccRedshiftCluster_snapshotCopy
--- PASS: TestAccRedshiftSnapshotSchedule_withForceDestroy (564.80s)
=== CONT  TestAccRedshiftHSMClientCertificate_disappears
--- PASS: TestAccRedshiftHSMClientCertificate_disappears (9.66s)
=== CONT  TestAccRedshiftCluster_loggingEnabled
--- PASS: TestAccRedshiftCluster_publiclyAccessible (561.48s)
=== CONT  TestAccRedshiftCluster_enhancedVPCRoutingEnabled
--- PASS: TestAccRedshiftCluster_snapshotCopy (172.47s)
=== CONT  TestAccRedshiftCluster_iamRoles
--- PASS: TestAccRedshiftCluster_loggingEnabled (193.98s)
=== CONT  TestAccRedshiftCluster_kmsKey
--- PASS: TestAccRedshiftCluster_iamRoles (181.73s)
=== CONT  TestAccRedshiftLogging_disappears
--- PASS: TestAccRedshiftCluster_enhancedVPCRoutingEnabled (288.55s)
=== CONT  TestAccRedshiftLogging_basic
--- PASS: TestAccRedshiftCluster_kmsKey (237.44s)
=== CONT  TestAccRedshiftLogging_disappears_Cluster
--- PASS: TestAccRedshiftLogging_disappears (165.50s)
=== CONT  TestAccRedshiftHSMConfiguration_disappears
--- PASS: TestAccRedshiftHSMConfiguration_disappears (9.43s)
=== CONT  TestAccRedshiftOrderableClusterDataSource_nodeType
--- PASS: TestAccRedshiftOrderableClusterDataSource_nodeType (7.83s)
=== CONT  TestAccRedshiftHSMConfiguration_tags
--- PASS: TestAccRedshiftHSMConfiguration_tags (25.49s)
=== CONT  TestAccRedshiftOrderableClusterDataSource_clusterVersion
--- PASS: TestAccRedshiftOrderableClusterDataSource_clusterVersion (8.11s)
=== CONT  TestAccRedshiftHSMConfiguration_basic
--- PASS: TestAccRedshiftHSMConfiguration_basic (11.17s)
=== CONT  TestAccRedshiftOrderableClusterDataSource_clusterType
--- PASS: TestAccRedshiftLogging_basic (179.90s)
=== CONT  TestAccRedshiftLogging_s3
--- PASS: TestAccRedshiftOrderableClusterDataSource_clusterType (7.87s)
=== CONT  TestAccRedshiftScheduledAction_basicPauseCluster
--- PASS: TestAccRedshiftScheduledAction_basicPauseCluster (28.66s)
=== CONT  TestAccRedshiftScheduledAction_disappears
--- PASS: TestAccRedshiftScheduledAction_disappears (20.11s)
=== CONT  TestAccRedshiftScheduledAction_resizeClusterWithOptions
--- PASS: TestAccRedshiftScheduledAction_resizeClusterWithOptions (22.44s)
=== CONT  TestAccRedshiftSnapshotCopyGrant_tags
--- PASS: TestAccRedshiftSnapshotCopyGrant_tags (29.08s)
=== CONT  TestAccRedshiftScheduledAction_basicResumeCluster
--- PASS: TestAccRedshiftLogging_disappears_Cluster (187.85s)
=== CONT  TestAccRedshiftSnapshotCopyGrant_disappears
--- PASS: TestAccRedshiftSnapshotCopyGrant_disappears (9.82s)
=== CONT  TestAccRedshiftSnapshotCopyGrant_basic
--- PASS: TestAccRedshiftSnapshotCopyGrant_basic (11.46s)
=== CONT  TestAccRedshiftCluster_withFinalSnapshot
--- PASS: TestAccRedshiftScheduledAction_basicResumeCluster (28.82s)
=== CONT  TestAccRedshiftScheduledAction_validScheduleName
--- PASS: TestAccRedshiftScheduledAction_validScheduleName (0.00s)
=== CONT  TestAccRedshiftCluster_basic
--- PASS: TestAccRedshiftCluster_updateNodeCount (1269.68s)
=== CONT  TestAccRedshiftEventSubscription_withSourceIDs
--- PASS: TestAccRedshiftEventSubscription_withSourceIDs (21.12s)
=== CONT  TestAccRedshiftEventSubscription_tags
--- PASS: TestAccRedshiftLogging_s3 (182.42s)
=== CONT  TestAccRedshiftEventSubscription_categoryUpdate
--- PASS: TestAccRedshiftEventSubscription_tags (28.90s)
=== CONT  TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
--- PASS: TestAccRedshiftEventSubscription_categoryUpdate (20.87s)
=== CONT  TestAccRedshiftEventSubscription_disappears
--- PASS: TestAccRedshiftEventSubscription_disappears (11.56s)
=== CONT  TestAccRedshiftClusterSnapshot_tags
--- PASS: TestAccRedshiftCluster_basic (156.63s)
=== CONT  TestAccRedshiftHSMClientCertificate_tags
--- PASS: TestAccRedshiftHSMClientCertificate_tags (25.61s)
=== CONT  TestAccRedshiftScheduledAction_pauseClusterWithOptions
--- PASS: TestAccRedshiftScheduledAction_pauseClusterWithOptions (21.98s)
=== CONT  TestAccRedshiftEndpointAuthorization_disappears
    endpoint_authorization_test.go:116: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRedshiftEndpointAuthorization_disappears (0.00s)
=== CONT  TestAccRedshiftEventSubscription_basic
--- PASS: TestAccRedshiftEventSubscription_basic (21.56s)
=== CONT  TestAccRedshiftEndpointAuthorization_disappears_cluster
    endpoint_authorization_test.go:143: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRedshiftEndpointAuthorization_disappears_cluster (0.00s)
=== CONT  TestAccRedshiftCluster_aqua
--- PASS: TestAccRedshiftCluster_withFinalSnapshot (221.01s)
=== CONT  TestAccRedshiftScheduledAction_basicResizeCluster
--- PASS: TestAccRedshiftScheduledAction_basicResizeCluster (24.77s)
=== CONT  TestAccRedshiftClusterDataSource_basic
--- PASS: TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled (280.10s)
=== CONT  TestAccRedshiftClusterCredentialsDataSource_basic
--- PASS: TestAccRedshiftClusterSnapshot_tags (284.95s)
=== CONT  TestAccRedshiftClusterDataSource_logging
--- PASS: TestAccRedshiftClusterDataSource_basic (174.85s)
=== CONT  TestAccRedshiftClusterIAMRoles_basic
--- PASS: TestAccRedshiftCluster_aqua (224.35s)
=== CONT  TestAccRedshiftClusterDataSource_vpc
--- PASS: TestAccRedshiftClusterDataSource_logging (192.18s)
=== CONT  TestAccRedshiftClusterIAMRoles_disappears
--- PASS: TestAccRedshiftClusterDataSource_vpc (182.13s)
=== CONT  TestAccRedshiftAuthenticationProfile_disappears
--- PASS: TestAccRedshiftAuthenticationProfile_disappears (9.59s)
=== CONT  TestAccRedshiftPartner_disappears
--- PASS: TestAccRedshiftClusterCredentialsDataSource_basic (278.61s)
=== CONT  TestAccRedshiftResourcePolicy_disappears
    resource_policy_test.go:59: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRedshiftResourcePolicy_disappears (0.00s)
=== CONT  TestAccRedshiftResourcePolicy_basic
    resource_policy_test.go:29: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRedshiftResourcePolicy_basic (0.00s)
=== CONT  TestAccRedshiftProducerDataSharesDataSource_basic
--- PASS: TestAccRedshiftClusterIAMRoles_basic (274.92s)
=== CONT  TestAccRedshiftPartner_disappears_cluster
--- PASS: TestAccRedshiftClusterIAMRoles_disappears (179.39s)
=== CONT  TestAccRedshiftClusterDataSource_multiAZEnabled
--- PASS: TestAccRedshiftPartner_disappears (143.98s)
=== CONT  TestAccRedshiftEndpointAuthorization_basic
    endpoint_authorization_test.go:31: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRedshiftEndpointAuthorization_basic (0.00s)
=== CONT  TestAccRedshiftParameterGroup_disappears
--- PASS: TestAccRedshiftParameterGroup_disappears (9.46s)
=== CONT  TestAccRedshiftParameterGroup_update
--- PASS: TestAccRedshiftParameterGroup_update (18.23s)
=== CONT  TestAccRedshiftPartner_basic
--- PASS: TestAccRedshiftPartner_disappears_cluster (164.40s)
=== CONT  TestAccRedshiftParameterGroup_basic
--- PASS: TestAccRedshiftParameterGroup_basic (11.46s)
=== CONT  TestAccRedshiftHSMClientCertificate_basic
--- PASS: TestAccRedshiftHSMClientCertificate_basic (11.26s)
=== CONT  TestAccRedshiftCluster_disappears
--- PASS: TestAccRedshiftProducerDataSharesDataSource_basic (309.93s)
=== CONT  TestAccRedshiftClusterSnapshot_basic
--- PASS: TestAccRedshiftPartner_basic (156.34s)
=== CONT  TestAccRedshiftSnapshotCopy_basic
--- PASS: TestAccRedshiftCluster_disappears (154.42s)
=== CONT  TestAccRedshiftEndpointAuthorization_vpcs
    endpoint_authorization_test.go:67: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account.
--- SKIP: TestAccRedshiftEndpointAuthorization_vpcs (0.00s)
=== CONT  TestAccRedshiftParameterGroup_tags
--- PASS: TestAccRedshiftClusterDataSource_multiAZEnabled (298.49s)
--- PASS: TestAccRedshiftParameterGroup_tags (25.88s)
--- PASS: TestAccRedshiftSnapshotCopy_basic (158.40s)
--- PASS: TestAccRedshiftClusterSnapshot_basic (307.93s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	5643.808s

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6202a03 into hashicorp:main Aug 16, 2024
39 checks passed
@github-actions github-actions bot added this to the v5.64.0 milestone Aug 16, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 20, 2024
Copy link

This functionality has been released in v5.63.1 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. external-maintainer Contribution from a trusted external contributor. generators Relates to code generators. service/redshift Issues and PRs that pertain to the redshift service. sweeper Pertains to changes to or issues with the sweeper. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Redshift Service
2 participants