Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/provider(test): remove DMS from unusual endpoint tests #38694

Merged
merged 1 commit into from
Aug 5, 2024
Merged

internal/provider(test): remove DMS from unusual endpoint tests #38694

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions internal/provider/provider_acc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,8 +217,7 @@ func TestAccProvider_unusualEndpoints(t *testing.T) {
ctx := acctest.Context(t)
var provider *schema.Provider
unusual1 := unusualEndpoint{"es", "elasticsearch", "http://notarealendpoint"}
unusual2 := unusualEndpoint{"databasemigration", "dms", "http://alsonotarealendpoint"}
unusual3 := unusualEndpoint{"lexmodelbuildingservice", "lexmodels", "http://kingofspain"}
unusual2 := unusualEndpoint{"lexmodelbuildingservice", "lexmodels", "http://kingofspain"}

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(ctx, t) },
Expand All @@ -227,11 +226,10 @@ func TestAccProvider_unusualEndpoints(t *testing.T) {
CheckDestroy: nil,
Steps: []resource.TestStep{
{
Config: testAccProviderConfig_unusualEndpoints(unusual1, unusual2, unusual3),
Config: testAccProviderConfig_unusualEndpoints(unusual1, unusual2),
Check: resource.ComposeTestCheckFunc(
testAccCheckUnusualEndpoints(ctx, &provider, unusual1),
testAccCheckUnusualEndpoints(ctx, &provider, unusual2),
testAccCheckUnusualEndpoints(ctx, &provider, unusual3),
),
},
},
Expand Down Expand Up @@ -1056,7 +1054,7 @@ resource "aws_s3_bucket" "test" {
`, endpoint, rName))
}

func testAccProviderConfig_unusualEndpoints(unusual1, unusual2, unusual3 unusualEndpoint) string {
func testAccProviderConfig_unusualEndpoints(unusual1, unusual2 unusualEndpoint) string {
//lintignore:AT004
return acctest.ConfigCompose(testAccProviderConfig_base, fmt.Sprintf(`
provider "aws" {
Expand All @@ -1067,10 +1065,9 @@ provider "aws" {
endpoints {
%[1]s = %[2]q
%[3]s = %[4]q
%[5]s = %[6]q
}
}
`, unusual1.fieldName, unusual1.url, unusual2.fieldName, unusual2.url, unusual3.fieldName, unusual3.url))
`, unusual1.fieldName, unusual1.url, unusual2.fieldName, unusual2.url))
}

func testAccProviderConfig_useFipsEndpointFlag(rName string) string {
Expand Down
Loading