-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate wavelength
resource to AWS Go SDKv2
#37407
Migrate wavelength
resource to AWS Go SDKv2
#37407
Conversation
Community NoteVoting for Prioritization
For Submitters
|
# Conflicts: # internal/service/ec2/find.go # internal/service/ec2/findv2.go # internal/service/ec2/statusv2.go # internal/service/ec2/waitv2.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccWavelengthCarrierGateway_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccWavelengthCarrierGateway_ -timeout 360m
=== RUN TestAccWavelengthCarrierGateway_basic
=== PAUSE TestAccWavelengthCarrierGateway_basic
=== RUN TestAccWavelengthCarrierGateway_disappears
=== PAUSE TestAccWavelengthCarrierGateway_disappears
=== RUN TestAccWavelengthCarrierGateway_tags
=== PAUSE TestAccWavelengthCarrierGateway_tags
=== CONT TestAccWavelengthCarrierGateway_basic
=== CONT TestAccWavelengthCarrierGateway_tags
--- PASS: TestAccWavelengthCarrierGateway_basic (17.87s)
=== CONT TestAccWavelengthCarrierGateway_disappears
--- PASS: TestAccWavelengthCarrierGateway_disappears (15.00s)
--- PASS: TestAccWavelengthCarrierGateway_tags (38.43s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 43.108s
@DanielRieske Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR migrates the single
wavelength
resourceaws_ec2_carrier_gateway
resource.Note to the reviewer that I am not opted in any Wavelength Zones therefore I wasn't able to run the tests myself.
Relations
Closes #36226
References
Output from Acceptance Testing