Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate wavelength resource to AWS Go SDKv2 #37407

Merged
merged 11 commits into from
May 20, 2024

Conversation

DanielRieske
Copy link
Contributor

Description

This PR migrates the single wavelength resource aws_ec2_carrier_gateway resource.

Note to the reviewer that I am not opted in any Wavelength Zones therefore I wasn't able to run the tests myself.

Relations

Closes #36226

References

Output from Acceptance Testing

make testacc TESTARGS='-run=TestAccWavelengthCarrierGateway_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccWavelengthCarrierGateway_ -timeout 360m
=== RUN   TestAccWavelengthCarrierGateway_basic
=== PAUSE TestAccWavelengthCarrierGateway_basic
=== RUN   TestAccWavelengthCarrierGateway_disappears
=== PAUSE TestAccWavelengthCarrierGateway_disappears
=== RUN   TestAccWavelengthCarrierGateway_tags
=== PAUSE TestAccWavelengthCarrierGateway_tags
=== CONT  TestAccWavelengthCarrierGateway_basic
=== CONT  TestAccWavelengthCarrierGateway_tags
=== CONT  TestAccWavelengthCarrierGateway_disappears
=== NAME  TestAccWavelengthCarrierGateway_basic
    wavelength_carrier_gateway_test.go:198: skipping since no Wavelength Zones are available
--- SKIP: TestAccWavelengthCarrierGateway_basic (1.39s)
=== NAME  TestAccWavelengthCarrierGateway_tags
    wavelength_carrier_gateway_test.go:198: skipping since no Wavelength Zones are available
--- SKIP: TestAccWavelengthCarrierGateway_tags (1.40s)
=== NAME  TestAccWavelengthCarrierGateway_disappears
    wavelength_carrier_gateway_test.go:198: skipping since no Wavelength Zones are available
--- SKIP: TestAccWavelengthCarrierGateway_disappears (1.51s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        5.774s

Copy link

github-actions bot commented May 9, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/wavelength Issues and PRs that pertain to the wavelength service. size/L Managed by automation to categorize the size of a PR. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/wavelength Issues and PRs that pertain to the wavelength service. labels May 9, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 9, 2024
@breathingdust breathingdust added the aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. label May 9, 2024
@justinretzolk justinretzolk added service/wavelength Issues and PRs that pertain to the wavelength service. and removed needs-triage Waiting for first response or review from a maintainer. labels May 13, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccWavelengthCarrierGateway_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/ec2/... -v -count 1 -parallel 2  -run=TestAccWavelengthCarrierGateway_ -timeout 360m
=== RUN   TestAccWavelengthCarrierGateway_basic
=== PAUSE TestAccWavelengthCarrierGateway_basic
=== RUN   TestAccWavelengthCarrierGateway_disappears
=== PAUSE TestAccWavelengthCarrierGateway_disappears
=== RUN   TestAccWavelengthCarrierGateway_tags
=== PAUSE TestAccWavelengthCarrierGateway_tags
=== CONT  TestAccWavelengthCarrierGateway_basic
=== CONT  TestAccWavelengthCarrierGateway_tags
--- PASS: TestAccWavelengthCarrierGateway_basic (17.87s)
=== CONT  TestAccWavelengthCarrierGateway_disappears
--- PASS: TestAccWavelengthCarrierGateway_disappears (15.00s)
--- PASS: TestAccWavelengthCarrierGateway_tags (38.43s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	43.108s

@ewbankkit
Copy link
Contributor

@DanielRieske Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit eae23a8 into hashicorp:main May 20, 2024
35 checks passed
@github-actions github-actions bot added this to the v5.51.0 milestone May 20, 2024
Copy link

This functionality has been released in v5.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aws-sdk-go-migration Issues that are related to the providers migration to AWS SDK for Go v2. external-maintainer Contribution from a trusted external contributor. service/wavelength Issues and PRs that pertain to the wavelength service. size/L Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS SDK for Go Migration] Wavelength Service
4 participants