Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

d/aws_waf_regex_pattern_set: new data source #36050

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

midgleyc
Copy link

@midgleyc midgleyc commented Mar 1, 2024

Description

Add a new data source for aws_waf_regex_pattern_set.

Relations

Closes #36025

References

Output from Acceptance Testing

% make testacc PKG=waf TESTS=TestAccWAFRegexPatternSetDataSource_

...

no output (so PR is untested) but I think this command should be right

Copy link

github-actions bot commented Mar 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/waf Issues and PRs that pertain to the waf service. labels Mar 1, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 1, 2024
@jar-b
Copy link
Member

jar-b commented Mar 1, 2024

Hey @midgleyc - thanks for your effort on this!

In October 2023 we implemented a policy change requiring that all new resources and data sources be implemented with Terraform Plugin Framework. More details on the justification are available in the contributor documentation and pinned issue:

If possible, migrating this PR to Plugin Framework will help us more quickly review and test it.

@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Mar 1, 2024
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. service/waf Issues and PRs that pertain to the waf service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: aws_waf_regex_pattern_set
3 participants