-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch job definition remove force new and increment revisions #35149
batch job definition remove force new and increment revisions #35149
Conversation
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
854edfa
to
ecd9edc
Compare
521d649
to
c1cc669
Compare
rebased: $ make testacc TESTS=TestAccBatchJobDefinition_ PKG=batch
--- PASS: TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties (87.13s)
--- PASS: TestAccBatchJobDefinition_createTypeContainerWithNodeProperties (87.25s)
--- PASS: TestAccBatchJobDefinition_EKSProperties_basic (244.90s)
--- PASS: TestAccBatchJobDefinition_propagateTags (247.71s)
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_ec2 (250.55s)
--- PASS: TestAccBatchJobDefinition_NodeProperties_basic (253.95s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_EmptyField (258.68s)
--- PASS: TestAccBatchJobDefinition_basic (258.96s)
--- PASS: TestAccBatchJobDefinition_disappears (260.92s)
--- PASS: TestAccBatchJobDefinition_schedulingPriority (262.80s)
--- PASS: TestAccBatchJobDefinition_NodeProperties_advanced (317.48s)
--- PASS: TestAccBatchJobDefinition_EKSProperties_update (319.84s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_advanced (324.10s)
--- PASS: TestAccBatchJobDefinition_tags (383.79s)
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_fargate (420.52s)
--- PASS: TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults (422.02s)
--- PASS: TestAccBatchJobDefinition_attributes (423.58s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/batch 429.964s |
9cf9b62
to
fa2ff1d
Compare
This PR has been open since Jan 4. Any way we can get a review and merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
--- PASS: TestAccBatchJobDefinition_createTypeMultiNodeWithContainerProperties (10.47s)
--- PASS: TestAccBatchJobDefinition_createTypeContainerWithNodeProperties (10.52s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_EmptyField (24.15s)
--- PASS: TestAccBatchJobDefinition_basic (25.87s)
--- PASS: TestAccBatchJobDefinition_schedulingPriority (27.06s)
--- PASS: TestAccBatchJobDefinition_propagateTags (31.76s)
--- PASS: TestAccBatchJobDefinition_PlatformCapabilitiesFargate_containerPropertiesDefaults (31.87s)
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_fargate (32.81s)
--- PASS: TestAccBatchJobDefinition_disappears (33.76s)
--- PASS: TestAccBatchJobDefinition_PlatformCapabilities_ec2 (35.76s)
--- PASS: TestAccBatchJobDefinition_ContainerProperties_advanced (36.52s)
--- PASS: TestAccBatchJobDefinition_EKSProperties_basic (36.79s)
--- PASS: TestAccBatchJobDefinition_NodeProperties_basic (37.01s)
--- PASS: TestAccBatchJobDefinition_NodeProperties_advanced (37.60s)
--- PASS: TestAccBatchJobDefinition_EKSProperties_update (41.82s)
--- PASS: TestAccBatchJobDefinition_tags (43.20s)
--- PASS: TestAccBatchJobDefinition_attributes (49.11s)
This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This change first started as a larger PR and the commits were pulled into a separate PR for isolation
Summary
job_definition
(JD) was previously a ForceNew resource on all parameters. This was interesting because when a JD is deleted in AWS the revision still lasts but is marked as inactive. In some ways, the ForceNew didnt matter because a new revision was being created. This PR modifies the behavior so that instead of deleting each revision as a new is created, we merely add a new one.Design decisions
deregister_on_new_revision
testAccCheckJobDefinitionDestroy
) now checks to see if any revisions exist and fails accordinglytestAccCheckJobDefinitionPreviousRegistered
andtestAccCheckJobDefinitionPreviousDeregistered
to validate change from ForceNew to rev updatesTesting changes
_updateForcesNewResource
-> coverage by_attributes
_NodePropertiesupdateForcesNewResource
-> coverage by_NodeProperties_basic
testAccCheckJobDefinitionDestroy
now checks for all revisions to be deregisteredRelations
Closes #29819
References
Output from Acceptance Testing