Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design Decision]: Relationship Resource Design Standards #32552

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Jul 17, 2023

Description

A proposal to align on design standards for relationship management resources in the Terraform AWS Provider. The branches rendered markdown may be preferable for readability.

This document is public facing to allow for community feedback before approval. Please leave suggestions in the form of review comments or general comments on the PR.

Relations

Relates #9901
Relates #32380

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. labels Jul 17, 2023
@breathingdust breathingdust added the proposal Proposes new design or functionality. label Jul 17, 2023
@jar-b jar-b force-pushed the d-relationship-resource-rfc branch from 9f64ae8 to 9db3dee Compare July 17, 2023 21:02
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. and removed size/XL Managed by automation to categorize the size of a PR. labels Jul 17, 2023
@jar-b jar-b force-pushed the d-relationship-resource-rfc branch from b63ff1c to 678c908 Compare July 18, 2023 14:18
@jar-b jar-b added the waiting-response Maintainers are waiting on response from community or contributor. label Jul 18, 2023
@breathingdust breathingdust added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jul 21, 2023
@jar-b jar-b removed the waiting-response Maintainers are waiting on response from community or contributor. label Jul 31, 2023
@jar-b
Copy link
Member Author

jar-b commented Jul 31, 2023

With no stated community objections, we're going to accept this proposal and merge.

@jar-b jar-b merged commit 7acff9a into main Jul 31, 2023
@jar-b jar-b deleted the d-relationship-resource-rfc branch July 31, 2023 18:04
@github-actions github-actions bot added this to the v5.11.0 milestone Jul 31, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This functionality has been released in v5.11.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. proposal Proposes new design or functionality. size/M Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants