Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sweepers: Create AWS SDK version-specific skip error handlers for sweepers #32488

Merged
merged 3 commits into from
Jul 13, 2023
Merged

sweepers: Create AWS SDK version-specific skip error handlers for sweepers #32488

merged 3 commits into from
Jul 13, 2023

Conversation

gdavison
Copy link
Contributor

Description

Since AWS SDK for Go v1 and v2 have different error handling strategies and types, use separate skip checking functions in sweepers.

awsv1.SkipSweepError is aliased as sweep. SkipSweepError

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/lightsail Issues and PRs that pertain to the lightsail service. service/acm Issues and PRs that pertain to the acm service. service/glacier Issues and PRs that pertain to the glacier service. service/medialive Issues and PRs that pertain to the medialive service. service/ssm Issues and PRs that pertain to the ssm service. service/workspaces Issues and PRs that pertain to the workspaces service. service/swf Issues and PRs that pertain to the swf service. service/acmpca Issues and PRs that pertain to the acmpca service. service/qldb Issues and PRs that pertain to the qldb service. service/sesv2 Issues and PRs that pertain to the sesv2 service. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/kendra Issues and PRs that pertain to the kendra service. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. service/auditmanager Issues and PRs that pertain to the auditmanager service. sweeper Pertains to changes to or issues with the sweeper. service/keyspaces Issues and PRs that pertain to the keyspaces service. service/transcribe Issues and PRs that pertain to the transcribe service. service/scheduler Issues and PRs that pertain to the scheduler service. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. service/pipes Issues and PRs that pertain to the pipes service. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. service/vpclattice Issues and PRs that pertain to the vpclattice service. service/internetmonitor Issues and PRs that pertain to the internetmonitor service. labels Jul 12, 2023
jar-b
jar-b approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@gdavison gdavison merged commit 71ac1fa into main Jul 13, 2023
@gdavison gdavison deleted the b-sweep-skipsweeperr branch July 13, 2023 20:31
@github-actions github-actions bot added this to the v5.8.0 milestone Jul 13, 2023
@github-actions
Copy link

This functionality has been released in v5.8.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/auditmanager Issues and PRs that pertain to the auditmanager service. service/glacier Issues and PRs that pertain to the glacier service. service/internetmonitor Issues and PRs that pertain to the internetmonitor service. service/kendra Issues and PRs that pertain to the kendra service. service/keyspaces Issues and PRs that pertain to the keyspaces service. service/lightsail Issues and PRs that pertain to the lightsail service. service/medialive Issues and PRs that pertain to the medialive service. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. service/pipes Issues and PRs that pertain to the pipes service. service/qldb Issues and PRs that pertain to the qldb service. service/resourceexplorer2 Issues and PRs that pertain to the resourceexplorer2 service. service/scheduler Issues and PRs that pertain to the scheduler service. service/sesv2 Issues and PRs that pertain to the sesv2 service. service/ssm Issues and PRs that pertain to the ssm service. service/swf Issues and PRs that pertain to the swf service. service/timestreamwrite Issues and PRs that pertain to the timestreamwrite service. service/transcribe Issues and PRs that pertain to the transcribe service. service/vpclattice Issues and PRs that pertain to the vpclattice service. service/workspaces Issues and PRs that pertain to the workspaces service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper.
Projects
None yet
Milestone
v5.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @jar-b