Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement aws_secretsmanager_random_password data source #25704

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Implement aws_secretsmanager_random_password data source #25704

merged 3 commits into from
Jul 7, 2022

Conversation

kurtmc
Copy link
Contributor

@kurtmc kurtmc commented Jul 6, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25694

Output from acceptance testing:

$ make testacc TESTS=TestAccSecretsManagerRandomPasswordDataSource PKG=secretsmanager
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/secretsmanager/... -v -count 1 -parallel 20 -run='TestAccSecretsManagerRandomPasswordDataSource'  -timeout 180m
=== RUN   TestAccSecretsManagerRandomPasswordDataSource_basic
=== PAUSE TestAccSecretsManagerRandomPasswordDataSource_basic
=== RUN   TestAccSecretsManagerRandomPasswordDataSource_exclude
=== PAUSE TestAccSecretsManagerRandomPasswordDataSource_exclude
=== CONT  TestAccSecretsManagerRandomPasswordDataSource_basic
=== CONT  TestAccSecretsManagerRandomPasswordDataSource_exclude
--- PASS: TestAccSecretsManagerRandomPasswordDataSource_exclude (8.80s)
--- PASS: TestAccSecretsManagerRandomPasswordDataSource_basic (8.89s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager     8.943s

@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Jul 6, 2022
@kurtmc kurtmc force-pushed the feature/data/aws_secretsmanager_random_password_done branch from 252a152 to 3a696e0 Compare July 6, 2022 06:54
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jul 6, 2022
@kurtmc kurtmc force-pushed the feature/data/aws_secretsmanager_random_password_done branch from 3a696e0 to 33b2ade Compare July 6, 2022 07:00
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. enhancement Requests to existing resources that expand the functionality or scope. labels Jul 6, 2022
ewbankkit
ewbankkit approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccSecretsManagerRandomPasswordDataSource' PKG=secretsmanager ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/secretsmanager/... -v -count 1 -parallel 2  -run=TestAccSecretsManagerRandomPasswordDataSource -timeout 180m
=== RUN   TestAccSecretsManagerRandomPasswordDataSource_basic
=== PAUSE TestAccSecretsManagerRandomPasswordDataSource_basic
=== RUN   TestAccSecretsManagerRandomPasswordDataSource_exclude
=== PAUSE TestAccSecretsManagerRandomPasswordDataSource_exclude
=== CONT  TestAccSecretsManagerRandomPasswordDataSource_basic
=== CONT  TestAccSecretsManagerRandomPasswordDataSource_exclude
--- PASS: TestAccSecretsManagerRandomPasswordDataSource_basic (14.35s)
--- PASS: TestAccSecretsManagerRandomPasswordDataSource_exclude (14.46s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/secretsmanager	19.226s

@ewbankkit
Copy link
Contributor

@kurtmc Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit eab0e21 into hashicorp:main Jul 7, 2022
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 7, 2022
@kurtmc kurtmc deleted the feature/data/aws_secretsmanager_random_password_done branch July 7, 2022 20:38
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. provider Pertains to the provider itself, rather than any interaction with AWS. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.22.0
Development

Successfully merging this pull request may close these issues.

new data source for secretsmanager:GetRandomPassword
3 participants
@kurtmc @ewbankkit @justinretzolk