Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_ecs_cluster: deprecate capacity provider attributes #22783

Merged
merged 2 commits into from
Jan 27, 2022
Merged

r/aws_ecs_cluster: deprecate capacity provider attributes #22783

merged 2 commits into from
Jan 27, 2022

Conversation

roberth-k
Copy link
Contributor

@roberth-k roberth-k commented Jan 26, 2022 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #22754
Relates #22672
Relates #22776

Output from acceptance testing:

n/a

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. size/S Managed by automation to categorize the size of a PR. labels Jan 26, 2022
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 27, 2022
ewbankkit
ewbankkit approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@roberth-k Thanks for the contribution 🎉 👏.

@anGie44 anGie44 added this to the v4.0.0 milestone Jan 27, 2022
@ewbankkit ewbankkit merged commit 3ea0d21 into hashicorp:release/4.x Jan 27, 2022
@YakDriver YakDriver mentioned this pull request Jan 28, 2022
Closed
anGie44 pushed a commit that referenced this pull request Jan 28, 2022
@roberth-k @anGie44
add changelog entry for #22783
98ff667
anGie44 pushed a commit that referenced this pull request Jan 28, 2022
@roberth-k @anGie44
add changelog entry for #22783
1c88477
anGie44 pushed a commit that referenced this pull request Jan 31, 2022
@roberth-k @anGie44
add changelog entry for #22783
eb47150
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@roberth-k roberth-k deleted the f-aws_ecs_cluster-capacity-providers-deprecation branch February 10, 2022 20:39
@antonbabenko antonbabenko mentioned this pull request Feb 15, 2022
Closed
@hanscg hanscg mentioned this pull request Feb 18, 2022
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@roberth-k @ewbankkit @anGie44