Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/provider: Fix hardcoded canoncial (EC2 Traffic Mirror) #15865

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 27, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15866

Release note for CHANGELOG:

NONE

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSEc2TrafficMirrorFilter_disappears (18.14s)
--- PASS: TestAccAWSEc2TrafficMirrorFilter_tags (51.16s)
--- PASS: TestAccAWSEc2TrafficMirrorFilter_basic (51.77s)
--- PASS: TestAccAWSEc2TrafficMirrorFilterRule_basic (55.73s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_eni (108.92s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_disappears (222.43s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_nlb (237.05s)
--- PASS: TestAccAWSEc2TrafficMirrorSession_disappears (249.30s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_tags (276.65s)
--- PASS: TestAccAWSEc2TrafficMirrorSession_tags (312.30s)
--- PASS: TestAccAWSEc2TrafficMirrorSession_basic (333.06s)

Output from acceptance testing (commercial):

--- PASS: TestAccAWSEc2TrafficMirrorFilter_disappears (12.71s)
--- PASS: TestAccAWSEc2TrafficMirrorFilter_tags (38.05s)
--- PASS: TestAccAWSEc2TrafficMirrorFilter_basic (38.53s)
--- PASS: TestAccAWSEc2TrafficMirrorFilterRule_basic (41.81s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_eni (124.02s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_nlb (222.24s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_disappears (239.02s)
--- PASS: TestAccAWSEc2TrafficMirrorSession_tags (270.76s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_tags (276.46s)
--- PASS: TestAccAWSEc2TrafficMirrorSession_basic (279.08s)
--- PASS: TestAccAWSEc2TrafficMirrorSession_disappears (287.14s)

@YakDriver YakDriver requested a review from a team October 27, 2020 20:34
@ghost ghost added size/M Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 27, 2020
@YakDriver YakDriver added the partition/aws-us-gov Pertains to the aws-us-gov partition. label Oct 27, 2020
@bflad bflad self-assigned this Oct 29, 2020
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSEc2TrafficMirrorSession_basic (292.83s)
--- PASS: TestAccAWSEc2TrafficMirrorSession_disappears (282.61s)
--- PASS: TestAccAWSEc2TrafficMirrorSession_tags (314.66s)

--- PASS: TestAccAWSEc2TrafficMirrorTarget_disappears (236.01s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_eni (100.79s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_nlb (218.14s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_tags (247.63s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSEc2TrafficMirrorSession_basic (322.46s)
--- PASS: TestAccAWSEc2TrafficMirrorSession_disappears (237.29s)
--- PASS: TestAccAWSEc2TrafficMirrorSession_tags (312.63s)

--- PASS: TestAccAWSEc2TrafficMirrorTarget_disappears (242.29s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_eni (94.64s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_nlb (210.05s)
--- PASS: TestAccAWSEc2TrafficMirrorTarget_tags (281.93s)

@YakDriver YakDriver merged commit b43d432 into master Oct 29, 2020
@YakDriver YakDriver deleted the t-gov-ec2traffic branch October 29, 2020 14:10
@YakDriver YakDriver added this to the v3.13.0 milestone Oct 29, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 3.13.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests/provider: EC2 Traffic Mirror: query returned no results
2 participants