Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ECR repository to support not deleting all images when resource is deleted #9911

Closed
wjam opened this issue Aug 29, 2019 · 2 comments · Fixed by #9913
Closed

Change ECR repository to support not deleting all images when resource is deleted #9911

wjam opened this issue Aug 29, 2019 · 2 comments · Fixed by #9913
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service.
Milestone

Comments

@wjam
Copy link
Contributor

wjam commented Aug 29, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Currently, when an aws_ecr_repositiry is deleted, Terraform will get AWS to delete all images within the repo as it deletes the repository as it sets the 'force' parameter to true.

A new parameter should be added to the aws_ecr_repository so that the force parameter can be set to false if the user wants to avoid accidently deleting the repository if it still contains images. This parameter should default to true for backwards compatibility.

I feel that this isn't a safe default to have and should be considered for changed for the 3.x release.

New or Affected Resource(s)

aws_ecr_repository

Potential Terraform Configuration

References

@wjam wjam added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 29, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 29, 2019
@DrFaust92 DrFaust92 added the service/ecr Issues and PRs that pertain to the ecr service. label May 21, 2020
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 22, 2021
@github-actions github-actions bot added this to the v4.22.0 milestone Jul 6, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v4.22.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 7, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecr Issues and PRs that pertain to the ecr service.
Projects
None yet
3 participants