fixed Support pagination for data source aws_autoscaling_groups broken in aws provider v1.38.0

[geekinsanemx]

Hi Guys,

bug reported and fixed in PR #4422 broken seems gets broken at aws provider version v1.38.0 probably related to change in PR #5766

I got more than 500 autoscaling groups wanted to list using function aws_autoscaling_groups it seems works fine up to versions:

Terraform v0.11.14

• provider.aws v1.37.0

in provider aws = v1.38.0 it started failed again with limitation of 50 asg list, error message:

Error: Error refreshing state: 1 error occurred:
	* data.aws_autoscaling_groups.groups: 1 error occurred:
	* data.aws_autoscaling_groups.groups: data.aws_autoscaling_groups.groups: Error fetching Autoscaling Groups: ValidationError: The number of group names that may be passed in is limited to 50
	status code: 400, request id: e9636e8e-835f-11e9-9dee-bb59bb459bff

I noticed may be related to change #5766 that affect directly to that function and do not work anymore to retrieve more than 50 items

with terraform v0.12.0 that provider version is even not supported :

Provider "aws" v1.38.0 is not compatible with Terraform 0.12.0.

Provider version 2.7.0 is the earliest compatible version. Select it with 
the following version constraint:

	version = "~> 2.7"

since that aws provider version 2.7 upto latest 2.12 all aws provider fails with error message:

Error: Error fetching Autoscaling Groups: ValidationError: The number of group names that may be passed in is limited to 50
	status code: 400, request id: e71431ad-8360-11e9-82f8-491dfddd30a3

  on error-slacknotifier.tf line 24, in data "aws_autoscaling_groups" "groups":
  24: data "aws_autoscaling_groups" "groups" {

terraform piece of code affected:

please refer to: https://www.terraform.io/docs/providers/aws/d/autoscaling_groups.html

resource "aws_sns_topic" "slack_notification" {
  name = "asg-slacknotification"
}

data "aws_autoscaling_groups" "groups" {
  filter {
    name   = "key"
    values = ["Name"]
  }
}

resource "aws_autoscaling_notification" "slack_notifications" {
  group_names = ["${data.aws_autoscaling_groups.groups.names}"]

  notifications = [
    "autoscaling:EC2_INSTANCE_LAUNCH_ERROR",
  ]

  topic_arn = "${aws_sns_topic.slack_notification.arn}"
}

basically the issue is that function aws_autoscaling_groups does not support retrieve more than 50 names for autoscaling group to be mapped at aws_autoscaling_notification group

can we retake this issue?

Thanks!

[github-actions]

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.