Tech debt: Consistently use 'ec2TagSpecificationsFromMap' to create EC2 TagSpecifications

[ewbankkit]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

ec2TagSpecificationsFromMap() added in #7619 should be used consistently to create EC2 TagSpecifications.
This can replace:

• expandEc2TransitGatewayTagSpecifications() - EC2 Transit Gateway: Refactor tagging logic to keyvaluetags package #11082
• expandEc2TransitGatewayAttachmentTagSpecifications() - EC2 Transit Gateway: Refactor tagging logic to keyvaluetags package #11082
• expandEc2TransitGatewayRouteTableTagSpecifications() - EC2 Transit Gateway: Refactor tagging logic to keyvaluetags package #11082
• Inline code in resourceAwsEbsVolumeCreate() - aws_ebs_volume: Refactor tagging logic to keyvaluetags package #10778
• Inline code in resourceAwsEc2CapacityReservationCreate() - r/aws_ec2_capacity_reservation: Refactor tagging logic to keyvaluetags package #10775
• expandEc2TagSpecifications() - r/aws_ec2_fleet: Refactor tagging logic to keyvaluetags package #10761
• Inline code in resourceAwsInstanceCreate() - aws_instance: Refactor tagging logic to keyvaluetags package #10789

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!