Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_opsworks_application.short_name attempts update in-place and fails silently #6306

Closed
omnibs opened this issue Oct 30, 2018 · 4 comments · Fixed by #6359
Closed

aws_opsworks_application.short_name attempts update in-place and fails silently #6306

omnibs opened this issue Oct 30, 2018 · 4 comments · Fixed by #6359
Labels
bug Addresses a defect in current functionality. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/opsworks Issues and PRs that pertain to the opsworks service.
Milestone

Comments

@omnibs
Copy link

omnibs commented Oct 30, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

$ terraform -v
Terraform v0.11.7
+ provider.aws v1.41.0

Affected Resource(s)

  • aws_opsworks_application

Terraform Configuration Files

resource "aws_opsworks_application" "foo-app" {
  name        = "foobar application"
  short_name  = "foobar"
  stack_id    = "${aws_opsworks_stack.main.id}"
  type        = "rails"
  description = "This is a Rails application"

  domains = [
    "example.com",
    "sub.example.com",
  ]

  environment = {
    key    = "key"
    value  = "value"
    secure = false
  }

  app_source = {
    type     = "git"
    revision = "master"
    url      = "https://github.com/example.git"
  }

  enable_ssl = true

  ssl_configuration = {
    private_key = "${file("./foobar.key")}"
    certificate = "${file("./foobar.crt")}"
  }

  document_root         = "public"
  auto_bundle_on_deploy = true
  rails_env             = "staging"
}

Debug Output

Sorry, I think this is short enough to just paste:

  1 Shortname was inconsistent with current Stacks
An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  ~ aws_opsworks_application.foo-app
      short_name: "foobar" => "FooBar"


Plan: 0 to add, 1 to change, 0 to destroy.

Expected Behavior

Either shortname should have changed or resource should have been recreated.

Actual Behavior

Terraform said it'd change the shortname but it stayed the same.

I checked in AWS Console and apparently you can't change shortname.

Steps to Reproduce

  1. terraform apply with some shortname
  2. Change the shortname to something else
  3. terraform apply
  4. Check that the app remains with the same shortname

Important Factoids

None

References

None

@bflad bflad added bug Addresses a defect in current functionality. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/opsworks Issues and PRs that pertain to the opsworks service. labels Oct 30, 2018
@bflad bflad added this to the v1.43.0 milestone Nov 6, 2018
@bflad
Copy link
Contributor

bflad commented Nov 6, 2018

The fix for properly triggering resource recreation on short_name updates has been merged and will release with version 1.43.0 of the AWS provider, likely later today or tomorrow. 👍

@omnibs
Copy link
Author

omnibs commented Nov 6, 2018

Rad! Thanks for the quick fix!

@bflad
Copy link
Contributor

bflad commented Nov 7, 2018

This has been released in version 1.43.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. good first issue Call to action for new contributors looking for a place to start. Smaller or straightforward issues. service/opsworks Issues and PRs that pertain to the opsworks service.
Projects
None yet
2 participants