Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aws_subnet_network_acl_association #5466

Closed
gkrizek opened this issue Aug 7, 2018 · 4 comments
Closed

Add support for aws_subnet_network_acl_association #5466

gkrizek opened this issue Aug 7, 2018 · 4 comments

Comments

@gkrizek
Copy link
Contributor

gkrizek commented Aug 7, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

We are missing something similar to AWS::EC2::SubnetNetworkAclAssociation in CloudFormation. There currently isn't a way to associate subnets with network acls. I think we need to create a aws_subnet_network_acl_association resource for this. Only parameters needed are subnet_id and network_acl_id.

New or Affected Resource(s)

  • aws_subnet_network_acl_association

Potential Terraform Configuration

resource "aws_subnet_network_acl_association" "subnet_a" {
  subnet_id      = "${aws_subnet.public_a.id}"
  network_acl_id = "${aws_network_acl.public_acl.id}"
}

References

@catsby
Copy link
Contributor

catsby commented Aug 7, 2018

Hey @gkrizek ! We're beholden to the public API / SDK, which I'm having difficulty finding this API call in, do you by chance know where I can find it?

I'm looking here:

@catsby catsby added the waiting-response Maintainers are waiting on response from community or contributor. label Aug 7, 2018
@gkrizek
Copy link
Contributor Author

gkrizek commented Aug 7, 2018

@catsby, I think you are right! I don't see any API method for associating a subnet with a Network ACL. So I guess it's not possible. I just ran my terraform template without this feature and it worked on. I just have to use the default Network ACL that is created with the VPC instead of creating a new one.

So I'm able to work around it, but it's strange AWS doesn't have an API for that.

@gkrizek gkrizek closed this as completed Aug 7, 2018
@phillbaker
Copy link

@catsby would ReplaceNetworkAclAssociation documented in https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_ReplaceNetworkAclAssociation.html handle this functionality?

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 16, 2019
@ghost
Copy link

ghost commented Dec 17, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants