Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_default_vpc: Full resource lifecycle #4959

Closed
ewbankkit opened this issue Jun 22, 2018 · 8 comments · Fixed by #22253 or #22776
Closed

r/aws_default_vpc: Full resource lifecycle #4959

ewbankkit opened this issue Jun 22, 2018 · 8 comments · Fixed by #22253 or #22776
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Jun 22, 2018

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Now that default VPCs can be created we should think about a "next generation" aws_default_vpc resource that can do full resource lifecycle operations (Create and Delete along with Read and Update).

@ewbankkit
Copy link
Contributor Author

Replaces #1289 and #4290.

@ewbankkit
Copy link
Contributor Author

Similar to #4957.

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. labels Jun 26, 2018
@lorengordon
Copy link
Contributor

I'd find this valuable, in particular to be able to set the VPC CIDR for the default VPC. The resource should be able to create, update, and delete the default vpc. A user could import the existing resource into a config with matching attributes to avoid a resource cycle.

@bflad bflad added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jun 24, 2020
@bflad bflad added this to the v4.0.0 milestone Jun 24, 2020
@dirk39
Copy link
Contributor

dirk39 commented Nov 16, 2021

Let me try this!

@ewbankkit
Copy link
Contributor Author

v4.0.0 Design

Modify the aws_default_vpc resource to be able to Create and Delete default VPCs.
This will be implemented so as to maximize infrastructure safety and minimize practitioner surprise.
If a default VPC already exists, on resource Create adopt the resource into management, otherwise call the CreateDefaultVpc API to create a new default VPC
On resource Delete the default VPC is not deleted (it is removed from Terraform state), unless the configuration sets the new argument force_destroy = true. This argument’s default value will be false.

@anGie44
Copy link
Contributor

anGie44 commented Jan 26, 2022

Implementation complete with merge of #22253

@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
5 participants