Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_ecs_service: Add 'vpc_lattice_configurations' #40177

Merged
merged 21 commits into from
Nov 21, 2024
Merged

resource/aws_ecs_service: Add 'vpc_lattice_configurations' #40177

merged 21 commits into from
Nov 21, 2024
+494 −0

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Nov 19, 2024 •
edited
Loading

Description

Add support for vpc_lattice_configurations to aws_ecs_service

Closes #40176

Output from Acceptance Testing

% make testacc PKG=ecs TESTS=TestAccECSService_

--- PASS: TestAccECSService_iamRole (42.09s)
--- PASS: TestAccECSService_DeploymentControllerType_external (54.54s)
--- PASS: TestAccECSService_deploymentCircuitBreaker (70.64s)
--- PASS: TestAccECSService_DeploymentValues_basic (70.78s)
--- PASS: TestAccECSService_clusterName (81.17s)
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (81.82s)
--- PASS: TestAccECSService_forceNewDeployment (82.36s)
--- PASS: TestAccECSService_basic (90.89s)
--- PASS: TestAccECSService_alarmsAdd (92.76s)
--- PASS: TestAccECSService_alarmsUpdate (92.83s)
--- PASS: TestAccECSService_Tags_managed (58.86s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (30.18s)
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (38.64s)
--- PASS: TestAccECSService_executeCommand (79.23s)
--- PASS: TestAccECSService_ServiceRegistries_basic (147.31s)
--- PASS: TestAccECSService_replicaSchedulingStrategy (68.49s)
--- PASS: TestAccECSService_Tags_propagate (86.17s)
--- PASS: TestAccECSService_ServiceConnect_basic (165.44s)
--- PASS: TestAccECSService_PlacementConstraints_basic (65.93s)
--- PASS: TestAccECSService_PlacementStrategy_missing (1.07s)
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (171.61s)
--- PASS: TestAccECSService_ServiceConnect_tls_with_empty_timeout (172.72s)
--- PASS: TestAccECSService_ServiceConnect_full (173.18s)
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (57.06s)
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (124.51s)
--- PASS: TestAccECSService_LaunchTypeEC2_network (111.54s)
--- PASS: TestAccECSService_Tags_basic (75.33s)
--- PASS: TestAccECSService_LaunchTypeFargate_basic (121.71s)
--- PASS: TestAccECSService_familyAndRevision (77.33s)
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (158.57s)
--- PASS: TestAccECSService_PlacementStrategy_basic (94.81s)
--- PASS: TestAccECSService_forceNewDeploymentTriggers (98.29s)
--- PASS: TestAccECSService_VolumeConfiguration_tagSpecifications (65.34s)
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (188.12s)
--- PASS: TestAccECSService_VolumeConfiguration_basic (74.14s)
--- PASS: TestAccECSService_VolumeConfiguration_throughputTypeChange (106.78s)
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (58.22s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (292.56s)
--- PASS: TestAccECSService_loadBalancerChanges (294.96s)
--- PASS: TestAccECSService_alb (301.73s)
--- PASS: TestAccECSService_multipleTargetGroups (303.14s)
--- PASS: TestAccECSService_ServiceRegistries_removal (157.44s)
--- PASS: TestAccECSService_VolumeConfiguration_update (133.19s)
--- PASS: TestAccECSService_ServiceConnect_remove (202.53s)
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (127.92s)
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (133.93s)
--- PASS: TestAccECSService_CapacityProviderStrategy_update (221.84s)
--- PASS: TestAccECSService_ServiceRegistries_container (147.27s)
--- PASS: TestAccECSService_ServiceRegistries_changes (268.11s)
--- PASS: TestAccECSService_disappears (188.41s)
--- PASS: TestAccECSService_basicImport (181.51s)
--- PASS: TestAccECSService_LatticeConfigurations (200.24s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (482.46s)
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (309.89s)

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 19, 2024
@s3cube
Copy link

s3cube commented Nov 19, 2024

Thanks for porting this over, I created an issue #40176 for the same late yesterday

@gdavison gdavison marked this pull request as ready for review November 19, 2024 17:30
@gdavison gdavison requested a review from a team as a code owner November 19, 2024 17:30
YakDriver
YakDriver previously approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make t T=TestAccECSService_ K=ecs
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService_'  -timeout 360m
go: downloading github.com/aws/aws-sdk-go-v2 v1.32.5
go: downloading github.com/aws/smithy-go v1.22.1
go: downloading github.com/aws/aws-sdk-go-v2/service/ecs v1.50.0
go: downloading github.com/aws/aws-sdk-go-v2/service/cloudwatch v1.43.0
go: downloading github.com/aws/aws-sdk-go-v2/service/datasync v1.43.3
go: downloading github.com/aws/aws-sdk-go-v2/service/ec2 v1.189.0
go: downloading github.com/aws/aws-sdk-go-v2/service/emrcontainers v1.33.6
go: downloading github.com/aws/aws-sdk-go-v2/service/iot v1.60.0
go: downloading github.com/aws/aws-sdk-go-v2/service/outposts v1.47.0
go: downloading github.com/aws/aws-sdk-go-v2/service/pinpointsmsvoicev2 v1.18.0
go: downloading github.com/aws/aws-sdk-go-v2/service/route53resolver v1.34.0
go: downloading github.com/aws/aws-sdk-go-v2/service/transfer v1.53.4
go: downloading github.com/aws/aws-sdk-go-v2/internal/configsources v1.3.24
go: downloading github.com/aws/aws-sdk-go-v2/internal/endpoints/v2 v2.6.24
2024/11/19 13:08:50 Initializing Terraform AWS Provider...
=== RUN   TestAccECSService_basic
=== PAUSE TestAccECSService_basic
=== RUN   TestAccECSService_basicImport
=== PAUSE TestAccECSService_basicImport
=== RUN   TestAccECSService_disappears
=== PAUSE TestAccECSService_disappears
=== RUN   TestAccECSService_LatticeConfigurations
=== PAUSE TestAccECSService_LatticeConfigurations
=== RUN   TestAccECSService_PlacementStrategy_unnormalized
=== PAUSE TestAccECSService_PlacementStrategy_unnormalized
=== RUN   TestAccECSService_CapacityProviderStrategy_basic
=== PAUSE TestAccECSService_CapacityProviderStrategy_basic
=== RUN   TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== PAUSE TestAccECSService_CapacityProviderStrategy_forceNewDeployment
=== RUN   TestAccECSService_CapacityProviderStrategy_update
=== PAUSE TestAccECSService_CapacityProviderStrategy_update
=== RUN   TestAccECSService_VolumeConfiguration_basic
=== PAUSE TestAccECSService_VolumeConfiguration_basic
=== RUN   TestAccECSService_VolumeConfiguration_tagSpecifications
=== PAUSE TestAccECSService_VolumeConfiguration_tagSpecifications
=== RUN   TestAccECSService_VolumeConfiguration_update
=== PAUSE TestAccECSService_VolumeConfiguration_update
=== RUN   TestAccECSService_VolumeConfiguration_throughputTypeChange
=== PAUSE TestAccECSService_VolumeConfiguration_throughputTypeChange
=== RUN   TestAccECSService_familyAndRevision
=== PAUSE TestAccECSService_familyAndRevision
=== RUN   TestAccECSService_healthCheckGracePeriodSeconds
=== PAUSE TestAccECSService_healthCheckGracePeriodSeconds
=== RUN   TestAccECSService_iamRole
=== PAUSE TestAccECSService_iamRole
=== RUN   TestAccECSService_DeploymentControllerType_codeDeploy
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeploy
=== RUN   TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
=== PAUSE TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
=== RUN   TestAccECSService_DeploymentControllerType_external
=== PAUSE TestAccECSService_DeploymentControllerType_external
=== RUN   TestAccECSService_alarmsAdd
=== PAUSE TestAccECSService_alarmsAdd
=== RUN   TestAccECSService_alarmsUpdate
=== PAUSE TestAccECSService_alarmsUpdate
=== RUN   TestAccECSService_DeploymentValues_basic
=== PAUSE TestAccECSService_DeploymentValues_basic
=== RUN   TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== PAUSE TestAccECSService_DeploymentValues_minZeroMaxOneHundred
=== RUN   TestAccECSService_deploymentCircuitBreaker
=== PAUSE TestAccECSService_deploymentCircuitBreaker
=== RUN   TestAccECSService_loadBalancerChanges
=== PAUSE TestAccECSService_loadBalancerChanges
=== RUN   TestAccECSService_clusterName
=== PAUSE TestAccECSService_clusterName
=== RUN   TestAccECSService_alb
=== PAUSE TestAccECSService_alb
=== RUN   TestAccECSService_multipleTargetGroups
=== PAUSE TestAccECSService_multipleTargetGroups
=== RUN   TestAccECSService_forceNewDeployment
=== PAUSE TestAccECSService_forceNewDeployment
=== RUN   TestAccECSService_forceNewDeploymentTriggers
=== PAUSE TestAccECSService_forceNewDeploymentTriggers
=== RUN   TestAccECSService_PlacementStrategy_basic
=== PAUSE TestAccECSService_PlacementStrategy_basic
=== RUN   TestAccECSService_PlacementStrategy_missing
=== PAUSE TestAccECSService_PlacementStrategy_missing
=== RUN   TestAccECSService_PlacementConstraints_basic
=== PAUSE TestAccECSService_PlacementConstraints_basic
=== RUN   TestAccECSService_PlacementConstraints_emptyExpression
=== PAUSE TestAccECSService_PlacementConstraints_emptyExpression
=== RUN   TestAccECSService_LaunchTypeFargate_basic
=== PAUSE TestAccECSService_LaunchTypeFargate_basic
=== RUN   TestAccECSService_LaunchTypeFargate_platformVersion
=== PAUSE TestAccECSService_LaunchTypeFargate_platformVersion
=== RUN   TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_waitForSteadyState
=== RUN   TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== PAUSE TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
=== RUN   TestAccECSService_LaunchTypeEC2_network
=== PAUSE TestAccECSService_LaunchTypeEC2_network
=== RUN   TestAccECSService_DaemonSchedulingStrategy_basic
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_basic
=== RUN   TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== PAUSE TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
=== RUN   TestAccECSService_replicaSchedulingStrategy
=== PAUSE TestAccECSService_replicaSchedulingStrategy
=== RUN   TestAccECSService_ServiceRegistries_basic
=== PAUSE TestAccECSService_ServiceRegistries_basic
=== RUN   TestAccECSService_ServiceRegistries_container
=== PAUSE TestAccECSService_ServiceRegistries_container
=== RUN   TestAccECSService_ServiceRegistries_changes
=== PAUSE TestAccECSService_ServiceRegistries_changes
=== RUN   TestAccECSService_ServiceRegistries_removal
=== PAUSE TestAccECSService_ServiceRegistries_removal
=== RUN   TestAccECSService_ServiceConnect_basic
=== PAUSE TestAccECSService_ServiceConnect_basic
=== RUN   TestAccECSService_ServiceConnect_full
=== PAUSE TestAccECSService_ServiceConnect_full
=== RUN   TestAccECSService_ServiceConnect_tls_with_empty_timeout
=== PAUSE TestAccECSService_ServiceConnect_tls_with_empty_timeout
=== RUN   TestAccECSService_ServiceConnect_ingressPortOverride
=== PAUSE TestAccECSService_ServiceConnect_ingressPortOverride
=== RUN   TestAccECSService_ServiceConnect_remove
=== PAUSE TestAccECSService_ServiceConnect_remove
=== RUN   TestAccECSService_Tags_basic
=== PAUSE TestAccECSService_Tags_basic
=== RUN   TestAccECSService_Tags_managed
=== PAUSE TestAccECSService_Tags_managed
=== RUN   TestAccECSService_Tags_propagate
=== PAUSE TestAccECSService_Tags_propagate
=== RUN   TestAccECSService_executeCommand
=== PAUSE TestAccECSService_executeCommand
=== CONT  TestAccECSService_basic
=== CONT  TestAccECSService_forceNewDeployment
=== CONT  TestAccECSService_ServiceRegistries_basic
=== CONT  TestAccECSService_executeCommand
=== CONT  TestAccECSService_Tags_propagate
=== CONT  TestAccECSService_Tags_managed
=== CONT  TestAccECSService_Tags_basic
=== CONT  TestAccECSService_ServiceConnect_remove
=== CONT  TestAccECSService_ServiceConnect_ingressPortOverride
=== CONT  TestAccECSService_ServiceConnect_tls_with_empty_timeout
=== CONT  TestAccECSService_ServiceConnect_full
=== CONT  TestAccECSService_ServiceConnect_basic
=== CONT  TestAccECSService_ServiceRegistries_removal
=== CONT  TestAccECSService_ServiceRegistries_changes
=== CONT  TestAccECSService_ServiceRegistries_container
=== CONT  TestAccECSService_iamRole
=== CONT  TestAccECSService_multipleTargetGroups
=== CONT  TestAccECSService_alb
=== CONT  TestAccECSService_clusterName
=== CONT  TestAccECSService_LaunchTypeFargate_platformVersion
--- PASS: TestAccECSService_iamRole (40.88s)
=== CONT  TestAccECSService_loadBalancerChanges
--- PASS: TestAccECSService_Tags_managed (64.98s)
=== CONT  TestAccECSService_deploymentCircuitBreaker
--- PASS: TestAccECSService_basic (74.26s)
=== CONT  TestAccECSService_DeploymentValues_minZeroMaxOneHundred
--- PASS: TestAccECSService_clusterName (75.34s)
=== CONT  TestAccECSService_DeploymentValues_basic
--- PASS: TestAccECSService_executeCommand (84.96s)
=== CONT  TestAccECSService_alarmsUpdate
--- PASS: TestAccECSService_Tags_propagate (92.92s)
=== CONT  TestAccECSService_alarmsAdd
--- PASS: TestAccECSService_Tags_basic (94.21s)
=== CONT  TestAccECSService_DeploymentControllerType_external
--- PASS: TestAccECSService_forceNewDeployment (105.66s)
=== CONT  TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
--- PASS: TestAccECSService_DeploymentControllerType_external (27.33s)
=== CONT  TestAccECSService_replicaSchedulingStrategy
--- PASS: TestAccECSService_DeploymentValues_basic (59.02s)
=== CONT  TestAccECSService_DeploymentControllerType_codeDeploy
--- PASS: TestAccECSService_deploymentCircuitBreaker (69.52s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (69.29s)
=== CONT  TestAccECSService_LaunchTypeEC2_network
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (145.13s)
=== CONT  TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
--- PASS: TestAccECSService_ServiceConnect_basic (154.13s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_basic
--- PASS: TestAccECSService_ServiceRegistries_container (157.96s)
=== CONT  TestAccECSService_LaunchTypeFargate_waitForSteadyState
--- PASS: TestAccECSService_ServiceRegistries_basic (158.32s)
=== CONT  TestAccECSService_CapacityProviderStrategy_update
--- PASS: TestAccECSService_ServiceRegistries_removal (158.64s)
=== CONT  TestAccECSService_PlacementConstraints_basic
--- PASS: TestAccECSService_alarmsAdd (67.57s)
=== CONT  TestAccECSService_healthCheckGracePeriodSeconds
--- PASS: TestAccECSService_alarmsUpdate (77.93s)
=== CONT  TestAccECSService_LaunchTypeFargate_basic
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (172.01s)
=== CONT  TestAccECSService_familyAndRevision
--- PASS: TestAccECSService_ServiceConnect_tls_with_empty_timeout (172.08s)
=== CONT  TestAccECSService_PlacementConstraints_emptyExpression
--- PASS: TestAccECSService_ServiceConnect_full (172.18s)
=== CONT  TestAccECSService_VolumeConfiguration_throughputTypeChange
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (37.72s)
=== CONT  TestAccECSService_VolumeConfiguration_update
--- PASS: TestAccECSService_replicaSchedulingStrategy (69.17s)
=== CONT  TestAccECSService_PlacementStrategy_unnormalized
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (37.86s)
=== CONT  TestAccECSService_VolumeConfiguration_tagSpecifications
--- PASS: TestAccECSService_ServiceConnect_remove (193.60s)
=== CONT  TestAccECSService_CapacityProviderStrategy_forceNewDeployment
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (59.27s)
=== CONT  TestAccECSService_VolumeConfiguration_basic
--- PASS: TestAccECSService_PlacementConstraints_basic (78.69s)
=== CONT  TestAccECSService_CapacityProviderStrategy_basic
--- PASS: TestAccECSService_familyAndRevision (76.46s)
=== CONT  TestAccECSService_disappears
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (59.07s)
=== CONT  TestAccECSService_LatticeConfigurations
--- PASS: TestAccECSService_LaunchTypeEC2_network (107.42s)
=== CONT  TestAccECSService_basicImport
--- PASS: TestAccECSService_VolumeConfiguration_throughputTypeChange (87.29s)
=== CONT  TestAccECSService_PlacementStrategy_basic
--- PASS: TestAccECSService_VolumeConfiguration_tagSpecifications (70.24s)
=== CONT  TestAccECSService_PlacementStrategy_missing
--- PASS: TestAccECSService_PlacementStrategy_missing (0.64s)
=== CONT  TestAccECSService_forceNewDeploymentTriggers
--- PASS: TestAccECSService_ServiceRegistries_changes (280.68s)
--- PASS: TestAccECSService_VolumeConfiguration_update (109.07s)
--- PASS: TestAccECSService_LaunchTypeFargate_basic (118.98s)
--- PASS: TestAccECSService_multipleTargetGroups (290.94s)
--- PASS: TestAccECSService_VolumeConfiguration_basic (70.51s)
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (163.80s)
--- PASS: TestAccECSService_alb (308.96s)
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (125.47s)
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (173.96s)
--- PASS: TestAccECSService_loadBalancerChanges (297.05s)
--- PASS: TestAccECSService_PlacementStrategy_basic (83.31s)
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (120.92s)
--- PASS: TestAccECSService_forceNewDeploymentTriggers (98.68s)
--- PASS: TestAccECSService_CapacityProviderStrategy_update (217.34s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (296.06s)
--- PASS: TestAccECSService_disappears (189.04s)
--- PASS: TestAccECSService_LatticeConfigurations (189.39s)
--- PASS: TestAccECSService_basicImport (193.15s)
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (314.83s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (460.89s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecs	570.652s

internal/service/ecs/service.go Outdated Show resolved Hide resolved
Satej Sawant and others added 20 commits November 20, 2024 14:24
jar-b
jar-b approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=ecs TESTS=TestAccECSService_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ecs/... -v -count 1 -parallel 20 -run='TestAccECSService_'  -timeout 360m
2024/11/21 09:38:47 Initializing Terraform AWS Provider...

--- PASS: TestAccECSService_iamRole (53.10s)
=== CONT  TestAccECSService_ServiceRegistries_changes
--- PASS: TestAccECSService_clusterName (69.22s)
=== CONT  TestAccECSService_ServiceRegistries_container
--- PASS: TestAccECSService_Tags_managed (70.35s)
=== CONT  TestAccECSService_CapacityProviderStrategy_update
--- PASS: TestAccECSService_DeploymentValues_minZeroMaxOneHundred (78.93s)
=== CONT  TestAccECSService_healthCheckGracePeriodSeconds
--- PASS: TestAccECSService_deploymentCircuitBreaker (80.31s)
=== CONT  TestAccECSService_familyAndRevision
--- PASS: TestAccECSService_basic (88.15s)
=== CONT  TestAccECSService_VolumeConfiguration_throughputTypeChange
--- PASS: TestAccECSService_Tags_propagate (88.36s)
=== CONT  TestAccECSService_VolumeConfiguration_update
--- PASS: TestAccECSService_executeCommand (90.90s)
=== CONT  TestAccECSService_VolumeConfiguration_tagSpecifications
--- PASS: TestAccECSService_Tags_basic (91.07s)
=== CONT  TestAccECSService_VolumeConfiguration_basic
--- PASS: TestAccECSService_forceNewDeployment (110.76s)
=== CONT  TestAccECSService_PlacementStrategy_unnormalized
--- PASS: TestAccECSService_ServiceRegistries_basic (148.82s)
=== CONT  TestAccECSService_CapacityProviderStrategy_forceNewDeployment
--- PASS: TestAccECSService_familyAndRevision (79.05s)
=== CONT  TestAccECSService_CapacityProviderStrategy_basic
--- PASS: TestAccECSService_ServiceRegistries_removal (159.49s)
=== CONT  TestAccECSService_disappears
--- PASS: TestAccECSService_VolumeConfiguration_basic (71.17s)
=== CONT  TestAccECSService_LatticeConfigurations
--- PASS: TestAccECSService_VolumeConfiguration_tagSpecifications (71.55s)
=== CONT  TestAccECSService_DeploymentValues_basic
--- PASS: TestAccECSService_ServiceConnect_basic (166.20s)
=== CONT  TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod
--- PASS: TestAccECSService_PlacementStrategy_unnormalized (59.59s)
=== CONT  TestAccECSService_DeploymentControllerType_external
--- PASS: TestAccECSService_VolumeConfiguration_throughputTypeChange (82.36s)
=== CONT  TestAccECSService_basicImport
--- PASS: TestAccECSService_ServiceConnect_ingressPortOverride (173.16s)
=== CONT  TestAccECSService_alarmsAdd
--- PASS: TestAccECSService_ServiceConnect_tls_with_empty_timeout (173.31s)
=== CONT  TestAccECSService_alarmsUpdate
--- PASS: TestAccECSService_ServiceConnect_full (173.33s)
=== CONT  TestAccECSService_LaunchTypeFargate_platformVersion
--- PASS: TestAccECSService_ServiceConnect_remove (195.60s)
=== CONT  TestAccECSService_PlacementConstraints_basic
--- PASS: TestAccECSService_VolumeConfiguration_update (111.13s)
=== CONT  TestAccECSService_replicaSchedulingStrategy
--- PASS: TestAccECSService_DeploymentControllerType_external (33.03s)
=== CONT  TestAccECSService_LaunchTypeFargate_basic
--- PASS: TestAccECSService_ServiceRegistries_container (152.02s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum
--- PASS: TestAccECSService_DeploymentValues_basic (59.25s)
=== CONT  TestAccECSService_PlacementConstraints_emptyExpression
--- PASS: TestAccECSService_alarmsAdd (70.39s)
=== CONT  TestAccECSService_DaemonSchedulingStrategy_basic
--- PASS: TestAccECSService_alarmsUpdate (84.10s)
=== CONT  TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState
--- PASS: TestAccECSService_DaemonSchedulingStrategy_setDeploymentMinimum (38.47s)
=== CONT  TestAccECSService_LaunchTypeFargate_waitForSteadyState
--- PASS: TestAccECSService_PlacementConstraints_basic (69.27s)
=== CONT  TestAccECSService_LaunchTypeEC2_network
--- PASS: TestAccECSService_replicaSchedulingStrategy (69.67s)
=== CONT  TestAccECSService_PlacementStrategy_basic
--- PASS: TestAccECSService_CapacityProviderStrategy_forceNewDeployment (121.14s)
=== CONT  TestAccECSService_PlacementStrategy_missing
--- PASS: TestAccECSService_PlacementStrategy_missing (0.79s)
=== CONT  TestAccECSService_DeploymentControllerType_codeDeploy
--- PASS: TestAccECSService_DaemonSchedulingStrategy_basic (29.64s)
=== CONT  TestAccECSService_forceNewDeploymentTriggers
--- PASS: TestAccECSService_PlacementConstraints_emptyExpression (59.69s)
--- PASS: TestAccECSService_multipleTargetGroups (281.53s)
--- PASS: TestAccECSService_loadBalancerChanges (282.11s)
--- PASS: TestAccECSService_CapacityProviderStrategy_update (221.47s)
--- PASS: TestAccECSService_alb (297.72s)
--- PASS: TestAccECSService_CapacityProviderStrategy_basic (139.65s)
--- PASS: TestAccECSService_LaunchTypeFargate_platformVersion (140.14s)
--- PASS: TestAccECSService_LaunchTypeFargate_basic (119.99s)
--- PASS: TestAccECSService_ServiceRegistries_changes (284.73s)
--- PASS: TestAccECSService_LatticeConfigurations (184.62s)
--- PASS: TestAccECSService_disappears (189.34s)
--- PASS: TestAccECSService_PlacementStrategy_basic (85.36s)
--- PASS: TestAccECSService_basicImport (184.42s)
--- PASS: TestAccECSService_LaunchTypeEC2_network (116.92s)
--- PASS: TestAccECSService_forceNewDeploymentTriggers (109.74s)
--- PASS: TestAccECSService_healthCheckGracePeriodSeconds (320.71s)
--- PASS: TestAccECSService_LaunchTypeFargate_updateWaitForSteadyState (174.07s)
--- PASS: TestAccECSService_LaunchTypeFargate_waitForSteadyState (172.88s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeploy (285.57s)
--- PASS: TestAccECSService_DeploymentControllerType_codeDeployUpdateDesiredCountAndHealthCheckGracePeriod (477.40s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecs        650.115s

@gdavison gdavison merged commit 5227827 into main Nov 21, 2024
41 checks passed
@gdavison gdavison deleted the f-aws_ecs_service_vpcl branch November 21, 2024 15:04
@github-actions github-actions bot added this to the v5.77.0 milestone Nov 21, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Nov 21, 2024
Update CHANGELOG.md for #40177
32bf7df
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 21, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.77.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

@YakDriver YakDriver YakDriver left review comments

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/ecs Issues and PRs that pertain to the ecs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.77.0
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for VPC Lattice Configurations to AWS ECS Service
4 participants
@gdavison @s3cube @jar-b @YakDriver